Skip to contentSkip to conversation

wifi: ipw2x00/lib80211: select ARC4 helper

PATCH In review Arnd Bergmann 3 participants 3 messages Oct 15, 2024 Intel pro/wireless 2100, 2200BG, 2915ABG network connection support

lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 wifi: ipw2x00/lib80211: select ARC4 helper

From: Arnd Bergmann <[email protected]>

The lib80211 code uses arc4 crypto helpers that can be disabled:

ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!

Select the library from Kconfig to ensure this can be called.

Fixes 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/net/wireless/intel/ipw2x00/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/net/wireless/intel/ipw2x00/Kconfig +1 -0
index 5e98be664d38..98a17c941100 100644
@@ -6,6 +6,7 @@
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
 	depends on PCI && CFG80211
+	select CRYPTO_LIB_ARC4
 	select WIRELESS_EXT
 	select WEXT_PRIV
 	select FW_LOADER
Signature · 1 line
2.39.5
#1 lore raw
Quoted 11 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

The lib80211 code uses arc4 crypto helpers that can be disabled:

ERROR: modpost: "arc4_setkey" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!
ERROR: modpost: "arc4_crypt" [drivers/net/wireless/intel/ipw2x00/libipw.ko] undefined!

Select the library from Kconfig to ensure this can be called.

Fixes 02f220b52670 ("wifi: ipw2x00/lib80211: move remaining lib80211 into libipw")

Right, sorry. I sent a similar one before:

https://lore.kernel.org/linux-wireless/20241011115820.070c468b271d.Iac76e81b5cd9a5b949b8c154381128e8131d581d@changeid/

drivers/net/wireless/intel/ipw2x00/Kconfig line 10

Quoted 7 lines

+++ b/drivers/net/wireless/intel/ipw2x00/Kconfig

drivers/net/wireless/intel/ipw2x00/Kconfig +1 -0
@@ -6,6 +6,7 @@
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
 	depends on PCI && CFG80211
+	select CRYPTO_LIB_ARC4

I think this got to the wrong place?

johannes

#2 lore raw
Quoted 8 lines · Johannes Berg

drivers/net/wireless/intel/ipw2x00/Kconfig line 10

Quoted 7 lines

+++ b/drivers/net/wireless/intel/ipw2x00/Kconfig

drivers/net/wireless/intel/ipw2x00/Kconfig +1 -0
@@ -6,6 +6,7 @@
 config IPW2100
 	tristate "Intel PRO/Wireless 2100 Network Connection"
 	depends on PCI && CFG80211
+	select CRYPTO_LIB_ARC4

I think this got to the wrong place?

Right, your versions is the correct one.

Arnd