ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
PATCH 1/1 ALSA: hda/conexant - Use cached pin control for Node 0x1d on HP EliteOne 1000 G2
The cached version avoids redundant commands to the codec, improving stability and reducing unnecessary operations. This change ensures better power management and reliable restoration of pin configurations, especially after hibernation (S4) and other power transitions.
Fixes 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")
Suggested-by Kai-Heng Feng <[email protected]>
Suggested-by Takashi Iwai <[email protected]>
Signed-off-by Vasiliy Kovalev <[email protected]>
--- sound/pci/hda/patch_conexant.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
sound/pci/hda/patch_conexant.c +1 -1
@@ -330,7 +330,7 @@ static void cxt_fixup_update_pinctl(struct hda_codec *codec,* This is the value stored in the codec register after * the correct initialization of the previous windows boot. */ -snd_hda_set_pin_ctl (codec,0x1d ,AC_PINCTL_HP_EN ); +snd_hda_set_pin_ctl_cache (codec,0x1d ,AC_PINCTL_HP_EN ); } }
Signature · 1 line
2.33.8
Quoted 10 lines · Vasiliy Kovalev
The cached version avoids redundant commands to the codec, improving stability and reducing unnecessary operations. This change ensures better power management and reliable restoration of pin configurations, especially after hibernation (S4) and other power transitions.
Fixes 9988844c457f ("ALSA: hda/conexant - Fix audio routing for HP EliteOne 1000 G2")Suggested-by Kai-Heng Feng <[email protected]>Suggested-by Takashi Iwai <[email protected]>Signed-off-by Vasiliy Kovalev <[email protected]>
Applied now. Thanks.
Takashi