Skip to contentSkip to conversation

tune-cortexa32: set tune feature as armv8a

PATCH In review Jagadeesh Krishnanjanappa 4 participants 5 messages Oct 16, 2024 – Oct 17, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 tune-cortexa32: set tune feature as armv8a

Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture.

It solves the following build error while compiling libgcc-initial
and libssp-nonshared.
-- snip --
aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon' aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard' -- snip --

---
 meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc +1 -1
index 25bdf12b18..0eb938a240 100644
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto"
 ARMPKGARCH:tune-cortexa32             = "cortexa32"
 ARMPKGARCH:tune-cortexa32-crypto      = "cortexa32"
 # We do not want -march since -mcpu is added above to cover for it
-TUNE_FEATURES:tune-cortexa32          = "aarch64 cortexa32 crc callconvention-hard neon"
+TUNE_FEATURES:tune-cortexa32          = "armv8a cortexa32 crc callconvention-hard neon"
 TUNE_FEATURES:tune-cortexa32-crypto   = "${TUNE_FEATURES:tune-cortexa32} crypto"
 PACKAGE_EXTRA_ARCHS:tune-cortexa32             = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon"
 PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto      = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto"
Signature · 1 line
2.17.1
#1 lore raw
Quoted 4 lines · Jagadeesh Krishnanjanappa via lists.openembedded.org

Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture.

That's right. its aarch32 only arch. This change is fine to apply.

Quoted 37 lines

It solves the following build error while compiling libgcc-initial
and libssp-nonshared.
-- snip --
aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfpu=neon' aarch64-poky-linux-musl-gcc: error: unrecognized command-line option '-mfloat-abi=hard' -- snip --

---
 meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc +1 -2
index 25bdf12b18..0eb938a240 100644
@@ -10,7 +10,7 @@ AVAILTUNES += "cortexa32 cortexa32-crypto"
 ARMPKGARCH:tune-cortexa32             = "cortexa32"
 ARMPKGARCH:tune-cortexa32-crypto      = "cortexa32"
 # We do not want -march since -mcpu is added above to cover for it
-TUNE_FEATURES:tune-cortexa32          = "aarch64 cortexa32 crc callconvention-hard neon"
+TUNE_FEATURES:tune-cortexa32          = "armv8a cortexa32 crc callconvention-hard neon"
 TUNE_FEATURES:tune-cortexa32-crypto   = "${TUNE_FEATURES:tune-cortexa32} crypto"
 PACKAGE_EXTRA_ARCHS:tune-cortexa32             = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc} cortexa32 cortexa32hf-neon"
 PACKAGE_EXTRA_ARCHS:tune-cortexa32-crypto      = "${PACKAGE_EXTRA_ARCHS:tune-armv8a-crc-crypto} cortexa32 cortexa32hf-neon cortexa32hf-neon-crypto"
--

2.17.1

-=-=-=-=-=-=-=-=-=-=-=-
Links: You receive all messages sent to this group.
View/Reply Online (#205965): https://lists.openembedded.org/g/openembedded-core/message/205965
Mute This Topic: https://lists.openembedded.org/mt/109042469/1997914
Group Owner: [email protected]
Unsubscribe: https://lists.openembedded.org/g/openembedded-core/unsub [[email protected]]
-=-=-=-=-=-=-=-=-=-=-=-

#2 lore raw

Hi Khem, Jagadeesh,

Quoted 10 lines · Khem Raj via lists.openembedded.org
Quoted 4 lines · Jagadeesh Krishnanjanappa via lists.openembedded.org

Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture.

That's right. its aarch32 only arch. This change is fine to apply.

Do we not have an issue with
TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc callconvention-hard neon"

in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?

Cheers,
Quentin

#3 lore raw
Quoted 4 lines · Quentin Schulz via lists.openembedded.org
Quoted 4 lines
Quoted 3 lines

Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture.

Quoted 8 lines
Quoted 2 lines

That's right. its aarch32 only arch. This change is fine to apply.

Do we not have an issue with
TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc
callconvention-hard neon"

in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?

The patch is addressing that, no? Is there a different file or a different issue?

Alex

#4 lore raw

Hi Alex,

Quoted 10 lines · Alexander Kanavin
Quoted 7 lines · Quentin Schulz via lists.openembedded.org
Quoted 6 lines
Quoted 3 lines

Cortexa32 is a 32-bit armv8a architecture processor, so set the tune feature as armv8a instead of aarch64 which is 64-bit armv8a architecture.

That's right. its aarch32 only arch. This change is fine to apply.

Quoted 9 lines
Quoted 5 lines

Do we not have an issue with
TUNE_FEATURES:tune-cortexa32 = "aarch64 cortexa32 crc
callconvention-hard neon"

in meta/conf/machine/include/arm/armv8a/tune-cortexa32.inc as well too then?

The patch is addressing that, no? Is there a different file or a different issue?

Definitely a different issue... with my reading abilities :)

Sorry for the noise.

Quentin