Skip to contentSkip to conversation

mm: Remove redundant condition for THP folio

PATCH Applied Dev Jain 5 participants 5 messages Oct 18, 2024 – Oct 22, 2024

Subsystems (2)
lore
Share & tools
lore

Dev Jain

author
#0 lore raw

PATCH 1/1 mm: Remove redundant condition for THP folio

folio_test_pmd_mappable() implies folio_test_large(), therefore, simplify the expression for is_thp.

---
 mm/migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/migrate.c +1 -1
index df91248755e4..b43e7b105559 100644
@@ -1731,7 +1731,7 @@ static int migrate_pages_batch(struct list_head *from,
 
 		list_for_each_entry_safe(folio, folio2, from, lru) {
 			is_large = folio_test_large(folio);
-			is_thp = is_large && folio_test_pmd_mappable(folio);
+			is_thp = folio_test_pmd_mappable(folio);
 			nr_pages = folio_nr_pages(folio);
 
 			cond_resched();
Signature · 1 line
2.30.2
Acked-by on v1 1/1
#2 lore raw
In reply to Dev Jain
Quoted 13 lines · Dev Jain

folio_test_pmd_mappable() implies folio_test_large(), therefore, simplify the expression for is_thp.

---
  mm/migrate.c | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
mm/migrate.c +0 -0
index df91248755e4..b43e7b105559 100644

mm/migrate.c static int migrate_pages_batch(struct list_head *from, · line 1737

Quoted 8 lines
mm/migrate.c +1 -1
@@ -1731,7 +1731,7 @@ static int migrate_pages_batch(struct list_head *from,
 
  		list_for_each_entry_safe(folio, folio2, from, lru) {
  			is_large = folio_test_large(folio);
-			is_thp = is_large && folio_test_pmd_mappable(folio);
+			is_thp = folio_test_pmd_mappable(folio);
  			nr_pages = folio_nr_pages(folio);
 
  			cond_resched();
Signature · 3 lines
Cheers,

David / dhildenb
Reviewed-by on v1 1/1
#4 lore raw
In reply to Dev Jain
Quoted 13 lines · Dev Jain

folio_test_pmd_mappable() implies folio_test_large(), therefore, simplify the expression for is_thp.

---
 mm/migrate.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/migrate.c +0 -0
index df91248755e4..b43e7b105559 100644

mm/migrate.c static int migrate_pages_batch(struct list_head *from, · line 1737

Quoted 8 lines
mm/migrate.c +1 -1
@@ -1731,7 +1731,7 @@ static int migrate_pages_batch(struct list_head *from,
 
 		list_for_each_entry_safe(folio, folio2, from, lru) {
 			is_large = folio_test_large(folio);
-			is_thp = is_large && folio_test_pmd_mappable(folio);
+			is_thp = folio_test_pmd_mappable(folio);
 			nr_pages = folio_nr_pages(folio);
 
 			cond_resched();