i2c: Use *-y instead of *-objs in Makefile
Subsystems (2)
PATCH 1/1 i2c: Use *-y instead of *-objs in Makefile
*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).
Let's correct the old usages of *-objs in Makefiles.
--- drivers/i2c/Makefile | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/i2c/Makefile +1 -1
@@ -5,7 +5,7 @@ obj-$(CONFIG_I2C_BOARDINFO) += i2c-boardinfo.o obj-$(CONFIG_I2C) += i2c-core.o -i2c-core-objs := i2c-core-base.o i2c-core-smbus.o +i2c-core-y := i2c-core-base.o i2c-core-smbus.o i2c-core-$(CONFIG_ACPI) += i2c-core-acpi.o i2c-core-$(CONFIG_I2C_SLAVE) += i2c-core-slave.o i2c-core-$(CONFIG_OF) += i2c-core-of.o
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Quoted 5 lines · Andy Shevchenko
*-objs suffix is reserved rather for (user-space) host programs while usually *-y suffix is used for kernel drivers (although *-objs works for that purpose for now).
Let's correct the old usages of *-objs in Makefiles.
Any comments?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 4 lines
Quoted 2 lines
Let's correct the old usages of *-objs in Makefiles.
Any comments?
LGTM. What about fixing the drivers, too, in one go?
Quoted 6 lines · Wolfram Sang
Quoted 4 lines
Quoted 2 lines
Let's correct the old usages of *-objs in Makefiles.
Any comments?
LGTM. What about fixing the drivers, too, in one go?
What drivers do you have in mind?
Shouldn't be separated commit anyway?
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 10 lines · Andy Shevchenko
Quoted 6 lines · Wolfram Sang
Quoted 4 lines
Quoted 2 lines
Let's correct the old usages of *-objs in Makefiles.
Any comments?
LGTM. What about fixing the drivers, too, in one go?
What drivers do you have in mind?
Shouldn't be separated commit anyway?
A separate patch just has been sent.
Signature · 2 lines
With Best Regards, Andy Shevchenko
Quoted 2 lines
Quoted 2 lines
Shouldn't be separated commit anyway?
Can be argued.
This patch applied to for-next, thanks!
Quoted 4 lines · Wolfram Sang
Quoted 2 lines
Quoted 2 lines
Shouldn't be separated commit anyway?
Can be argued.
I have an evidence for my side: LKP complained as my (thanks to be a separate) patch unveiled the issue in the Kconfig there. Meaning that required a new version of the change, while the core part is not affected anyhow.
Quoted 1 line
This patch applied to for-next, thanks!
Thank you!
Signature · 2 lines
With Best Regards, Andy Shevchenko