clk: qcom: remove superfluous alpha settings from PLL configs
Subsystems (3)
cover clk: qcom: remove superfluous alpha settings from PLL configs
There are several alpha PLL configurations, where the alpha mode is enabled even if it is not strictly required in order to get the desired output rate of the PLL. This small series removes those superfluous settings.
---
Gabor Juhos (5):
clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config
clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config
clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config
clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config
drivers/clk/qcom/apss-ipq-pll.c | 3 +-- drivers/clk/qcom/dispcc-qcm2290.c | 2 -- drivers/clk/qcom/dispcc-sm6115.c | 2 -- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 4 files changed, 2 insertions(+), 9 deletions(-)
---
base-commit: 9852d85ec9d492ebef56dc5f229416c925758edc
change-id: 20241021-alpha-mode-cleanup-661b544644d7
Best regards,
Signature · 1 line
Gabor Juhos <[email protected]>
PATCH 1/5 clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
Since neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.
Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.
No functional changes, the initial rate of the PLL is the same both before and after the patch.
Tested on TP-Link Archer AX55 v1 (IPQ5018).
--- drivers/clk/qcom/apss-ipq-pll.c | 1 - 1 file changed, 1 deletion(-)
drivers/clk/qcom/apss-ipq-pll.c +0 -1
@@ -73,7 +73,6 @@ static const struct alpha_pll_config ipq5018_pll_config = { .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2),
Signature · 1 line
2.47.0
Re: [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
Quoted 11 lines · Gabor Juhos
Since neither 'alpha' nor '
alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the superfluous initialization of the '
alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.No functional changes, the initial rate of the PLL is the same both before and after the patch.
After going through DISPCC changes, I think the whole series is
incorrect: these PLL can change the rate (e.g. to facilitate CPU frequency changes). Normally PLL ops do not check the alpha_en bit when changing the rate, so the driver might try to set the PLL to the rate which requires alpha value, while the alpha_en bit isn't set.
Quoted 24 lines
Tested on TP-Link Archer AX55 v1 (IPQ5018).
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/apss-ipq-pll.c | 1 - 1 file changed, 1 deletion(-)drivers/clk/qcom/apss-ipq-pll.c +0
-1@@ -73,7 +73,6 @@ static const struct alpha_pll_config ipq5018_pll_config = { .main_output_mask = BIT(0), .aux_output_mask = BIT(1), .early_output_mask = BIT(3), - .alpha_en_mask = BIT(24), .status_val = 0x3, .status_mask = GENMASK(10, 8), .lock_det = BIT(2),Signature · 2 lines
-- 2.47.0
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
2024. 10. 25. 8:24 keltezéssel, Dmitry Baryshkov írta:
Quoted 10 lines · Gabor Juhos
Quoted 9 lines
Since neither 'alpha' nor '
alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the superfluous initialization of the '
alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.
Quoted 8 lines
Quoted 2 lines
No functional changes, the initial rate of the PLL is the same both before and after the patch.
After going through DISPCC changes, I think the whole series is
incorrect: these PLL can change the rate (e.g. to facilitate CPU frequency changes). Normally PLL ops do not check thealpha_enbit when changing the rate, so the driver might try to set the PLL to the rate which requires alpha value, while thealpha_enbit isn't set.
Both clk_alpha_pll_stromer_set_rate() which is used for IPQ5018 (patch 1), and clk_alpha_pll_stromer_plus_set_rate() used for IPQ5332 (patch 2) sets the ALPHA_EN bit unconditionally.
For the PLLs affected by the remaining patches, clk_alpha_pll_set_rate() is used which also unconditionally sets the ALPHA_EN bit via __clk_alpha_pll_set_rate().
I have created the patches after analysing the side effects of [1]. Due to the bug described in that change, the clk_alpha_pll_configure() function in the current kernel never sets the ALPHA_EN bit in the USER_CTL register. This means that setting 'alpha_en_mask' in the configurations has no effect actually.
So, if we assume that the affected PLLs are working correctly now, it is not because the 'alpha_en_mask' is specifed in the configuration but due to the fact that the set_rate op sets the ALPHA_EN bit.
At least, I came to this after the analysis.
[1]
https://lore.kernel.org/r/[email protected]
Regards,
Gabor
Re: [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
Quoted 32 lines · Gabor Juhos
2024. 10. 25. 8:24 keltezéssel, Dmitry Baryshkov írta:
Quoted 10 lines · Gabor Juhos
Quoted 9 lines
Since neither 'alpha' nor '
alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the superfluous initialization of the '
alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.Quoted 8 lines
Quoted 2 lines
No functional changes, the initial rate of the PLL is the same both before and after the patch.
After going through DISPCC changes, I think the whole series is
incorrect: these PLL can change the rate (e.g. to facilitate CPU frequency changes). Normally PLL ops do not check thealpha_enbit when changing the rate, so the driver might try to set the PLL to the rate which requires alpha value, while thealpha_enbit isn't set.Both
clk_alpha_pll_stromer_set_rate()which is used for IPQ5018 (patch 1), andclk_alpha_pll_stromer_plus_set_rate()used for IPQ5332 (patch 2) sets theALPHA_ENbit unconditionally.For the PLLs affected by the remaining patches,
clk_alpha_pll_set_rate()is used which also unconditionally sets theALPHA_ENbit via__clk_alpha_pll_set_rate().I have created the patches after analysing the side effects of [1]. Due to the bug described in that change, the
clk_alpha_pll_configure()function in the current kernel never sets theALPHA_ENbit in theUSER_CTLregister. This means that setting 'alpha_en_mask' in the configurations has no effect actually.
Quoted 5 lines
So, if we assume that the affected PLLs are working correctly now, it is not because the '
alpha_en_mask' is specifed in the configuration but due to the fact that theset_rateop sets theALPHA_ENbit.At least, I came to this after the analysis.
Ack. Please mention in the commit message that it's safe to drop the alpha_en bit, because it will get reset by the set_rate function.
Quoted 8 lines
[1]
https://lore.kernel.org/r/[email protected]Regards,
Gabor
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH 1/5] clk: qcom: apss-ipq-pll: drop 'alpha_en_mask' from IPQ5018 PLL config
2024. 10. 26. 20:55 keltezéssel, Dmitry Baryshkov írta:
Quoted 33 lines · Gabor Juhos
Quoted 32 lines
2024. 10. 25. 8:24 keltezéssel, Dmitry Baryshkov írta:
Quoted 10 lines · Gabor Juhos
Quoted 9 lines
Since neither 'alpha' nor '
alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the superfluous initialization of the '
alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.Quoted 8 lines
Quoted 2 lines
No functional changes, the initial rate of the PLL is the same both before and after the patch.
After going through DISPCC changes, I think the whole series is
incorrect: these PLL can change the rate (e.g. to facilitate CPU frequency changes). Normally PLL ops do not check thealpha_enbit when changing the rate, so the driver might try to set the PLL to the rate which requires alpha value, while thealpha_enbit isn't set.Both
clk_alpha_pll_stromer_set_rate()which is used for IPQ5018 (patch 1), andclk_alpha_pll_stromer_plus_set_rate()used for IPQ5332 (patch 2) sets theALPHA_ENbit unconditionally.For the PLLs affected by the remaining patches,
clk_alpha_pll_set_rate()is used which also unconditionally sets theALPHA_ENbit via__clk_alpha_pll_set_rate().I have created the patches after analysing the side effects of [1]. Due to the bug described in that change, the
clk_alpha_pll_configure()function in the current kernel never sets theALPHA_ENbit in theUSER_CTLregister. This means that setting 'alpha_en_mask' in the configurations has no effect actually.
Quoted 8 lines
Quoted 5 lines
So, if we assume that the affected PLLs are working correctly now, it is not because the '
alpha_en_mask' is specifed in the configuration but due to the fact that theset_rateop sets theALPHA_ENbit.At least, I came to this after the analysis.
Ack. Please mention in the commit message that it's safe to drop the
alpha_enbit, because it will get reset by theset_ratefunction.
Ok.
PATCH 2/5 clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config
In reply to Gabor JuhosSince neither 'alpha' nor 'alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.
Remove the superfluous initialization of the 'alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.
While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the initial rate of the PLL is the same both before and after the patch.
Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board).
--- drivers/clk/qcom/apss-ipq-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/clk/qcom/apss-ipq-pll.c +1 -1
@@ -79,13 +79,13 @@ static const struct alpha_pll_config ipq5018_pll_config = { .test_ctl_hi_val = 0x00400003, }; +/* 1.080 GHz configuration */ static const struct alpha_pll_config ipq5332_pll_config = { .l =0x2d , .config_ctl_val =0x4001075b , .main_output_mask =BIT (0 ), .aux_output_mask =BIT (1 ), .early_output_mask =BIT (3 ), - .alpha_en_mask =BIT (24 ), .status_val =0x3 , .status_mask =GENMASK (10 ,8 ), .lock_det =BIT (2 ),
Signature · 1 line
2.47.0
Re: [PATCH 2/5] clk: qcom: apps-ipq-pll: drop 'alpha_en_mask' from IPQ5332 PLL config
Quoted 15 lines · Gabor Juhos
Since neither 'alpha' nor '
alpha_hi' is defined in the configuration, those will be initialized with zero values implicitly. By using zero alpha values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the superfluous initialization of the '
alpha_en_mask' member to make it clear that enabling alpha mode is not required to get the desired output rate.While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the initial rate of the PLL is the same both before and after the patch.
Quoted 7 lines
Tested on Xiaomi Router BE3600 2.5G (IPQ5312, out-of-tree board).
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/apss-ipq-pll.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
Signature · 2 lines
With best wishes Dmitry
PATCH 3/5 clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config
In reply to Gabor JuhosSince both the 'alpha' and 'alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.
Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate.
While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the PLL runs at 1.2 GHz both before and after the change.
Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board).
--- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/clk/qcom/gcc-ipq6018.c +1 -3
@@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, }; +/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l =0x32 , - .alpha =0x0 , - .alpha_hi =0x0 , .config_ctl_val =0x4001055b , .main_output_mask =BIT (0 ), .pre_div_val =0x0 ,
@@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24), };static struct clk_hw *gcc_ipq6018_hws[] = {
Signature · 1 line
2.47.0
Re: [PATCH 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config
Quoted 25 lines · Gabor Juhos
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate.
While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the PLL runs at 1.2 GHz both before and after the change.
Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board).
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/clk/qcom/gcc-ipq6018.c +0
-0
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config ubi32_pll_config = { · line 4200
Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +1
-2@@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, }; +/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l =0x32 , - .alpha =0x0 , - .alpha_hi =0x0 ,
I'd say this serves documentation purposes: zero alpha value
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config nss_crypto_pll_config = { · line 4209
Quoted 8 lines
drivers/clk/qcom/gcc-ipq6018.c +0
-1.config_ctl_val = 0x4001055b, .main_output_mask = BIT(0), .pre_div_val = 0x0,@@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24),
This is okay
Quoted 7 lines
drivers/clk/qcom/gcc-ipq6018.c +0
-0};static struct clk_hw *gcc_ipq6018_hws[] = {Signature · 2 lines
-- 2.47.0
Signature · 2 lines
With best wishes Dmitry
Re: [PATCH 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config
2024. 10. 25. 8:18 keltezéssel, Dmitry Baryshkov írta:
Quoted 29 lines · Gabor Juhos
Quoted 28 lines
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate.
While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the PLL runs at 1.2 GHz both before and after the change.
Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board).
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/clk/qcom/gcc-ipq6018.c +0
-0@@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, };
Quoted 7 lines
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config ubi32_pll_config = { · line 4200
Quoted 5 lines
drivers/clk/qcom/gcc-ipq6018.c +1
-2+/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l =0x32 , - .alpha =0x0 , - .alpha_hi =0x0 ,I'd say this serves documentation purposes: zero alpha value
For me, setting 'alpha_en_mask' means that the alpha values will be used. If it is not set, then it means that the alpha values are getting ignored. If those will be ignored eventually, specifying even zero alpha values explicitly is pointless in my opinion.
If we really need that for documentation purposes, the comment before the configuration can be changed to indicate that alpha values are not needed.
Quoted 11 lines
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config nss_crypto_pll_config = { · line 4209
Quoted 9 lines
drivers/clk/qcom/gcc-ipq6018.c +0
-1.config_ctl_val = 0x4001055b, .main_output_mask = BIT(0), .pre_div_val = 0x0,@@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24),This is okay
Regards,
Gabor
Dmitry Baryshkov
Reviewed-byRe: [PATCH 3/5] clk: qcom: gcc-ipq6018: remove alpha values from NSS Crypto PLL's config
Quoted 38 lines · Gabor Juhos
2024. 10. 25. 8:18 keltezéssel, Dmitry Baryshkov írta:
Quoted 29 lines · Gabor Juhos
Quoted 28 lines
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that alpha mode is not required to get the desired output rate.
While at it, also add a comment to indicate the frequency the PLL runs at with the current configuration.
No functional changes, the PLL runs at 1.2 GHz both before and after the change.
Tested on Xiaomi Mi Router AX1800 (IPQ6018, out-of-tree board).
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/gcc-ipq6018.c | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-)drivers/clk/qcom/gcc-ipq6018.c +0
-0@@ -4194,10 +4194,9 @@ static const struct alpha_pll_config ubi32_pll_config = { .test_ctl_hi_val = 0x4000, };Quoted 7 lines
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config ubi32_pll_config = { · line 4200
Quoted 5 lines
drivers/clk/qcom/gcc-ipq6018.c +1
-2+/* 1200 MHz configuration */ static const struct alpha_pll_config nss_crypto_pll_config = { .l =0x32 , - .alpha =0x0 , - .alpha_hi =0x0 ,I'd say this serves documentation purposes: zero alpha value
Quoted 4 lines
For me, setting '
alpha_en_mask' means that the alpha values will be used. If it is not set, then it means that the alpha values are getting ignored. If those will be ignored eventually, specifying even zero alpha values explicitly is pointless in my opinion.
Ack, it matches the behaviour by several other CLK drivers.
Quoted 18 lines
If we really need that for documentation purposes, the comment before the configuration can be changed to indicate that alpha values are not needed.
Quoted 11 lines
drivers/clk/qcom/gcc-ipq6018.c static const struct alpha_pll_config nss_crypto_pll_config = { · line 4209
Quoted 9 lines
drivers/clk/qcom/gcc-ipq6018.c +0
-1.config_ctl_val = 0x4001055b, .main_output_mask = BIT(0), .pre_div_val = 0x0,@@ -4206,7 +4205,6 @@ static const struct alpha_pll_config nss_crypto_pll_config = { .post_div_mask = GENMASK(11, 8), .vco_mask = GENMASK(21, 20), .vco_val = 0x0, - .alpha_en_mask = BIT(24),This is okay
Regards,
Gabor
Signature · 2 lines
With best wishes Dmitry
PATCH 4/5 clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config
In reply to Gabor JuhosSince both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.
Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate.
No functional changes intended, compile tested only.
--- drivers/clk/qcom/dispcc-qcm2290.c | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/qcom/dispcc-qcm2290.c +0 -2
@@ -40,8 +40,6 @@ static const struct pll_vco spark_vco[] = {/* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l =0x28 , - .alpha =0x0 , - .alpha_en_mask =BIT (24 ), .vco_val =0x2 <<20 , .vco_mask =GENMASK (21 ,20 ), .main_output_mask =BIT (0 ),
Signature · 1 line
2.47.0
Dmitry Baryshkov
NAKRe: [PATCH 4/5] clk: qcom: dispcc-qcm2290: remove alpha values from disp_cc_pll0_config
Quoted 19 lines · Gabor Juhos
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate.
No functional changes intended, compile tested only.
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/dispcc-qcm2290.c | 2 -- 1 file changed, 2 deletions(-)drivers/clk/qcom/dispcc-qcm2290.c +0
-0
drivers/clk/qcom/dispcc-qcm2290.c static const struct pll_vco spark_vco[] = { · line 44
Quoted 5 lines
drivers/clk/qcom/dispcc-qcm2290.c +0
-2@@ -40,8 +40,6 @@ static const struct pll_vco spark_vco[] = {/* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l =0x28 , - .alpha =0x0 , - .alpha_en_mask =BIT (24 ),
NAK, this pll isn't fixed rate.
Quoted 7 lines
drivers/clk/qcom/dispcc-qcm2290.c +0
-0.vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0),Signature · 2 lines
-- 2.47.0
Signature · 2 lines
With best wishes Dmitry
PATCH 5/5 clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config
In reply to Gabor JuhosSince both the 'alpha' and 'alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.
Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate.
No functional changes intended, compile tested only.
--- drivers/clk/qcom/dispcc-sm6115.c | 2 -- 1 file changed, 2 deletions(-)
drivers/clk/qcom/dispcc-sm6115.c +0 -2
@@ -48,8 +48,6 @@ static const struct pll_vco spark_vco[] = {/* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l =0x28 , - .alpha =0x0 , - .alpha_en_mask =BIT (24 ), .vco_val =0x2 <<20 , .vco_mask =GENMASK (21 ,20 ), .main_output_mask =BIT (0 ),
Signature · 1 line
2.47.0
Dmitry Baryshkov
NAKRe: [PATCH 5/5] clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config
Quoted 19 lines · Gabor Juhos
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate.
No functional changes intended, compile tested only.
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/dispcc-sm6115.c | 2 -- 1 file changed, 2 deletions(-)drivers/clk/qcom/dispcc-sm6115.c +0
-0
drivers/clk/qcom/dispcc-sm6115.c static const struct pll_vco spark_vco[] = { · line 52
Quoted 5 lines
drivers/clk/qcom/dispcc-sm6115.c +0
-2@@ -48,8 +48,6 @@ static const struct pll_vco spark_vco[] = {/* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l =0x28 , - .alpha =0x0 , - .alpha_en_mask =BIT (24 ),
NAK, this isn't a fixed rate PLL.
Quoted 7 lines
drivers/clk/qcom/dispcc-sm6115.c +0
-0.vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0),Signature · 2 lines
-- 2.47.0
Signature · 2 lines
With best wishes Dmitry
Dmitry Baryshkov
Reviewed-byRe: [PATCH 5/5] clk: qcom: dispcc-sm6115: remove alpha values from disp_cc_pll0_config
Quoted 15 lines · Dmitry Baryshkov
Quoted 14 lines · Gabor Juhos
Since both the 'alpha' and '
alpha_hi' members of the configuration is initialized (the latter is implicitly) with zero values, the output rate of the PLL will be the same whether alpha mode is enabled or not.Remove the initialization of the alpha* members to make it clear that the alpha mode is not required to get the desired output rate.
No functional changes intended, compile tested only.
Signed-off-by Gabor Juhos <[email protected]>--- drivers/clk/qcom/dispcc-sm6115.c | 2 -- 1 file changed, 2 deletions(-)
Quoted 12 lines
drivers/clk/qcom/dispcc-sm6115.c static const struct pll_vco spark_vco[] = { · line 52
Quoted 10 lines
drivers/clk/qcom/dispcc-sm6115.c +0
-2@@ -48,8 +48,6 @@ static const struct pll_vco spark_vco[] = {/* 768MHz configuration */ static const struct alpha_pll_config disp_cc_pll0_config = { .l =0x28 , - .alpha =0x0 , - .alpha_en_mask =BIT (24 ),NAK, this isn't a fixed rate PLL.
clk_alpha_pll_set_rate() hadnles this bit.
Quoted 12 lines
Quoted 8 lines
drivers/clk/qcom/dispcc-sm6115.c +0
-0.vco_val = 0x2 << 20, .vco_mask = GENMASK(21, 20), .main_output_mask = BIT(0),Signature · 2 lines
-- 2.47.0Signature · 2 lines
With best wishes Dmitry
Signature · 2 lines
With best wishes Dmitry