RDMA: use ethtool string helpers
PATCH 1/1 RDMA: use ethtool string helpers
Avoids having to manually increment the pointer.
Signed-off-by Rosen Penev <[email protected]>
--- drivers/infiniband/ulp/ipoib/ipoib_ethtool.c | 9 +++------ drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c | 4 +--- 2 files changed, 4 insertions(+), 9 deletions(-)
drivers/infiniband/ulp/ipoib/ipoib_ethtool.c +3 -6
@@ -128,16 +128,13 @@ static void ipoib_get_ethtool_stats(struct net_device *dev,static void ipoib_get_strings (struct net_device __always_unused *dev,u32 stringset,u8 *data) { -u8 *p = data;int i;switch (stringset) {case ETH_SS_STATS : -for (i =0 ; i <IPOIB_GLOBAL_STATS_LEN ; i++) { -memcpy (p, ipoib_gstrings_stats[i].stat_string, -ETH_GSTRING_LEN ); - p +=ETH_GSTRING_LEN ; - } +for (i =0 ; i <IPOIB_GLOBAL_STATS_LEN ; i++) +ethtool_puts (&data, + ipoib_gstrings_stats[i].stat_string);break ;default :break ;
drivers/infiniband/ulp/opa_vnic/opa_vnic_ethtool.c +1 -3
@@ -164,9 +164,7 @@ static void vnic_get_strings(struct net_device *netdev, u32 stringset, u8 *data)return ;for (i =0 ; i <VNIC_STATS_LEN ; i++) -memcpy (data + i *ETH_GSTRING_LEN , - vnic_gstrings_stats[i].stat_string, -ETH_GSTRING_LEN ); +ethtool_puts (&data, vnic_gstrings_stats[i].stat_string); }/* ethtool ops */
Signature · 1 line
2.47.0