Skip to contentSkip to conversation

mm/page_alloc: Use str_off_on() helper in build_all_zonelists()

PATCH Applied Thorsten Blum 2 participants 2 messages Oct 21, 2024 – Oct 22, 2024

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/page_alloc: Use str_off_on() helper in build_all_zonelists()

Remove hard-coded strings by using the str_off_on() helper function.

---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +1 -1
index 8afab64814dc..11d3fa3587db 100644
@@ -5495,7 +5495,7 @@ void __ref build_all_zonelists(pg_data_t *pgdat)
 
 	pr_info("Built %u zonelists, mobility grouping %s.  Total pages: %ld\n",
 		nr_online_nodes,
-		page_group_by_mobility_disabled ? "off" : "on",
+		str_off_on(page_group_by_mobility_disabled),
 		vm_total_pages);
 #ifdef CONFIG_NUMA
 	pr_info("Policy zone: %s\n", zone_names[policy_zone]);
Signature · 1 line
2.47.0
#1 lore raw
Quoted 12 lines · Thorsten Blum

Remove hard-coded strings by using the str_off_on() helper function.

---
 mm/page_alloc.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
mm/page_alloc.c +0 -0
index 8afab64814dc..11d3fa3587db 100644

mm/page_alloc.c void __ref build_all_zonelists(pg_data_t *pgdat) · line 5501

Quoted 8 lines
mm/page_alloc.c +1 -1
@@ -5495,7 +5495,7 @@ void __ref build_all_zonelists(pg_data_t *pgdat)
 
 	pr_info("Built %u zonelists, mobility grouping %s.  Total pages: %ld\n",
 		nr_online_nodes,
-		page_group_by_mobility_disabled ? "off" : "on",
+		str_off_on(page_group_by_mobility_disabled),
 		vm_total_pages);
 #ifdef CONFIG_NUMA
 	pr_info("Policy zone: %s\n", zone_names[policy_zone]);

There are multiple other instances which could use similar str_on_off() as well.

mm/kasan/hw_tags.c:             kasan_vmalloc_enabled() ? "on" : "off",
mm/kasan/hw_tags.c:             kasan_stack_collection_enabled() ? "on" : "off");
mm/kasan/sw_tags.c:             kasan_stack_collection_enabled() ? "on" : "off");
mm/mm_init.c:           stack, want_init_on_alloc(GFP_KERNEL) ? "on" : "off",
mm/mm_init.c:           want_init_on_free() ? "on" : "off");

I would suggest converting all of them together in a single patch instead.