wifi: rtw89: don't check done-ack for entering PS
Ping-Ke Shih
maintainerPATCH 1/1 wifi: rtw89: don't check done-ack for entering PS
From: Chin-Yen Lee <[email protected]>
In WoWLAN mode, driver will disable interrupt after calling H2C command for entering PS mode, but it may lead to failing to enter deep PS mode by firmware because the done-ack of the H2C from firmware is not handled by driver. In fact, the done-ack for entering PS is not necessary for driver to check, so remove it.
--- drivers/net/wireless/realtek/rtw89/fw.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/net/wireless/realtek/rtw89/fw.c +1 -1
@@ -2508,7 +2508,7 @@ int rtw89_fw_h2c_lps_parm(struct rtw89_dev *rtwdev,rtw89_h2c_pkt_set_hdr (rtwdev, skb,FWCMD_TYPE_H2C ,H2C_CAT_MAC ,H2C_CL_MAC_PS , -H2C_FUNC_MAC_LPS_PARM ,0 ,1 , +H2C_FUNC_MAC_LPS_PARM ,0 , !lps_param->psmode,H2C_LPS_PARM_LEN ); ret =rtw89_h2c_tx (rtwdev, skb, false);
Signature · 1 line
2.25.1
Ping-Ke Shih
maintainerQuoted 10 lines · Ping-Ke Shih
From: Chin-Yen Lee <[email protected]>
In WoWLAN mode, driver will disable interrupt after calling H2C command for entering PS mode, but it may lead to failing to enter deep PS mode by firmware because the done-ack of the H2C from firmware is not handled by driver. In fact, the done-ack for entering PS is not necessary for driver to check, so remove it.
Signed-off-by Chin-Yen Lee <[email protected]>Signed-off-by Ping-Ke Shih <[email protected]>
1 patch(es) applied to rtw-next branch of rtw.git, thanks.
345c894ee79b wifi: rtw89: don't check done-ack for entering PS