kvm: selftest: fix noop test in guest_memfd_test.c
PATCH 1/1 kvm: selftest: fix noop test in guest_memfd_test.c
The loop in test_create_guest_memfd_invalid that is supposed to test that nothing is accepted as a valid flag to KVM_CREATE_GUEST_MEMFD was initializing flag as 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... .
--- tools/testing/selftests/kvm/guest_memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
tools/testing/selftests/kvm/guest_memfd_test.c +1 -1
@@ -134,7 +134,7 @@ static void test_create_guest_memfd_invalid(struct kvm_vm *vm) size); } -for (flag =0 ; flag; flag <<=1 ) { +for (flag =BIT (0 ); flag; flag <<=1 ) { fd =__vm_create_guest_memfd (vm, page_size, flag); TEST_ASSERT(fd == -1 && errno == EINVAL, "guest_memfd() with flag '0x%lx' should fail with EINVAL",
Signature · 1 line
2.47.0
Quoted 16 lines · Patrick Roy
The loop in
test_create_guest_memfd_invalidthat is supposed to test that nothing is accepted as a valid flag toKVM_CREATE_GUEST_MEMFDwas initializingflagas 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... .Fixes 8a89efd43423 ("KVM: selftests: Add basic selftest for guest_memfd()")Signed-off-by Patrick Roy <[email protected]>--- tools/testing/selftests/kvm/guest_memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/kvm/guest_memfd_test.c +0
-0
tools/testing/selftests/kvm/guest_memfd_test.c static void test_create_guest_memfd_invalid(struct kvm_vm *vm) · line 140
Quoted 8 lines
tools/testing/selftests/kvm/guest_memfd_test.c +1
-1@@ -134,7 +134,7 @@ static void test_create_guest_memfd_invalid(struct kvm_vm *vm) size); } -for (flag =0 ; flag; flag <<=1 ) { +for (flag =BIT (0 ); flag; flag <<=1 ) { fd =__vm_create_guest_memfd (vm, page_size, flag); TEST_ASSERT(fd == -1 && errno == EINVAL, "guest_memfd() with flag '0x%lx' should fail with EINVAL",
Quoted 16 lines · Patrick Roy
The loop in
test_create_guest_memfd_invalidthat is supposed to test that nothing is accepted as a valid flag toKVM_CREATE_GUEST_MEMFDwas initializingflagas 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... .Fixes 8a89efd43423 ("KVM: selftests: Add basic selftest for guest_memfd()")Signed-off-by Patrick Roy <[email protected]>--- tools/testing/selftests/kvm/guest_memfd_test.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)tools/testing/selftests/kvm/guest_memfd_test.c +0
-0
tools/testing/selftests/kvm/guest_memfd_test.c static void test_create_guest_memfd_invalid(struct kvm_vm *vm) · line 140
Quoted 8 lines
tools/testing/selftests/kvm/guest_memfd_test.c +1
-1@@ -134,7 +134,7 @@ static void test_create_guest_memfd_invalid(struct kvm_vm *vm) size); } -for (flag =0 ; flag; flag <<=1 ) { +for (flag =BIT (0 ); flag; flag <<=1 ) { fd =__vm_create_guest_memfd (vm, page_size, flag); TEST_ASSERT(fd == -1 && errno == EINVAL, "guest_memfd() with flag '0x%lx' should fail with EINVAL",
Signature · 2 lines
BR, Muhammad Usama Anjum
Quoted 4 lines · Patrick Roy
The loop in
test_create_guest_memfd_invalidthat is supposed to test that nothing is accepted as a valid flag toKVM_CREATE_GUEST_MEMFDwas initializingflagas 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... .
Applied to kvm-x86 fixes, thanks!
[1/1] kvm: selftest: fix noop test in guest_memfd_test.c
https://github.com/kvm-x86/linux/commit/fd5b88cc7fbf
Sean Christopherson
reviewerQuoted 10 lines · Sean Christopherson
Quoted 4 lines · Patrick Roy
The loop in
test_create_guest_memfd_invalidthat is supposed to test that nothing is accepted as a valid flag toKVM_CREATE_GUEST_MEMFDwas initializingflagas 0 instead of BIT(0). This caused the loop to immediately exit instead of iterating over BIT(0), BIT(1), ... .Applied to kvm-x86 fixes, thanks!
[1/1] kvm: selftest: fix noop test in
guest_memfd_test.chttps://github.com/kvm-x86/linux/commit/fd5b88cc7fbf
FYI, I rebased "fixes" onto 6.12-rc5 to avoid several pointless conflicts in other patches. New hash:
[1/1] KVM: selftests: fix unintentional noop test in guest_memfd_test.c
https://github.com/kvm-x86/linux/commit/945bdae20be5