Skip to contentSkip to conversation

Patch "btrfs: also add stripe entries for NOCOW writes" has been added to the 6.11-stable tree

DISCUSSION Johannes Thumshirn 2 participants 2 messages Oct 24, 2024 – Oct 28, 2024 1 message not in the archive Stable branch

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw
Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

btrfs: also add stripe entries for NOCOW writes

to the 6.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
btrfs-also-add-stripe-entries-for-nocow-writes.patch
and it can be found in the queue-6.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Hey Sasha,

this patch is for the RAID stripe-tree feature marked as experimental, so I don't think it's needed to be backported, as noone should use it (apart from testing).

Quoted 39 lines

commit ec508a5930024b40064d70cb3dbdf856760cdf5d

Author: Johannes Thumshirn <[email protected]>
Date:   Thu Sep 19 12:16:38 2024 +0200

btrfs: also add stripe entries for NOCOW writes

[ Upstream commit 97f9782276fc9cb0de37a5eecb82204e48a5a612 ]

NOCOW writes do not generate stripe_extent entries in the RAID stripe tree, as the RAID stripe-tree feature initially was designed with a zoned filesystem in mind and on a zoned filesystem, we do not allow NOCOW writes. But the RAID stripe-tree feature is independent from the zoned feature, so we must also do NOCOW writes for RAID stripe-tree filesystems.

fs/btrfs/inode.c +5 -0
index b1b6564ab68f0..48149c2e68954 100644
@@ -3087,6 +3087,11 @@ int btrfs_finish_one_ordered(struct btrfs_ordered_extent *ordered_extent)
  		ret = btrfs_update_inode_fallback(trans, inode);
  		if (ret) /* -ENOMEM or corruption */
  			btrfs_abort_transaction(trans, ret);
+
+		ret = btrfs_insert_raid_extent(trans, ordered_extent);
+		if (ret)
+			btrfs_abort_transaction(trans, ret);
+
  		goto out;
  	}
 
#2 lore raw
Quoted 16 lines · Johannes Thumshirn
Quoted 7 lines · Sasha Levin

This is a note to let you know that I've just added the patch titled

btrfs: also add stripe entries for NOCOW writes

to the 6.11-stable tree which can be found at:
http://www.kernel.org/git/?p=linux/kernel/git/stable/stable-queue.git;a=summary

Quoted 6 lines

The filename of the patch is:
btrfs-also-add-stripe-entries-for-nocow-writes.patch
and it can be found in the queue-6.11 subdirectory.

If you, or anyone else, feels it should not be added to the stable tree, please let <[email protected]> know about it.

Quoted 5 lines

Hey Sasha,

this patch is for the RAID stripe-tree feature marked as experimental, so I don't think it's needed to be backported, as noone should use it (apart from testing).

Now dropped, thanks.

greg k-h