media: dt-bindings: adv7180: Document 'adi,force-bt656-4'
Subsystems (4)
Fabio Estevam
reviewerPATCH v2 1/3 media: dt-bindings: adv7180: Document 'adi,force-bt656-4'
From: Fabio Estevam <[email protected]>
The "adv,force-bt656-4" property causes several dt-schema warnings because 'adv' is not a valid vendor prefix defined in vendor-prefixes.yaml:
'adv,force-bt656-4' does not match any of the regexes: '^#.*'...
The correct vendor prefix for Analog Devices is 'adi', so change the property name to 'adi,force-bt656-4'.
Keep the old property for old DTB compatibility and mark it as deprecated.
---
Changes since v1:
- Changed compatible string -> property in the commit log. (Krzysztof)
- Fixed checkpatch warning due to the commit log being wider than 75 chars.
- Collected Krzysztof' Reviewed-by tag.
Documentation/devicetree/bindings/media/i2c/adv7180.yaml | 6 ++++++ 1 file changed, 6 insertions(+)
Documentation/devicetree/bindings/media/i2c/adv7180.yaml +6 -0
@@ -39,6 +39,12 @@ properties: maxItems: 1 adv,force-bt656-4: + deprecated: true + description: + Indicates that the output is a BT.656-4 compatible stream. + type: boolean + + adi,force-bt656-4: description: Indicates that the output is a BT.656-4 compatible stream. type: boolean
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH v2 2/3 media: adv7180: Also check for "adi,force-bt656-4"
From: Fabio Estevam <[email protected]>
According to adv7180.yaml, the correct property name is "adi,force-bt656-4".
Expand the check to also test against the "adi,force-bt656-4" compatible string.
---
Changes since v1:
- Collected Krzysztof' Reviewed-by tag.
drivers/media/i2c/adv7180.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/media/i2c/adv7180.c +2 -1
@@ -1440,7 +1440,8 @@ static int adv7180_probe(struct i2c_client *client)return ret; } -if (of_property_read_bool (np,"adv,force-bt656-4" )) +if (of_property_read_bool (np,"adv,force-bt656-4" ) || +of_property_read_bool (np,"adi,force-bt656-4" )) state->force_bt656_4 = true;if (state->chip_info->flags &ADV7180_FLAG_MIPI_CSI2 ) {
Signature · 1 line
2.34.1
Fabio Estevam
reviewerPATCH v2 3/3 ARM: dts: imx6qdl-apalis: Change to "adi,force-bt656-4"
In reply to Fabio EstevamFrom: Fabio Estevam <[email protected]>
According to adv7180.yaml, the correct property name is "adi,force-bt656-4".
Update it accordingly to fix several dt-schema warnings:
adv7280@21: 'adv,force-bt656-4' does not match any of the regexes: ...
imx6qdl-apalis.dtsi is the only in-tree kernel user of this property.
BSD does have a adv7180 driver, so should not be impacted.
---
Changes since v1:
- Explained that BSD is not impacted. (Krzysztof)
- Collected Krzysztof' Reviewed-by tag.
arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/boot/dts/nxp/imx/imx6qdl-apalis.dtsi +1 -1
@@ -691,7 +691,7 @@ &i2c3 { adv_7280: adv7280@21 { compatible = "adi,adv7280"; - adv,force-bt656-4; + adi,force-bt656-4; pinctrl-names = "default"; pinctrl-0 = <&pinctrl_ipu1_csi0>; reg = <0x21>;
Signature · 1 line
2.34.1