selftests/bpf: remove xdp_synproxy IP_DF check
Subsystems (4)
PATCH 1/1 selftests/bpf: remove xdp_synproxy IP_DF check
In real world production websites, the IP_DF flag is not always set for each packet from these websites. the IP_DF flag check breaks Internet connection to these websites for home based firewall like BPFire when XDP synproxy program is attached to firewall Internet facing side interface. see [0]
[0] https://github.com/vincentmli/BPFire/issues/59
--- tools/testing/selftests/bpf/progs/xdp_synproxy_kern.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
tools/testing/selftests/bpf/progs/xdp_synproxy_kern.c +1 -2
@@ -21,7 +21,6 @@#define tcp_flag_word (tp) (((union tcp_word_hdr *)(tp))->words[3]) -#define IP_DF 0x4000#define IP_MF 0x2000#define IP_OFFSET 0x1fff
@@ -442,7 +441,7 @@ static __always_inline int tcp_lookup(void *ctx, struct header_pointers *hdr, bo/* TCP doesn't normally use fragments, and XDP can't reassemble * them. */ -if ((hdr->ipv4->frag_off &bpf_htons (IP_DF |IP_MF |IP_OFFSET )) !=bpf_htons (IP_DF )) +if ((hdr->ipv4->frag_off &bpf_htons (IP_MF |IP_OFFSET )) !=0 )return XDP_DROP ; tup.ipv4.saddr = hdr->ipv4->saddr;
Signature · 1 line
2.34.1
This patch was applied to bpf/bpf-next.git (net) by Martin KaFai Lau <[email protected]>:
Hello:
This patch was applied to bpf/bpf-next.git (net)
by Martin KaFai Lau <[email protected]>:
Quoted 8 lines · On Fri, 25 Oct 2024 03:19:52 +0000 you wrote:
In real world production websites, the
IP_DFflag is not always set for each packet from these websites. theIP_DFflag check breaks Internet connection to these websites for home based firewall like BPFire when XDP synproxy program is attached to firewall Internet facing side interface. see [0][...]
Here is the summary with links:
- selftests/bpf: remove xdp_synproxy IP_DF check
https://git.kernel.org/bpf/bpf-next/c/0ab7cd1f1864
You are awesome, thank you!
Signature · 2 lines
Deet-doot-dot, I am a bot. https://korg.docs.kernel.org/patchwork/pwbot.html