Skip to contentSkip to conversation

udevng: restore support for phonet modems

PATCH Applied Sicelo A. Mhlongo 2 participants 2 messages Oct 26, 2024 – Oct 28, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 udevng: restore support for phonet modems

Commit 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") introduced a constraint that only rmnet_* modems are valid "net" subsystem devices, thus breaking phonet modems, which are located in that subsystem as well.

    P: /devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
    E: DEVPATH=/devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
    E: INTERFACE=phonet0
    E: OFONO_DRIVER=n900
    E: OFONO_ISI_ADDRESS=108
    E: SUBSYSTEM=net

Fix the regression by specifically checking for phonet inside check_net_device().

Fixes 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems")
---
 plugins/udevng.c | 4 ++++
 1 file changed, 4 insertions(+)
plugins/udevng.c +4 -0
index f4266f39..f34cdcb7 100644
@@ -2455,6 +2455,10 @@ static void check_net_device(struct udev_device *device)
 	}
 
 	name = udev_device_get_sysname(device);
+	if (l_str_has_prefix(name, "phonet")) {
+		add_serial_device(device);
+		return;
+	}
 	if (!l_str_has_prefix(name, "rmnet_"))
 		return;
 
Signature · 1 line
2.45.2
#1 lore raw
This patch was applied to ofono.git (master) by Denis Kenzior <[email protected]>:

Hello:

This patch was applied to ofono.git (master)
by Denis Kenzior <[email protected]>:

Quoted 4 lines · On Sat, 26 Oct 2024 13:53:11 +0200 you wrote:

Commit 296347f8a4f1 ("udevng: Detect embedded qmi QRTR modems") introduced a constraint that only rmnet_* modems are valid "net" subsystem devices, thus breaking phonet modems, which are located in that subsystem as well.

Quoted 8 lines
    P: /devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
    E: DEVPATH=/devices/platform/68000000.ocp/48058000.ssi-controller/ssi0/port0/ssi-protocol/net/phonet0
    E: INTERFACE=phonet0
    E: OFONO_DRIVER=n900
    E: OFONO_ISI_ADDRESS=108
    E: SUBSYSTEM=net

[...]

Here is the summary with links:
- udevng: restore support for phonet modems

    https://git.kernel.org/pub/scm/network/ofono/ofono.git/?id=116b6dfef7a7

You are awesome, thank you!

Signature · 2 lines
Deet-doot-dot, I am a bot.
https://korg.docs.kernel.org/patchwork/pwbot.html