Skip to contentSkip to conversation

riscv: dts: sophgo: fix pinctrl base-address

PATCH Applied Thomas Bonnefille 3 participants 8 messages Oct 28, 2024 – Nov 2, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 riscv: dts: sophgo: fix pinctrl base-address

Fix the base-address of the pinctrl controller to match its register address.

---
 arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/sophgo/sg2002.dtsi +1 -1
index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
@@ -16,7 +16,7 @@ memory@80000000 {
 	};
 
 	soc {
-		pinctrl: pinctrl@3008000 {
+		pinctrl: pinctrl@3001000 {
 			compatible = "sophgo,sg2002-pinctrl";
 			reg = <0x03001000 0x1000>,
 			      <0x05027000 0x1000>;

---
base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c

Best regards,

Signature · 1 line
Thomas Bonnefille <[email protected]>
#1 lore raw

Hello~, Thomas

This problem is introduced by this patchset [1], which is still on the sophgo/for-next branch and has not been submitted to the main line. So I think the right thing to do is to submit another version v6 with your bugfix.

Thanks,

Chen

Quoted 27 lines · Thomas Bonnefille

Fix the base-address of the pinctrl controller to match its register address.

---
  arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/sophgo/sg2002.dtsi +1 -2
index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
@@ -16,7 +16,7 @@ memory@80000000 {
  	};
 
  	soc {
-		pinctrl: pinctrl@3008000 {
+		pinctrl: pinctrl@3001000 {
  			compatible = "sophgo,sg2002-pinctrl";
  			reg = <0x03001000 0x1000>,
  			      <0x05027000 0x1000>;
 
---

base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c

Best regards,

maintainer
#2 lore raw
Quoted 7 lines · Chen Wang

Hello~, Thomas

This problem is introduced by this patchset [1], which is still on the sophgo/for-next branch and has not been submitted to the main line. So I think the right thing to do is to submit another version v6 with your bugfix.

It is OK to let this patch go. If we want to keep the patch persisent, it is better to apply a fix than revoke the fault one and apply a new version.

Regards,
Inochi

maintainer Reviewed-by on v1 1/1
#3 lore raw
In reply to Thomas Bonnefille
Quoted 26 lines · Thomas Bonnefille

Fix the base-address of the pinctrl controller to match its register address.

---
 arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/sophgo/sg2002.dtsi +1 -2
index 242fde84443f0d6a2c8476666dfa3d72727071b1..6616f578d190f7aa2a82b233fa9c55267b41ee0e 100644
@@ -16,7 +16,7 @@ memory@80000000 {
 	};
 
 	soc {
-		pinctrl: pinctrl@3008000 {
+		pinctrl: pinctrl@3001000 {
 			compatible = "sophgo,sg2002-pinctrl";
 			reg = <0x03001000 0x1000>,
 			      <0x05027000 0x1000>;
 
---

base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c

Quoted 4 lines

Best regards,

Signature · 1 line
Thomas Bonnefille <[email protected]>
#5 lore raw

Hi, Inochi,

Will you pick this on sophgo/for-next?

Regards,

Chen

Quoted 7 lines · Inochi Amaoto
Quoted 4 lines · Thomas Bonnefille

Fix the base-address of the pinctrl controller to match its register address.

Fixes 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")
maintainer
#6 lore raw
Quoted 16 lines · Chen Wang

Hi, Inochi,

Will you pick this on sophgo/for-next?

Regards,

Chen

Quoted 7 lines · Inochi Amaoto
Quoted 4 lines · Thomas Bonnefille

Fix the base-address of the pinctrl controller to match its register address.

Fixes 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")

Yeah, I have quened this patch and will merge it once I have space time, so please wait.

Regards,
Inochi