riscv: dts: sophgo: fix pinctrl base-address
Subsystems (3)
PATCH 1/1 riscv: dts: sophgo: fix pinctrl base-address
Fix the base-address of the pinctrl controller to match its register address.
--- arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/sophgo/sg2002.dtsi +1 -1
@@ -16,7 +16,7 @@ memory@80000000 { }; soc { - pinctrl: pinctrl@3008000 { + pinctrl: pinctrl@3001000 { compatible = "sophgo,sg2002-pinctrl"; reg = <0x03001000 0x1000>, <0x05027000 0x1000>;
---
base-commit: 45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c
Best regards,
Signature · 1 line
Thomas Bonnefille <[email protected]>
Hello~, Thomas
This problem is introduced by this patchset [1], which is still on the sophgo/for-next branch and has not been submitted to the main line. So I think the right thing to do is to submit another version v6 with your bugfix.
Thanks,
Chen
Quoted 27 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Signed-off-by Thomas Bonnefille <[email protected]>--- arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/boot/dts/sophgo/sg2002.dtsi +1
-2@@ -16,7 +16,7 @@ memory@80000000 { }; soc { - pinctrl: pinctrl@3008000 { + pinctrl: pinctrl@3001000 { compatible = "sophgo,sg2002-pinctrl"; reg = <0x03001000 0x1000>, <0x05027000 0x1000>; ---base-commit:
45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2cBest regards,
Inochi Amaoto
maintainerQuoted 7 lines · Chen Wang
Hello~, Thomas
This problem is introduced by this patchset [1], which is still on the sophgo/for-next branch and has not been submitted to the main line. So I think the right thing to do is to submit another version v6 with your bugfix.
It is OK to let this patch go. If we want to keep the patch persisent, it is better to apply a fix than revoke the fault one and apply a new version.
Regards,
Inochi
Quoted 26 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Signed-off-by Thomas Bonnefille <[email protected]>--- arch/riscv/boot/dts/sophgo/sg2002.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)arch/riscv/boot/dts/sophgo/sg2002.dtsi +1
-2@@ -16,7 +16,7 @@ memory@80000000 { }; soc { - pinctrl: pinctrl@3008000 { + pinctrl: pinctrl@3001000 { compatible = "sophgo,sg2002-pinctrl"; reg = <0x03001000 0x1000>, <0x05027000 0x1000>; ---base-commit:
45a544a62ef7cac9ecc69585a90da72ca68af898
change-id: 20241028-fix-address-e7f0c40eac2c
Quoted 4 lines
Best regards,
Signature · 1 line
Thomas Bonnefille <[email protected]>
Inochi Amaoto
maintainerQuoted 4 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Signed-off-by Thomas Bonnefille <[email protected]>
Hi, Inochi,
Will you pick this on sophgo/for-next?
Regards,
Chen
Quoted 7 lines · Inochi Amaoto
Quoted 4 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Signed-off-by Thomas Bonnefille <[email protected]>Fixes 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")
Inochi Amaoto
maintainerQuoted 16 lines · Chen Wang
Hi, Inochi,
Will you pick this on sophgo/for-next?
Regards,
Chen
Quoted 7 lines · Inochi Amaoto
Quoted 4 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Signed-off-by Thomas Bonnefille <[email protected]>Fixes 93b61555f509 ("riscv: dts: sophgo: Add initial SG2002 SoC device tree")
Yeah, I have quened this patch and will merge it once I have space time, so please wait.
Regards,
Inochi
Quoted 4 lines · Thomas Bonnefille
Fix the base-address of the pinctrl controller to match its register address.
Applied to for-next, thanks!
[1/1] riscv: dts: sophgo: fix pinctrl base-address
https://github.com/sophgo/linux/commit/44196383a26fcacbd6dcf5a1ab2dd8bf8e4132c0
Thanks,
Inochi