Skip to contentSkip to conversation

drm/i915/display: Add Wa_16023981245

PATCH New Nemesa Garg 2 participants 3 messages Oct 28, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drm/i915/display: Add Wa_16023981245

Disable the support for odd panning in x direction.

v2: Replace HSD with WA in commit message [Suraj]
Modified the condition for handling odd panning

v3: Simplified the condition for checking hsub
Using older framework for wa as rev1[Jani]

v4: Modify the condition for hsub [Sai Teja]
Initialize hsub in else path [Dan]

v5: Replace IS_LUNARLAKE with display version.
Resolve nitpicks[Jani]

v6: Replace -EINVAL with hsub [Suraj]
Remove src_w check as not required

v7: Remove check for NV12.
Add check for PTL as well [Matt]

v8: Alignment fix

Continuing discussions from:
https://patchwork.freedesktop.org/series/136416/

---
 drivers/gpu/drm/i915/display/intel_atomic_plane.c | 6 ++++++
 1 file changed, 6 insertions(+)
drivers/gpu/drm/i915/display/intel_atomic_plane.c +6 -0
index b7e462075ded..73fe36f00dae 100644
@@ -1024,6 +1024,12 @@ int intel_plane_check_src_coordinates(struct intel_plane_state *plane_state)
 		 */
 		hsub = 1;
 		vsub = 1;
+
+		/* Wa_16023981245 */
+		if ((DISPLAY_VER_FULL(i915) == IP_VER(20, 0) ||
+		     DISPLAY_VER_FULL(i915) == IP_VER(30, 0)) &&
+		     src_x % 2 != 0)
+			hsub = 2;
 	} else {
 		hsub = fb->format->hsub;
 		vsub = fb->format->vsub;
Signature · 1 line
2.25.1
#1 lore raw

✗ CI.Patch_applied: failure for drm/i915/display: Add Wa_16023981245 (rev2)

== Series Details ==

== Series Details ==

Series: drm/i915/display: Add Wa_16023981245 (rev2)
URL : https://patchwork.freedesktop.org/series/140326/
State : failure

== Summary ==

=== Applying kernel patches on branch 'drm-tip' with base: ===
Base commit: 95642dd70135 drm-tip: 2024y-10m-28d-04h-51m-10s UTC integration manifest === git am output follows ===
error: patch failed: drivers/gpu/drm/i915/display/intel_atomic_plane.c:1024
error: drivers/gpu/drm/i915/display/intel_atomic_plane.c: patch does not apply
hint: Use 'git am --show-current-patch=diff' to see the failed patch
Applying: drm/i915/display: Add Wa_16023981245
Patch failed at 0001 drm/i915/display: Add Wa_16023981245
When you have resolved this problem, run "git am --continue".
If you prefer to skip this patch, run "git am --skip" instead.
To restore the original branch and stop patching, run "git am --abort".