Skip to contentSkip to conversation

media: mceusb: don't push static constants on stack for %*ph

PATCH New Sean Young 1 participant 2 messages Oct 28, 2024

Subsystems (3)
lore
Share & tools
lore

Sean Young

author maintainer
#0 lore raw

PATCH 1/2 media: mceusb: don't push static constants on stack for %*ph

There is no need to pass constants via stack. The width may be explicitly specified in the format.

---
 drivers/media/rc/mceusb.c | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/media/rc/mceusb.c +2 -2
index cd7af4d88b7f7..d5ea3868d5a3c 100644
@@ -658,8 +658,8 @@ static void mceusb_dev_printdata(struct mceusb_dev *ir, u8 *buf, int buf_len,
 			if (len == 2)
 				dev_dbg(dev, "Get hw/sw rev?");
 			else
-				dev_dbg(dev, "hw/sw rev %*ph",
-					4, &buf[offset + 2]);
+				dev_dbg(dev, "hw/sw rev %4ph",
+					&buf[offset + 2]);
 			break;
 		case MCE_CMD_RESUME:
 			dev_dbg(dev, "Device resume requested");
Signature · 1 line
2.47.0
author maintainer
#1 lore raw

PATCH 2/2 media: imon: don't push static constants on stack for %*ph

There is no need to pass constants via stack. The width may be explicitly specified in the format.

---
 drivers/media/rc/imon_raw.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/media/rc/imon_raw.c +1 -1
index b02ded52f19e6..3a526dea6532c 100644
@@ -37,7 +37,7 @@ static void imon_ir_data(struct imon *imon)
 	if (packet_no == 0xff)
 		return;
 
-	dev_dbg(imon->dev, "data: %*ph", 8, imon->ir_buf);
+	dev_dbg(imon->dev, "data: %8ph", imon->ir_buf);
 
 	/*
 	 * Only the first 5 bytes contain IR data. Right shift so we move
Signature · 1 line
2.47.0