Skip to contentSkip to conversation

drivers: iio: adc: ad777x depends on CRC8

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 28, 2024 IIO

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 drivers: iio: adc: ad777x depends on CRC8

From: Arnd Bergmann <[email protected]>

The newly added driver fails to link when CONFIG_CRC8 is not set:

ld.lld-20: error: undefined symbol: crc8_populate_msb ld.lld-20: error: undefined symbol: crc8

Quoted 1 line
Quoted 1 line
Quoted 1 line
              vmlinux.o:(ad7779_spi_read)

Select this from Kconfig as we do for other drivers like it.

Fixes cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
index d8abe28eec89..849c90203071 100644
@@ -290,6 +290,7 @@ config AD7768_1
 config AD7779
 	tristate "Analog Devices AD7779 ADC driver"
 	depends on SPI
+	select CRC8
 	select IIO_BUFFER
 	help
 	  Say yes here to build support for Analog Devices AD777X family
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 4 lines · On Mon, 28 Oct 2024 16:29:15 +0000 Arnd Bergmann <[email protected]> wrote:

From: Arnd Bergmann <[email protected]>

The newly added driver fails to link when CONFIG_CRC8 is not set:

Quoted 8 lines

ld.lld-20: error: undefined symbol: crc8_populate_msb ld.lld-20: error: undefined symbol: crc8

Quoted 1 line
Quoted 1 line
Quoted 1 line
              vmlinux.o:(ad7779_spi_read)  

Select this from Kconfig as we do for other drivers like it.

Fixes cc20fa9e9ad4 ("drivers: iio: adc: add support for ad777x family")

Squashed into original patch.

Thanks!

Jonathan

Quoted 16 lines
---
 drivers/iio/adc/Kconfig | 1 +
 1 file changed, 1 insertion(+)
drivers/iio/adc/Kconfig +1 -0
index d8abe28eec89..849c90203071 100644
@@ -290,6 +290,7 @@ config AD7768_1
 config AD7779
 	tristate "Analog Devices AD7779 ADC driver"
 	depends on SPI
+	select CRC8
 	select IIO_BUFFER
 	help
 	  Say yes here to build support for Analog Devices AD777X family