Skip to contentSkip to conversation

drm/imx/dcss: include drm/drm_bridge.h header

PATCH In review Arnd Bergmann 4 participants 4 messages Oct 28, 2024 – Nov 4, 2024

Subsystems (4)
DRM drivers DRM misc Arm i.MX and Layerscape NXP i.MX 8MQ dcss driver
lore
Share & tools
lore

Arnd Bergmann

author
#0 lore raw

PATCH 1/1 drm/imx/dcss: include drm/drm_bridge.h header

From: Arnd Bergmann <[email protected]>

Compile-testing random configurations leads to failures in dcss-kms.c from a missing declaration:

drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
95 | ret = drm_bridge_attach(encoder, bridge, NULL,
| ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'

   96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
      |                                 ^

Include the header directly.

Fixes 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by Arnd Bergmann <[email protected]>
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/dcss/dcss-kms.c +1 -0
index 3ec721afc30c..63a335c62296 100644
@@ -5,6 +5,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_client_setup.h>
 #include <drm/drm_drv.h>
Signature · 1 line
2.39.5
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Arnd,

Quoted 9 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Compile-testing random configurations leads to failures in dcss-kms.c from a missing declaration:

drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
95 | ret = drm_bridge_attach(encoder, bridge, NULL,
| ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'

Quoted 7 lines
   96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
      |                                 ^

Include the header directly.

Fixes 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by Arnd Bergmann <[email protected]>
Reviewed-by Laurentiu Palcu <[email protected]>

Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or Ville, can you help push this?

Thanks,
Laurentiu

Quoted 19 lines
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/dcss/dcss-kms.c +1 -0
index 3ec721afc30c..63a335c62296 100644
@@ -5,6 +5,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_client_setup.h>
 #include <drm/drm_drv.h>
Signature · 1 line
2.39.5
Reviewed-by
#2 lore raw
Quoted 15 lines · Laurentiu Palcu

Hi Arnd,

Quoted 12 lines · Arnd Bergmann

From: Arnd Bergmann <[email protected]>

Compile-testing random configurations leads to failures in dcss-kms.c from a missing declaration:

drivers/gpu/drm/imx/dcss/dcss-kms.c:95:8: error: use of undeclared identifier 'drm_bridge_attach'
95 | ret = drm_bridge_attach(encoder, bridge, NULL,
| ^
drivers/gpu/drm/imx/dcss/dcss-kms.c:96:5: error: use of undeclared identifier 'DRM_BRIDGE_ATTACH_NO_CONNECTOR'

   96 |                                 DRM_BRIDGE_ATTACH_NO_CONNECTOR);
      |                                 ^
Quoted 8 lines
Quoted 4 lines

Include the header directly.

Fixes 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")
Signed-off-by Arnd Bergmann <[email protected]>
Reviewed-by Laurentiu Palcu <[email protected]>

Unfortunately, it appears I lost drm-misc push rights. Maxime, Thomas or Ville, can you help push this?

I can pick it up.

However I think it is:

Fixes e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")

With that

Reviewed-by Dmitry Baryshkov <[email protected]>
Quoted 23 lines

Thanks,
Laurentiu

Quoted 19 lines
---
 drivers/gpu/drm/imx/dcss/dcss-kms.c | 1 +
 1 file changed, 1 insertion(+)
drivers/gpu/drm/imx/dcss/dcss-kms.c +1 -0
index 3ec721afc30c..63a335c62296 100644
@@ -5,6 +5,7 @@
 
 #include <drm/drm_atomic.h>
 #include <drm/drm_atomic_helper.h>
+#include <drm/drm_bridge.h>
 #include <drm/drm_bridge_connector.h>
 #include <drm/drm_client_setup.h>
 #include <drm/drm_drv.h>
Signature · 1 line
2.39.5
Signature · 2 lines
With best wishes
Dmitry
#3 lore raw
Quoted 9 lines · Dmitry Baryshkov
Quoted 3 lines · Laurentiu Palcu
Quoted 1 line · Arnd Bergmann
Fixes 004555a18d57 ("drm/imx/dcss: Allow build with COMPILE_TEST=y")

I can pick it up.

However I think it is:

Fixes e7033bdfd43b ("drm/imx/dcss: use drm_bridge_connector API")

It's probably both commits. My randconfig builds showed it only failing on x86, which means that it was still working by accident on all builds that include ARCH_MXC && ARM64, between the two commits. The commit you pointed out should have added the #include, but that seems to come indirectly from include/drm/drm_of on all arm64 builds.

Quoted 3 lines

With that

Reviewed-by Dmitry Baryshkov <[email protected]>

Thanks,

Arnd