Skip to contentSkip to conversation

ASoC: cs42l84: remove incorrect of_match_ptr()

PATCH In review Arnd Bergmann 2 participants 2 messages Oct 29, 2024

Subsystems (4)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: cs42l84: remove incorrect of_match_ptr()

From: Arnd Bergmann <[email protected]>

The use of of_match_ptr() is incorrect here and just causes a warning:

sound/soc/codecs/cs42l84.c:1084:34: error: unused variable 'cs42l84_of_match' [-Werror,-Wunused-const-variable]

Fixes 250304a0fb34 ("ASoC: cs42l84: Add new codec driver")
---
 sound/soc/codecs/cs42l84.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
sound/soc/codecs/cs42l84.c +1 -1
index 47731cdc0e67..d176add8c4a6 100644
@@ -1096,7 +1096,7 @@ MODULE_DEVICE_TABLE(i2c, cs42l84_id);
 static struct i2c_driver cs42l84_i2c_driver = {
 	.driver = {
 		.name = "cs42l84",
-		.of_match_table = of_match_ptr(cs42l84_of_match),
+		.of_match_table = cs42l84_of_match,
 	},
 	.id_table = cs42l84_id,
 	.probe = cs42l84_i2c_probe,
Signature · 1 line
2.39.5
maintainer
#1 lore raw
Quoted 6 lines · Arnd Bergmann

The use of of_match_ptr() is incorrect here and just causes a warning:

sound/soc/codecs/cs42l84.c:1084:34: error: unused variable 'cs42l84_of_match' [-Werror,-Wunused-const-variable]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: cs42l84: remove incorrect of_match_ptr()

      commit: 0d4f74febc9d92d88099aff01f121b7f5f942c8f

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark