Skip to contentSkip to conversation

llistxattr03: Convert docs to docparse

PATCH In review Ma Xinjian via ltp 2 participants 3 messages Oct 31, 2024 – Nov 12, 2024

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 llistxattr03: Convert docs to docparse

---
 .../kernel/syscalls/llistxattr/llistxattr03.c | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)
testcases/kernel/syscalls/llistxattr/llistxattr03.c +11 -12
index 940851f40..3280e91aa 100644
@@ -1,17 +1,16 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
-* Copyright (c) 2016 Fujitsu Ltd.
-* Author: Xiao Yang <[email protected]>
-*/
-
-/*
-* Test Name: llistxattr03
-*
-* Description:
-* llistxattr is identical to listxattr. an empty buffer of size zero
-* can return the current size of the list of extended attribute names,
-* which can be used to estimate a suitable buffer.
-*/
+ * Copyright (c) 2016 Fujitsu Ltd.
+ * Author: Xiao Yang <[email protected]>
+ */
+
+/*\
+ * [Description]
+ *
+ * llistxattr is identical to listxattr. An empty buffer of size zero
+ * can return the current size of the list of extended attribute names,
+ * which can be used to estimate a suitable buffer.
+ */
 
 #include "config.h"
 #include <errno.h>
Signature · 5 lines
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
author Reviewed-by Wei Gao on v1 1/1
#1 lore raw
Quoted 25 lines · Ma Xinjian via ltp
---
 .../kernel/syscalls/llistxattr/llistxattr03.c | 23 +++++++++----------
 1 file changed, 11 insertions(+), 12 deletions(-)
testcases/kernel/syscalls/llistxattr/llistxattr03.c +1 -12
index 940851f40..3280e91aa 100644
@@ -1,17 +1,16 @@
 // SPDX-License-Identifier: GPL-2.0-or-later
 /*
-* Copyright (c) 2016 Fujitsu Ltd.
-* Author: Xiao Yang <[email protected]>
-*/
-
-/*
-* Test Name: llistxattr03
-*
-* Description:
-* llistxattr is identical to listxattr. an empty buffer of size zero
-* can return the current size of the list of extended attribute names,
-* which can be used to estimate a suitable buffer.
-*/
+ * Copyright (c) 2016 Fujitsu Ltd.

testcases/kernel/syscalls/llistxattr/llistxattr03.c line 13

Quoted 10 lines
testcases/kernel/syscalls/llistxattr/llistxattr03.c +10 -0
+ * Author: Xiao Yang <[email protected]>
+ */
+
+/*\
+ * [Description]
+ *
+ * llistxattr is identical to listxattr. An empty buffer of size zero
+ * can return the current size of the list of extended attribute names,
+ * which can be used to estimate a suitable buffer.
+ */
Quoted 9 lines
testcases/kernel/syscalls/llistxattr/llistxattr03.c +0 -0
 #include "config.h"
 #include <errno.h>
Signature · 5 lines
2.42.0


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp
Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp
#2 lore raw

Hi all,

...

Quoted 8 lines
Quoted 8 lines
testcases/kernel/syscalls/llistxattr/llistxattr03.c +3 -5
-* Description:
-* llistxattr is identical to listxattr. an empty buffer of size zero
-* can return the current size of the list of extended attribute names,
-* which can be used to estimate a suitable buffer.
-*/
+ * Copyright (c) 2016 Fujitsu Ltd.
+ * Author: Xiao Yang <[email protected]>
+ */
Quoted 8 lines

testcases/kernel/syscalls/llistxattr/llistxattr03.c line 13

Quoted 8 lines
testcases/kernel/syscalls/llistxattr/llistxattr03.c +8 -0
+
+/*\
+ * [Description]
+ *
+ * llistxattr is identical to listxattr. An empty buffer of size zero
+ * can return the current size of the list of extended attribute names,
+ * which can be used to estimate a suitable buffer.
+ */

IMHO the best description was in v1 of the test:

https://lore.kernel.org/ltp/[email protected]/

llistxattr(2) with an empty buffer of size zero can return the current size of the list of extended attribute names.

What was then in v3 committed is slightly misleading.

"llistxattr is identical to listxattr" is from man page, but it's IMHO irrelevant. Also first "can" is wrong (it should always work, not just sometimes).

I dared to rewrite before merge:

* Verify that llistxattr(2) call with zero size returns the current size of the
* list of extended attribute names, which can be used to determine the size of
* the buffer that should be supplied in a subsequent llistxattr(2) call.

Thanks!

Kind regards,
Petr

Signature · 1 line
Mailing list info: https://lists.linux.it/listinfo/ltp