KVM: SVM: Propagate error from snp_guest_req_init() to userspace
Sean Christopherson
maintainerPATCH 1/1 KVM: SVM: Propagate error from snp_guest_req_init() to userspace
If snp_guest_req_init() fails, return the provided error code up the stack to userspace, e.g. so that userspace can log that KVM_SEV_INIT2 failed, as opposed to some random operation later in VM setup failing because SNP wasn't actually enabled for the VM.
Note, KVM itself doesn't consult the return value from __sev_guest_init(), i.e. the fallout is purely that userspace may be confused.
--- arch/x86/kvm/svm/sev.c | 7 +++++-- 1 file changed, 5 insertions(+), 2 deletions(-)
arch/x86/kvm/svm/sev.c +5 -2
@@ -450,8 +450,11 @@ static int __sev_guest_init(struct kvm *kvm, struct kvm_sev_cmd *argp, goto e_free;/* This needs to happen after SEV/SNP firmware initialization. */ -if (vm_type ==KVM_X86_SNP_VM &&snp_guest_req_init (kvm)) - goto e_free; +if (vm_type ==KVM_X86_SNP_VM ) { + ret =snp_guest_req_init (kvm); +if (ret) + goto e_free; + }INIT_LIST_HEAD (&sev->regions_list);INIT_LIST_HEAD (&sev->mirror_vms);
base-commit: e466901b947d529f7b091a3b00b19d2bdee206ee
Signature · 1 line
2.47.0.163.g1226f6d8fa-goog
Quoted 9 lines · Sean Christopherson
If
snp_guest_req_init()fails, return the provided error code up the stack to userspace, e.g. so that userspace can log thatKVM_SEV_INIT2failed, as opposed to some random operation later in VM setup failing because SNP wasn't actually enabled for the VM.Note, KVM itself doesn't consult the return value from
__sev_guest_init(), i.e. the fallout is purely that userspace may be confused.[...]
Applied to kvm-x86 fixes (yesterday, I forgot to send the thank you mail).
[1/1] KVM: SVM: Propagate error from snp_guest_req_init() to userspace
https://github.com/kvm-x86/linux/commit/e5d253c60e96