i3c: master: svc: Modify enabled_events bit 7:0 to act as IBI enable counter
Subsystems (3)
Frank Li
maintainerPATCH v2 1/1 i3c: master: svc: Modify enabled_events bit 7:0 to act as IBI enable counter
Fix issue where disabling IBI on one device disables the entire IBI interrupt. Modify bit 7:0 of enabled_events to serve as an IBI enable counter, ensuring that the system IBI interrupt is disabled only when all I3C devices have IBI disabled.
---
Change from v1 to v2
- rebase to i3c/next branch
- add Reviewed tag of Miquel Raynal
--- drivers/i3c/master/svc-i3c-master.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
drivers/i3c/master/svc-i3c-master.c +5 -5
@@ -130,8 +130,8 @@#define SVC_I3C_PPBAUD_MAX 15#define SVC_I3C_QUICK_I2C_CLK 4170000 -#define SVC_I3C_EVENT_IBI BIT(0) -#define SVC_I3C_EVENT_HOTJOIN BIT(1) +#define SVC_I3C_EVENT_IBI GENMASK(7, 0) +#define SVC_I3C_EVENT_HOTJOIN BIT(31)struct svc_i3c_cmd {u8 addr;
@@ -214,7 +214,7 @@ struct svc_i3c_master {spinlock_t lock; } ibi;struct mutex lock; -int enabled_events; +u32 enabled_events;u32 mctrl_config; };
@@ -1688,7 +1688,7 @@ static int svc_i3c_master_enable_ibi(struct i3c_dev_desc *dev)return ret; } - master->enabled_events |=SVC_I3C_EVENT_IBI ; + master->enabled_events++;svc_i3c_master_enable_interrupts (master,SVC_I3C_MINT_SLVSTART );return i3c_master_enec_locked (m, dev->info.dyn_addr,I3C_CCC_EVENT_SIR );
@@ -1700,7 +1700,7 @@ static int svc_i3c_master_disable_ibi(struct i3c_dev_desc *dev)struct svc_i3c_master *master =to_svc_i3c_master (m);int ret; - master->enabled_events &= ~SVC_I3C_EVENT_IBI ; + master->enabled_events--;if (!master->enabled_events)svc_i3c_master_disable_interrupts (master);
Signature · 1 line
2.34.1
Quoted 6 lines · Frank Li
Fix issue where disabling IBI on one device disables the entire IBI interrupt. Modify bit 7:0 of
enabled_eventsto serve as an IBI enable counter, ensuring that the system IBI interrupt is disabled only when all I3C devices have IBI disabled.
Applied, thanks!
[1/1] i3c: master: svc: Modify enabled_events bit 7:0 to act as IBI enable counter
https://git.kernel.org/abelloni/c/25bc99be5fe5
Best regards,
Signature · 3 lines
Alexandre Belloni, co-owner and COO, Bootlin Embedded Linux and Kernel engineering https://bootlin.com