arm: dts: aspeed: Everest and Fuji: Add VRM presence gpio expander
Subsystems (2)
PATCH 1/1 arm: dts: aspeed: Everest and Fuji: Add VRM presence gpio expander
Add the gpio expander that provides the VRM presence detection pins.
--- .../dts/aspeed/aspeed-bmc-ibm-everest.dts | 27 +++++++++++++++++++ .../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 27 +++++++++++++++++++ 2 files changed, 54 insertions(+)
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts +27 -0
@@ -353,6 +353,33 @@ pca1: pca9552@62 { "presence-base-op", ""; }; + + led-controller@63 { + compatible = "nxp,pca9552"; + reg = <0x63>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + + gpio-line-names = + "presence-vrm-c12", + "presence-vrm-c13", + "presence-vrm-c15", + "presence-vrm-c16", + "presence-vrm-c17", + "presence-vrm-c18", + "presence-vrm-c20", + "presence-vrm-c21", + "presence-vrm-c54", + "presence-vrm-c55", + "presence-vrm-c57", + "presence-vrm-c58", + "presence-vrm-c59", + "presence-vrm-c60", + "presence-vrm-c62", + "presence-vrm-c63"; + }; }; &i2c1 {
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts +27 -0
@@ -355,6 +355,33 @@ led-controller@62 { "presence-base-op", ""; }; + + led-controller@63 { + compatible = "nxp,pca9552"; + reg = <0x63>; + #address-cells = <1>; + #size-cells = <0>; + gpio-controller; + #gpio-cells = <2>; + + gpio-line-names = + "presence-vrm-c12", + "presence-vrm-c13", + "presence-vrm-c15", + "presence-vrm-c16", + "presence-vrm-c17", + "presence-vrm-c18", + "presence-vrm-c20", + "presence-vrm-c21", + "presence-vrm-c54", + "presence-vrm-c55", + "presence-vrm-c57", + "presence-vrm-c58", + "presence-vrm-c59", + "presence-vrm-c60", + "presence-vrm-c62", + "presence-vrm-c63"; + }; }; &i2c1 {
Signature · 1 line
2.43.5
Andrew Jeffery
maintainerQuoted 17 lines · Eddie James
Add the gpio expander that provides the VRM presence detection pins.
Signed-off-by Eddie James <[email protected]>---
.../dts/aspeed/aspeed-bmc-ibm-everest.dts | 27
+++++++++++++++++++
.../boot/dts/aspeed/aspeed-bmc-ibm-fuji.dts | 27
+++++++++++++++++++2 files changed, 54 insertions(+)arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts +0
-0
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts pca1: pca9552@62 { · line 358
Quoted 6 lines
arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dts +3
-0@@ -353,6 +353,33 @@ pca1: pca9552@62 { "presence-base-op", ""; }; + + led-controller@63 { + compatible = "nxp,pca9552";
So Lee has queued the binding for the pca9552 in the leds tree[1], and I've applied the patch on that basis.
However, when merging for-leds-next into a tree with your patch here to test, it surfaced a bunch of further (unrelated) issues:
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@65: 'led@10', 'led@11' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@31: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@32: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@33: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@30: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@34: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@35: 'led@10', 'led@11', 'led@12', 'led@13', 'led@14', 'led@15' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
+/home/andrew/src/kernel.org/linux/origin/build.aspeed_g5/arch/arm/boot/dts/aspeed/aspeed-bmc-ibm-everest.dtb: pca9552@60: 'led@10', 'led@11', 'led@12', 'led@13' do not match any of the regexes: '^led@[0-9a-f]$', 'pinctrl-[0-9]+'
+ from schema $id: http://devicetree.org/schemas/leds/nxp,pca955x.yaml#
Can you please send a follow-up patch resolving those and any similar warnings for Fuji?
Thanks
Andrew