Skip to contentSkip to conversation

ASoC: SOF: ipc3-loader: Handle PROBE_INFO ext_manifest type

PATCH In review Peter Ujfalusi 2 participants 4 messages Nov 7, 2024

Subsystems (3)
lore
Share & tools
lore

Peter Ujfalusi

author maintainer
#0 lore raw

cover ASoC: SOF: ipc3-loader: Handle PROBE_INFO ext_manifest type

Hi,

The PROBE_INFO (ext_manifest type 3) is not used by the kernel, but at every tiem the firmware is loaded the following is printed in info level (user visible):
unknown sof_ext_man header type 3 size 0x30

The type is known, but it is not handled, the print is misleading.

Regards,
Peter
----
Peter Ujfalusi (2):
ASoC: SOF: ext_manifest: Add missing ext_manifest type for PROBE_INFO
ASoC: SOF: ipc3-loader: 'Handle' PROBE_INFO ext_manifest type when
parsing

 include/sound/sof/ext_manifest.h | 1 +
 sound/soc/sof/ipc3-loader.c      | 3 +++
 2 files changed, 4 insertions(+)
Signature · 1 line
2.47.0
author maintainer
#1 lore raw

PATCH 1/2 ASoC: SOF: ext_manifest: Add missing ext_manifest type for PROBE_INFO

Elem type 3 is PROBE_INFO in ext_manifest, add it to the list.

---
 include/sound/sof/ext_manifest.h | 1 +
 1 file changed, 1 insertion(+)
include/sound/sof/ext_manifest.h +1 -0
index fc0231d04a94..7dfe3ccf1fe4 100644
@@ -60,6 +60,7 @@ enum sof_ext_man_elem_type {
 	SOF_EXT_MAN_ELEM_FW_VERSION		= 0,
 	SOF_EXT_MAN_ELEM_WINDOW			= 1,
 	SOF_EXT_MAN_ELEM_CC_VERSION		= 2,
+	SOF_EXT_MAN_ELEM_PROBE_INFO		= 3,
 	SOF_EXT_MAN_ELEM_DBG_ABI		= 4,
 	SOF_EXT_MAN_ELEM_CONFIG_DATA		= 5, /**< ABI3.17 */
 	SOF_EXT_MAN_ELEM_PLATFORM_CONFIG_DATA   = 6,
Signature · 1 line
2.47.0
author maintainer
#2 lore raw

PATCH 2/2 ASoC: SOF: ipc3-loader: 'Handle' PROBE_INFO ext_manifest type when parsing

In reply to Peter Ujfalusi

Every time when the firmware is loaded we see the following printed in info level:
unknown sof_ext_man header type 3 size 0x30

This is the PROBE_INFO element, which is not parsed, but it is not something that we should treat as surprise, aka unknown type.

Add an empty case with a debug print to 'handle' this ext_manifest type and silence the confusing print in kernel log.

---
 sound/soc/sof/ipc3-loader.c | 3 +++
 1 file changed, 3 insertions(+)
sound/soc/sof/ipc3-loader.c +3 -0
index 35b89c2b9d4c..7e9c76d5b2c9 100644
@@ -193,6 +193,9 @@ static size_t sof_ipc3_fw_parse_ext_man(struct snd_sof_dev *sdev)
 		case SOF_EXT_MAN_ELEM_CC_VERSION:
 			ret = ipc3_fw_ext_man_get_cc_info(sdev, elem_hdr);
 			break;
+		case SOF_EXT_MAN_ELEM_PROBE_INFO:
+			dev_dbg(sdev->dev, "Probe info (not parsed)\n");
+			break;
 		case SOF_EXT_MAN_ELEM_DBG_ABI:
 			ret = ipc3_fw_ext_man_get_dbg_abi_info(sdev, elem_hdr);
 			break;
Signature · 1 line
2.47.0
maintainer
#3 lore raw
In reply to Peter Ujfalusi
Quoted 8 lines · Peter Ujfalusi

The PROBE_INFO (ext_manifest type 3) is not used by the kernel, but at every tiem the firmware is loaded the following is printed in info level (user visible):
unknown sof_ext_man header type 3 size 0x30

The type is known, but it is not handled, the print is misleading.

[...]

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/2] ASoC: SOF: ext_manifest: Add missing ext_manifest type for PROBE_INFO

      commit: 7f4eb7672b1785119b29a4dff50aeef13368e813
[2/2] ASoC: SOF: ipc3-loader: 'Handle' PROBE_INFO ext_manifest type when parsing
      commit: 83e367c1a178045bf3675646aa9582a0c5a4e566

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark