ASoC: SOF: sof-client-probes-ipc4: Set param_size extension bits
Subsystems (3)
Peter Ujfalusi
maintainerPATCH 1/1 ASoC: SOF: sof-client-probes-ipc4: Set param_size extension bits
From: Jyri Sarha <[email protected]>
Write the size of the optional payload of SOF_IPC4_MOD_INIT_INSTANCE message to extension param_size-bits.
The previous IPC4 version does not set these bits that should indicate the size of the optional payload (struct sof_ipc4_probe_cfg). The old firmware side component code works well without these bits, but when the probes are converted to use the generic module API, this does not work anymore.
--- sound/soc/sof/sof-client-probes-ipc4.c | 1 + 1 file changed, 1 insertion(+)
sound/soc/sof/sof-client-probes-ipc4.c +1 -0
@@ -125,6 +125,7 @@ static int ipc4_probes_init(struct sof_client_dev *cdev, u32 stream_tag, msg.primary |=SOF_IPC4_MSG_TARGET (SOF_IPC4_MODULE_MSG ); msg.extension =SOF_IPC4_MOD_EXT_DST_MOD_INSTANCE (INVALID_PIPELINE_ID ); msg.extension |=SOF_IPC4_MOD_EXT_CORE_ID (0 ); + msg.extension |=SOF_IPC4_MOD_EXT_PARAM_SIZE (sizeof (cfg) /sizeof (uint32_t )); msg.data_size =sizeof (cfg); msg.data_ptr = &cfg;
Signature · 1 line
2.47.0
Mark Brown
maintainerQuoted 10 lines · Peter Ujfalusi
Write the size of the optional payload of
SOF_IPC4_MOD_INIT_INSTANCEmessage to extension param_size-bits.The previous IPC4 version does not set these bits that should indicate the size of the optional payload (struct
sof_ipc4_probe_cfg). The old firmware side component code works well without these bits, but when the probes are converted to use the generic module API, this does not work anymore.[...]
Applied to
https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next
Thanks!
[1/1] ASoC: SOF: sof-client-probes-ipc4: Set param_size extension bits
commit: 48b86532c10128cf50c854a90c2d5b1410f4012d
All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.
You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.
If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.
Please add any relevant lists and maintainers to the CCs when replying to this mail.
Thanks,
Mark