Skip to contentSkip to conversation

bcachefs-tools: print usage & return -EINVAL when no matching subcommand

PATCH Superseded Integral 1 participant 1 message Nov 9, 2024

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore

Integral

author
#0 lore raw

PATCH 1/1 bcachefs-tools: print usage & return -EINVAL when no matching subcommand

When matching subcommand doesn't exixt, print usage and return -EINVAL.

---
 c_src/bcachefs.c | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)
c_src/bcachefs.c +5 -3
index 77bf6215..a904235d 100644
@@ -120,7 +120,7 @@ int fs_cmds(int argc, char *argv[])
 	if (!strcmp(cmd, "usage"))
 		return cmd_fs_usage(argc, argv);
 
-	return 0;
+	return -EINVAL;
 }
 
 int device_cmds(int argc, char *argv[])
@@ -146,7 +146,8 @@ int device_cmds(int argc, char *argv[])
 	if (!strcmp(cmd, "resize-journal"))
 		return cmd_device_resize_journal(argc, argv);
 
-	return 0;
+	device_usage();
+	return -EINVAL;
 }
 
 int data_cmds(int argc, char *argv[])
@@ -160,5 +161,6 @@ int data_cmds(int argc, char *argv[])
 	if (!strcmp(cmd, "job"))
 		return cmd_data_job(argc, argv);
 
-	return 0;
+	data_usage();
+	return -EINVAL;
 }

--
2.47.0