crypto: marvell/cesa: fix uninit value for struct mv_cesa_op_ctx
Subsystems (2)
PATCH 1/1 crypto: marvell/cesa: fix uninit value for struct mv_cesa_op_ctx
In cesa/cipher.c most declarations of struct mv_cesa_op_ctx are uninitialized. This causes one of the values in the struct to be left unitialized in later usages.
This patch fixes it by adding initializations in the same way it is done in cesa/hash.c.
Fixes errors discovered in coverity: 1600942, 1600939, 1600935, 1600934, 1600929, 1600927, 1600925, 1600921, 1600920, 1600919, 1600915, 1600914
--- drivers/crypto/marvell/cesa/cipher.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
drivers/crypto/marvell/cesa/cipher.c +12 -12
@@ -489,7 +489,7 @@ static int mv_cesa_des_op(struct skcipher_request *req,static int mv_cesa_ecb_des_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -500,7 +500,7 @@ static int mv_cesa_ecb_des_encrypt(struct skcipher_request *req)static int mv_cesa_ecb_des_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -543,7 +543,7 @@ static int mv_cesa_cbc_des_op(struct skcipher_request *req,static int mv_cesa_cbc_des_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { };mv_cesa_set_op_cfg (&tmpl,CESA_SA_DESC_CFG_DIR_ENC );
@@ -552,7 +552,7 @@ static int mv_cesa_cbc_des_encrypt(struct skcipher_request *req)static int mv_cesa_cbc_des_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { };mv_cesa_set_op_cfg (&tmpl,CESA_SA_DESC_CFG_DIR_DEC );
@@ -596,7 +596,7 @@ static int mv_cesa_des3_op(struct skcipher_request *req,static int mv_cesa_ecb_des3_ede_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -608,7 +608,7 @@ static int mv_cesa_ecb_des3_ede_encrypt(struct skcipher_request *req)static int mv_cesa_ecb_des3_ede_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -649,7 +649,7 @@ static int mv_cesa_cbc_des3_op(struct skcipher_request *req,static int mv_cesa_cbc_des3_ede_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_CBC |
@@ -661,7 +661,7 @@ static int mv_cesa_cbc_des3_ede_encrypt(struct skcipher_request *req)static int mv_cesa_cbc_des3_ede_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_CBC |
@@ -725,7 +725,7 @@ static int mv_cesa_aes_op(struct skcipher_request *req,static int mv_cesa_ecb_aes_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -736,7 +736,7 @@ static int mv_cesa_ecb_aes_encrypt(struct skcipher_request *req)static int mv_cesa_ecb_aes_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { }; mv_cesa_set_op_cfg(&tmpl, CESA_SA_DESC_CFG_CRYPTCM_ECB |
@@ -778,7 +778,7 @@ static int mv_cesa_cbc_aes_op(struct skcipher_request *req,static int mv_cesa_cbc_aes_encrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { };mv_cesa_set_op_cfg (&tmpl,CESA_SA_DESC_CFG_DIR_ENC );
@@ -787,7 +787,7 @@ static int mv_cesa_cbc_aes_encrypt(struct skcipher_request *req)static int mv_cesa_cbc_aes_decrypt (struct skcipher_request *req) { -struct mv_cesa_op_ctx tmpl; +struct mv_cesa_op_ctx tmpl = { };mv_cesa_set_op_cfg (&tmpl,CESA_SA_DESC_CFG_DIR_DEC );
Signature · 1 line
2.34.1
Herbert Xu
maintainerQuoted 7 lines · Karol Przybylski
In
cesa/cipher.cmost declarations of structmv_cesa_op_ctxare uninitialized. This causes one of the values in the struct to be left unitialized in later usages.This patch fixes it by adding initializations in the same way it is done in
cesa/hash.c.
Quoted 7 lines
Fixes errors discovered in coverity: 1600942, 1600939, 1600935, 1600934, 1600929, 1600927, 1600925, 1600921, 1600920, 1600919, 1600915, 1600914
Signed-off-by Karol Przybylski <[email protected]>--- drivers/crypto/marvell/cesa/cipher.c | 24 ++++++++++++------------ 1 file changed, 12 insertions(+), 12 deletions(-)
Patch applied. Thanks.
Signature · 3 lines
Email: Herbert Xu <[email protected]> Home Page: http://gondor.apana.org.au/~herbert/ PGP Key: http://gondor.apana.org.au/~herbert/pubkey.txt