Skip to contentSkip to conversation

mm/damon: fix order of arguments in damos_before_apply tracepoint

PATCH In review Akinobu Mita 2 participants 2 messages Nov 12, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 mm/damon: fix order of arguments in damos_before_apply tracepoint

Since the order of the scheme_idx and target_idx arguments in TP_ARGS is reversed, they are stored in the trace record in reverse.

Fixes c603c630b509 ("mm/damon/core: add a tracepoint for damos apply target regions")
Cc SeongJae Park <[email protected]>
---
 include/trace/events/damon.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
include/trace/events/damon.h +1 -1
index 23200aabccac..da4bd9fd1162 100644
@@ -15,7 +15,7 @@ TRACE_EVENT_CONDITION(damos_before_apply,
 		unsigned int target_idx, struct damon_region *r,
 		unsigned int nr_regions, bool do_trace),
 
-	TP_ARGS(context_idx, target_idx, scheme_idx, r, nr_regions, do_trace),
+	TP_ARGS(context_idx, scheme_idx, target_idx, r, nr_regions, do_trace),
 
 	TP_CONDITION(do_trace),
 
Signature · 1 line
2.34.1
maintainer Reviewed-by on v1 1/1
#1 lore raw

Hi Akinobu,

Quoted 2 lines · On Wed, 13 Nov 2024 00:48:28 +0900 Akinobu Mita <[email protected]> wrote:

Since the order of the scheme_idx and target_idx arguments in TP_ARGS is reversed, they are stored in the trace record in reverse.

Thank you for finding and fixing this!

Quoted 2 lines
Fixes c603c630b509 ("mm/damon/core: add a tracepoint for damos apply target regions")

Can we also add Cc: <[email protected]>?

Quoted 2 lines

Thanks,
SJ

[...]