Skip to contentSkip to conversation

jffs2: Use str_yes_no() helper function

PATCH RESEND In review Thorsten Blum 2 participants 2 messages Nov 12, 2024 – Nov 15, 2024

Subsystems (2)
Memory technology devices (MTD) Journalling flash file system V2 (JFFS2)

v1 of 2 In review Latest is v2 →

lore
Share & tools
lore

Thorsten Blum

author
#0 lore raw

PATCH RESEND 1/1 jffs2: Use str_yes_no() helper function

Remove hard-coded strings by using the str_yes_no() helper function.

Reviewed-by Zhihao Cheng <[email protected]>
Signed-off-by Thorsten Blum <[email protected]>
---
 fs/jffs2/nodemgmt.c | 9 +++++----
 1 file changed, 5 insertions(+), 4 deletions(-)
fs/jffs2/nodemgmt.c +5 -4
index bbab2bdc71b6..69569864630e 100644
@@ -15,6 +15,7 @@
 #include <linux/mtd/mtd.h>
 #include <linux/compiler.h>
 #include <linux/sched/signal.h>
+#include <linux/string_choices.h>
 #include "nodelist.h"
 #include "debug.h"
 

@@ -317,9 +318,9 @@ static int jffs2_find_nextblock(struct jffs2_sb_info *c)
 			   And there's no space left. At all. */
 			pr_crit("Argh. No free space left for GC. nr_erasing_blocks is %d. nr_free_blocks is %d. (erasableempty: %s, erasingempty: %s, erasependingempty: %s)\n",
 				c->nr_erasing_blocks, c->nr_free_blocks,
-				list_empty(&c->erasable_list) ? "yes" : "no",
-				list_empty(&c->erasing_list) ? "yes" : "no",
-				list_empty(&c->erase_pending_list) ? "yes" : "no");
+				str_yes_no(list_empty(&c->erasable_list)),
+				str_yes_no(list_empty(&c->erasing_list)),
+				str_yes_no(list_empty(&c->erase_pending_list)));
 			return -ENOSPC;
 		}
 

@@ -883,7 +884,7 @@ int jffs2_thread_should_wake(struct jffs2_sb_info *c)
 
 	jffs2_dbg(1, "%s(): nr_free_blocks %d, nr_erasing_blocks %d, dirty_size 0x%x, vdirty_blocks %d: %s\n",
 		  __func__, c->nr_free_blocks, c->nr_erasing_blocks,
-		  c->dirty_size, nr_very_dirty, ret ? "yes" : "no");
+		  c->dirty_size, nr_very_dirty, str_yes_no(ret));
 
 	return ret;
 }
Signature · 1 line
2.47.0