Skip to contentSkip to conversation

drivers/platform/mellanox/mlxbf-pmc.c:1172:14: sparse: sparse: incorrect type in assignment (different address spaces)

PATCH In review kernel test robot 4 participants 4 messages Nov 12, 2024 – Dec 2, 2024

Subsystems (2)
lore
Share & tools
lore

kernel test robot

author build bot
#0 lore raw
tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   2d5404caa8c7bb5c4e0435f94b28834ae5456623
commit: 423c3361855c1e81f1cb91728a2ac5ddfd2cbf16 platform/mellanox: mlxbf-pmc: Add support for BlueField-3
date:   1 year, 2 months ago
config: arm64-randconfig-r112-20241112 (https://download.01.org/0day-ci/archive/20241112/[email protected]/config)
compiler: aarch64-linux-gcc (GCC) 14.2.0
reproduce: (https://download.01.org/0day-ci/archive/20241112/[email protected]/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <[email protected]>
| Closes: https://lore.kernel.org/oe-kbuild-all/[email protected]/

sparse warnings: (new ones prefixed by >>)

>> drivers/platform/mellanox/mlxbf-pmc.c:1172:14: sparse: sparse: incorrect type in assignment (different address spaces) @@     expected void *addr @@     got void [noderef] __iomem * @@
   drivers/platform/mellanox/mlxbf-pmc.c:1172:14: sparse:     expected void *addr
   drivers/platform/mellanox/mlxbf-pmc.c:1172:14: sparse:     got void [noderef] __iomem *
>> drivers/platform/mellanox/mlxbf-pmc.c:1174:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@     expected void [noderef] __iomem *addr @@     got void *addr @@

drivers/platform/mellanox/mlxbf-pmc.c:1174:31: sparse: expected void [noderef] __iomem *addr
drivers/platform/mellanox/mlxbf-pmc.c:1174:31: sparse: got void *addr
drivers/platform/mellanox/mlxbf-pmc.c:1186:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got void *addr @@
drivers/platform/mellanox/mlxbf-pmc.c:1186:32: sparse: expected void [noderef] __iomem *addr
drivers/platform/mellanox/mlxbf-pmc.c:1186:32: sparse: got void *addr
drivers/platform/mellanox/mlxbf-pmc.c:1194:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem * @@
drivers/platform/mellanox/mlxbf-pmc.c:1194:14: sparse: expected void *addr
drivers/platform/mellanox/mlxbf-pmc.c:1194:14: sparse: got void [noderef] __iomem *
drivers/platform/mellanox/mlxbf-pmc.c:1198:32: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got void *addr @@
drivers/platform/mellanox/mlxbf-pmc.c:1198:32: sparse: expected void [noderef] __iomem *addr
drivers/platform/mellanox/mlxbf-pmc.c:1198:32: sparse: got void *addr
drivers/platform/mellanox/mlxbf-pmc.c:1415:14: sparse: sparse: incorrect type in assignment (different address spaces) @@ expected void *addr @@ got void [noderef] __iomem * @@
drivers/platform/mellanox/mlxbf-pmc.c:1415:14: sparse: expected void *addr
drivers/platform/mellanox/mlxbf-pmc.c:1415:14: sparse: got void [noderef] __iomem *
drivers/platform/mellanox/mlxbf-pmc.c:1417:31: sparse: sparse: incorrect type in argument 1 (different address spaces) @@ expected void [noderef] __iomem *addr @@ got void *addr @@
drivers/platform/mellanox/mlxbf-pmc.c:1417:31: sparse: expected void [noderef] __iomem *addr
drivers/platform/mellanox/mlxbf-pmc.c:1417:31: sparse: got void *addr

vim +1172 drivers/platform/mellanox/mlxbf-pmc.c

1163
1164 /* Method to handle crspace counter programming */
1165 static int mlxbf_pmc_program_crspace_counter(int blk_num, uint32_t cnt_num,
1166 uint32_t evt)
1167 {
1168 uint32_t word;
1169 void *addr;
1170 int ret;
1171

> 1172		addr = pmc->block[blk_num].mmio_base +
  1173			(rounddown(cnt_num, 2) * MLXBF_PMC_CRSPACE_PERFSEL_SZ);
> 1174		ret = mlxbf_pmc_readl(addr, &word);

1175 if (ret)
1176 return ret;
1177
1178 if (cnt_num % 2) {
1179 word &= ~MLXBF_PMC_CRSPACE_PERFSEL1;
1180 word |= FIELD_PREP(MLXBF_PMC_CRSPACE_PERFSEL1, evt);
1181 } else {
1182 word &= ~MLXBF_PMC_CRSPACE_PERFSEL0;
1183 word |= FIELD_PREP(MLXBF_PMC_CRSPACE_PERFSEL0, evt);
1184 }
1185
1186 return mlxbf_pmc_write(addr, MLXBF_PMC_WRITE_REG_32, word);
1187 }
1188

Signature · 2 lines
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
#1 lore raw

PATCH 1/1 platform/mellanox: mlxbf-pmc: incorrect type in assignment

sparse warning,expected 'void __iomem *addr',but got 'void *addr'

Fixes 423c3361855c ("platform/mellanox: mlxbf-pmc: Add support for BlueField-3")
---
 drivers/platform/mellanox/mlxbf-pmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/mellanox/mlxbf-pmc.c +3 -3
index 9d18dfca6a67..9ff7b487dc48 100644
@@ -1168,7 +1168,7 @@ static int mlxbf_pmc_program_l3_counter(unsigned int blk_num, u32 cnt_num, u32 e
 /* Method to handle crspace counter programming */
 static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num, u32 evt)
 {
-	void *addr;
+	void __iomem *addr;
 	u32 word;
 	int ret;
 
@@ -1192,7 +1192,7 @@ static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num,
 /* Method to clear crspace counter value */
 static int mlxbf_pmc_clear_crspace_counter(unsigned int blk_num, u32 cnt_num)
 {
-	void *addr;
+	void __iomem *addr;
 
 	addr = pmc->block[blk_num].mmio_base +
 		MLXBF_PMC_CRSPACE_PERFMON_VAL0(pmc->block[blk_num].counters) +
@@ -1405,7 +1405,7 @@ static int mlxbf_pmc_read_l3_event(unsigned int blk_num, u32 cnt_num, u64 *resul
 static int mlxbf_pmc_read_crspace_event(unsigned int blk_num, u32 cnt_num, u64 *result)
 {
 	u32 word, evt;
-	void *addr;
+	void __iomem *addr;
 	int ret;
 
 	addr = pmc->block[blk_num].mmio_base +
Signature · 1 line
2.34.1
Reviewed-by on v1 1/1
#2 lore raw

RE: [PATCH] platform/mellanox: mlxbf-pmc: incorrect type in assignment

Quoted 12 lines

-----Original Message-----
From: Pei Xiao <[email protected]>
Sent: Wednesday, November 20, 2024 2:52 AM
To: [email protected]; [email protected]; Vadim Pasternak <[email protected]>; [email protected]; linux- [email protected]
Cc: David Thompson <[email protected]>; Pei Xiao <[email protected]>; kernel test robot <[email protected]>
Subject: [PATCH] platform/mellanox: mlxbf-pmc: incorrect type in assignment

sparse warning,expected 'void __iomem *addr',but got 'void *addr'

Quoted 7 lines

[email protected]/

Fixes 423c3361855c ("platform/mellanox: mlxbf-pmc: Add support for BlueField-

3")

---

maintainer
#3 lore raw

Re: [PATCH] platform/mellanox: mlxbf-pmc: incorrect type in assignment

In reply to Pei Xiao
Quoted 1 line · Pei Xiao

sparse warning,expected 'void __iomem *addr',but got 'void *addr'

Hi,

Thanks for the patch. I've applied this patch to review-ilpo-next branch but I had to reformat the commit message. Please make sure you use proper spacing and put warnings like that on their own lines in future.

Signature · 1 line
 i.
Quoted 40 lines
Fixes 423c3361855c ("platform/mellanox: mlxbf-pmc: Add support for BlueField-3")
---
 drivers/platform/mellanox/mlxbf-pmc.c | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/platform/mellanox/mlxbf-pmc.c +3 -3
index 9d18dfca6a67..9ff7b487dc48 100644
@@ -1168,7 +1168,7 @@ static int mlxbf_pmc_program_l3_counter(unsigned int blk_num, u32 cnt_num, u32 e
 /* Method to handle crspace counter programming */
 static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num, u32 evt)
 {
-	void *addr;
+	void __iomem *addr;
 	u32 word;
 	int ret;
 
@@ -1192,7 +1192,7 @@ static int mlxbf_pmc_program_crspace_counter(unsigned int blk_num, u32 cnt_num,
 /* Method to clear crspace counter value */
 static int mlxbf_pmc_clear_crspace_counter(unsigned int blk_num, u32 cnt_num)
 {
-	void *addr;
+	void __iomem *addr;
 
 	addr = pmc->block[blk_num].mmio_base +
 		MLXBF_PMC_CRSPACE_PERFMON_VAL0(pmc->block[blk_num].counters) +
@@ -1405,7 +1405,7 @@ static int mlxbf_pmc_read_l3_event(unsigned int blk_num, u32 cnt_num, u64 *resul
 static int mlxbf_pmc_read_crspace_event(unsigned int blk_num, u32 cnt_num, u64 *result)
 {
 	u32 word, evt;
-	void *addr;
+	void __iomem *addr;
 	int ret;
 
 	addr = pmc->block[blk_num].mmio_base +