acpi/hmat / cxl: Add exclusive caching enumeration and RAS support
Subsystems (5)
Dave Jiang
maintainerv2 cover acpi/hmat / cxl: Add exclusive caching enumeration and RAS support
v2:
- Dropped 1/6 (ACPICA definition merged)
- Change UNKNOWN to RESERVED for cache definition. (Jonathan)
- Fix spelling errors (Jonathan)
- Rename region_res_match_range() to region_res_match_cxl_range(). (Jonathan)
- Add warning when cache is not 1:1 with backing region. (Jonathan)
- Code and comments cleanup. (Jonathan)
- Make MCE code access in CXL arch independent. (Jonathan)
- Fixup 0-day reports.
I'm looking for comments on the approach and the implementation of dealing with this exclusive caching configuration. I have concerns with the discovering and handling of the PCIe MMIO space in the memory mapping (MMIO hole) and looking for suggestions on if there are better ways to do it. One example of MMIO hole can possibly look like:
0 - 2G: RAM
2G-4G: MMIO
4G-end of memory: RAM
end of memory-infinity: 64-bit MMIO
Certain systems provide an exclusive caching memory configurations where a 1:1 layout of DRAM and far memory (FM) such as CXL memory is utilized. In this configuration, the memory region is provided as a single memory region to the OS. For example such as below:
128GB DRAM 128GB CXL memory
|------------------------------------|------------------------------------|
The kernel sees the region as a 256G system memory region. Data can reside in either DRAM or FM with no replication. Hot data is swapped into DRAM by the hardware behind the scenes.
This kernel series introduces code to enumerate the side cache by the kernel when configured in a exclusive-cache configuration. It also adds RAS support to deal with the aliased memory addresses.
A new ECN [1] to ACPI HMAT table was introduced and was approved to describe the "extended-linear" addressing for direct-mapped memory-side caches. A reserved field in the Memory Side Cache Information Structure of HMAT is redefined as "Address Mode" where a value of 1 is defined as Extended-linear mode. This value is valid if the cache is direct mapped. "It indicates that the associated address range (SRAT.MemoryAffinityStructure.Length) is comprised of the backing store capacity extended by the cache capacity." By augmenting the HMAT and SRAT parsing code, this new information can be stored by the HMAT handling code.
Current CXL region enumeration code is not enlightened with the side cache configuration and therefore only presents the region size as the size of the CXL region. Add support to allow CXL region enumeration code to query the HMAT handling code and retrieve the information regarding the side cache and adjust the region size accordingly. This should allow the CXL CLI to display the full region size rather than just the CXL only region size.
There are 3 sources where the kernel may be notified that error is detected for memory.
1. CXL DRAM event. This is a CXL event that is generated when an error is detected by the CXL device patrol or demand scrubber. The trace_event is augmented to display the aliased System Phyiscal Address (SPA) in addition to the alerted address. However, reporting of memory failure is TBD until the discussion [2] of failure reporting is settled upstream.
2. UCNA event from DRAM patrol or demand scrubber. This should eventually go through the MCE callback chain.
3. MCE from kernel consume poison.
It is possible that all 3 sources may report at the same time and all report at the error.
For 2 and 3, a MCE notifier callback is registered by the CXL on a per device basis. The callback will determine if the reported address is in one of the special regions and offline the aliased address if that is the case.
[1]: https://lore.kernel.org/linux-cxl/[email protected]/
[2]: https://lore.kernel.org/linux-cxl/[email protected]/
---
Dave Jiang (5):
acpi: numa: Add support to enumerate and store extended linear address mode acpi/hmat / cxl: Add extended linear cache support for CXL acpi/hmat: Add helper functions to provide extended linear cache translation
cxl: Add extended linear cache address alias emission for cxl events
cxl: Add mce notifier to emit aliased address for extended linear cache
Documentation/ABI/stable/sysfs-devices-node | 6 ++ arch/x86/include/asm/mce.h | 1 + arch/x86/mm/pat/set_memory.c | 1 + drivers/acpi/numa/hmat.c | 195 ++++++++++++++++++++++++++++++++++++++++++++++++ drivers/base/node.c | 2 + drivers/cxl/core/Makefile | 2 + drivers/cxl/core/acpi.c | 21 ++++++ drivers/cxl/core/core.h | 10 +++ drivers/cxl/core/mbox.c | 45 ++++++++++- drivers/cxl/core/mce.c | 52 +++++++++++++ drivers/cxl/core/mce.h | 14 ++++ drivers/cxl/core/region.c | 107 +++++++++++++++++++++++++- drivers/cxl/core/trace.h | 24 ++++-- drivers/cxl/cxl.h | 8 ++ drivers/cxl/cxlmem.h | 2 + include/linux/acpi.h | 25 +++++++ include/linux/node.h | 7 ++ tools/testing/cxl/Kbuild | 1 + 18 files changed, 508 insertions(+), 15 deletions(-)
Dave Jiang
maintainerRFC PATCH v2 1/5 acpi: numa: Add support to enumerate and store extended linear address mode
Store the address mode as part of the cache attriutes. Export the mode attribute to sysfs as all other cache attributes.
---
v2:
- Fix spelling errors (Jonathan)
- Change UNKNOWN to RESERVED (Jonathan)
--- Documentation/ABI/stable/sysfs-devices-node | 6 ++++++ drivers/acpi/numa/hmat.c | 3 +++ drivers/base/node.c | 2 ++ include/linux/node.h | 7 +++++++ 4 files changed, 18 insertions(+)
Documentation/ABI/stable/sysfs-devices-node +6 -0
@@ -177,6 +177,12 @@ Description: The cache write policy: 0 for write-back, 1 for write-through, other or unknown. +What: /sys/devices/system/node/nodeX/memory_side_cache/indexY/mode +Date: September 2024 +Contact: Dave Jiang <[email protected]> +Description: + The address mode: 0 for reserved, 1 for extended-linear. + What: /sys/devices/system/node/nodeX/x86/sgx_total_bytes Date: November 2021 Contact: Jarkko Sakkinen <[email protected]>
drivers/acpi/numa/hmat.c +3 -0
@@ -506,6 +506,9 @@ static __init int hmat_parse_cache(union acpi_subtable_headers *header,switch ((attrs &ACPI_HMAT_CACHE_ASSOCIATIVITY ) >>8 ) {case ACPI_HMAT_CA_DIRECT_MAPPED : tcache->cache_attrs.indexing =NODE_CACHE_DIRECT_MAP ; +/* Extended Linear mode is only valid if cache is direct mapped */ +if (cache->address_mode ==ACPI_HMAT_CACHE_MODE_EXTENDED_LINEAR ) + tcache->cache_attrs.mode =NODE_CACHE_MODE_EXTENDED_LINEAR ;break ;case ACPI_HMAT_CA_COMPLEX_CACHE_INDEXING : tcache->cache_attrs.indexing =NODE_CACHE_INDEXED ;
drivers/base/node.c +2 -0
@@ -244,12 +244,14 @@ CACHE_ATTR(size, "%llu") CACHE_ATTR(line_size, "%u") CACHE_ATTR(indexing, "%u") CACHE_ATTR(write_policy, "%u") +CACHE_ATTR(mode, "%u")static struct attribute *cache_attrs[] = { &dev_attr_indexing.attr, &dev_attr_size.attr, &dev_attr_line_size.attr, &dev_attr_write_policy.attr, + &dev_attr_mode.attr,NULL , };ATTRIBUTE_GROUPS (cache);
include/linux/node.h +7 -0
@@ -57,6 +57,11 @@ enum cache_write_policy { NODE_CACHE_WRITE_OTHER, }; +enum cache_mode { +NODE_CACHE_MODE_RESERVED , +NODE_CACHE_MODE_EXTENDED_LINEAR , +}; +/** * struct node_cache_attrs - system memory caching attributes *
@@ -65,6 +70,7 @@ enum cache_write_policy {* @size: Total size of cache in bytes * @line_size: Number of bytes fetched on a cache miss * @level: The cache hierarchy level +* @mode: The address mode */ struct node_cache_attrs {enum cache_indexing indexing;
@@ -72,6 +78,7 @@ struct node_cache_attrs {u64 size;u16 line_size;u8 level; +u16 mode; };#ifdef CONFIG_HMEM_REPORTING
Signature · 1 line
2.47.0
Re: [RFC PATCH v2 1/5] acpi: numa: Add support to enumerate and store extended linear address mode
Quoted 5 lines · On Tue, 12 Nov 2024 15:12:33 -0700 Dave Jiang <[email protected]> wrote:
Store the address mode as part of the cache attriutes. Export the mode attribute to sysfs as all other cache attributes.
One trivial suggestion that I don't care that much about.
Quoted 16 lines
---
v2:
- Fix spelling errors (Jonathan)
- Change UNKNOWN to RESERVED (Jonathan)--- Documentation/ABI/stable/sysfs-devices-node | 6 ++++++ drivers/acpi/numa/hmat.c | 3 +++ drivers/base/node.c | 2 ++ include/linux/node.h | 7 +++++++ 4 files changed, 18 insertions(+)Documentation/ABI/stable/sysfs-devices-node +0
-0
Documentation/ABI/stable/sysfs-devices-node Description: · line 180
Quoted 4 lines
Documentation/ABI/stable/sysfs-devices-node +1
-0@@ -177,6 +177,12 @@ Description: The cache write policy: 0 for write-back, 1 for write-through, other or unknown. +What: /sys/devices/system/node/nodeX/memory_side_cache/indexY/mode
Mode feels perhaps a bit to vague. Maybe address_mode?
Quoted 22 lines
Documentation/ABI/stable/sysfs-devices-node +5
-0+Date: September 2024 +Contact: Dave Jiang <[email protected]> +Description: + The address mode: 0 for reserved, 1 for extended-linear. + What: /sys/devices/system/node/nodeX/x86/sgx_total_bytes Date: November 2021 Contact: Jarkko Sakkinen <[email protected]>drivers/acpi/numa/hmat.c +3
-0@@ -506,6 +506,9 @@ static __init int hmat_parse_cache(union acpi_subtable_headers *header,switch ((attrs &ACPI_HMAT_CACHE_ASSOCIATIVITY ) >>8 ) {case ACPI_HMAT_CA_DIRECT_MAPPED : tcache->cache_attrs.indexing =NODE_CACHE_DIRECT_MAP ; +/* Extended Linear mode is only valid if cache is direct mapped */ +if (cache->address_mode ==ACPI_HMAT_CACHE_MODE_EXTENDED_LINEAR ) + tcache->cache_attrs.mode =NODE_CACHE_MODE_EXTENDED_LINEAR ;break ;case ACPI_HMAT_CA_COMPLEX_CACHE_INDEXING : tcache->cache_attrs.indexing =NODE_CACHE_INDEXED ;
Dave Jiang
maintainerRe: [RFC PATCH v2 1/5] acpi: numa: Add support to enumerate and store extended linear address mode
Quoted 31 lines · Jonathan Cameron
Quoted 5 lines · On Tue, 12 Nov 2024 15:12:33 -0700 Dave Jiang <[email protected]> wrote:
Store the address mode as part of the cache attriutes. Export the mode attribute to sysfs as all other cache attributes.
One trivial suggestion that I don't care that much about.
Reviewed-by Jonathan Cameron <[email protected]>Quoted 19 lines
---
v2:
- Fix spelling errors (Jonathan)
- Change UNKNOWN to RESERVED (Jonathan)--- Documentation/ABI/stable/sysfs-devices-node | 6 ++++++ drivers/acpi/numa/hmat.c | 3 +++ drivers/base/node.c | 2 ++ include/linux/node.h | 7 +++++++ 4 files changed, 18 insertions(+)Documentation/ABI/stable/sysfs-devices-node +0
-0@@ -177,6 +177,12 @@ Description: The cache write policy: 0 for write-back, 1 for write-through, other or unknown.
Quoted 3 lines
Documentation/ABI/stable/sysfs-devices-node Description: · line 180
Quoted 1 line
Documentation/ABI/stable/sysfs-devices-node +1
-0+What: /sys/devices/system/node/nodeX/memory_side_cache/indexY/modeMode feels perhaps a bit to vague. Maybe
address_mode?
ok
DJ
Quoted 24 lines
Quoted 23 lines
Documentation/ABI/stable/sysfs-devices-node +5
-0+Date: September 2024 +Contact: Dave Jiang <[email protected]> +Description: + The address mode: 0 for reserved, 1 for extended-linear. + What: /sys/devices/system/node/nodeX/x86/sgx_total_bytes Date: November 2021 Contact: Jarkko Sakkinen <[email protected]>drivers/acpi/numa/hmat.c +3
-0@@ -506,6 +506,9 @@ static __init int hmat_parse_cache(union acpi_subtable_headers *header,switch ((attrs &ACPI_HMAT_CACHE_ASSOCIATIVITY ) >>8 ) {case ACPI_HMAT_CA_DIRECT_MAPPED : tcache->cache_attrs.indexing =NODE_CACHE_DIRECT_MAP ; +/* Extended Linear mode is only valid if cache is direct mapped */ +if (cache->address_mode ==ACPI_HMAT_CACHE_MODE_EXTENDED_LINEAR ) + tcache->cache_attrs.mode =NODE_CACHE_MODE_EXTENDED_LINEAR ;break ;case ACPI_HMAT_CA_COMPLEX_CACHE_INDEXING : tcache->cache_attrs.indexing =NODE_CACHE_INDEXED ;
Dave Jiang
maintainerRFC PATCH v2 2/5 acpi/hmat / cxl: Add extended linear cache support for CXL
In reply to Dave JiangThe current cxl region size only indicates the size of the CXL memory region without accounting for the extended linear cache size. Retrieve the cache size from HMAT and append that to the cxl region size for the cxl region range that matches the SRAT range that has extended linear cache enabled.
The SRAT defines the whole memory range that includes the extended linear cache and the CXL memory region. The new HMAT ECN/ECR to the Memory Side Cache Information Structure defines the size of the extended linear cache size and matches to the SRAT Memory Affinity Structure by the memory proxmity domain. Add a helper to match the cxl range to the SRAT memory range in order to retrieve the cache size.
There are several places that checks the cxl region range against the decoder range. Use new helper to check between the two ranges and address the new cache size.
---
v2:
- Fix spelling errors (Jonathan)
- Move matching of res range to the match loop. (Jonathan)
- Rename region_res_match_range() to region_res_match_cxl_range() and add comments. (Jonathan)
- Refactor region_res_match_cxl_range() to simplify code. (Jonathan)
- Remove unintended blank line. (Jonathan)
- Add warning emission when cache is not 1:1 to cxl region. (Jonathan)
--- drivers/acpi/numa/hmat.c | 44 ++++++++++++++++++++++++ drivers/cxl/core/Makefile | 1 + drivers/cxl/core/acpi.c | 11 ++++++ drivers/cxl/core/core.h | 3 ++ drivers/cxl/core/region.c | 70 ++++++++++++++++++++++++++++++++++++--- drivers/cxl/cxl.h | 2 ++ include/linux/acpi.h | 19 +++++++++++ tools/testing/cxl/Kbuild | 1 + 8 files changed, 147 insertions(+), 4 deletions(-) create mode 100644 drivers/cxl/core/acpi.c
drivers/acpi/numa/hmat.c +44 -0
@@ -108,6 +108,50 @@ static struct memory_target *find_mem_target(unsigned int mem_pxm)return NULL ; } +/** +* hmat_get_extended_linear_cache_size - Retrieve the extended linear cache size +* @backing_res: resource from the backing media +* @nid: node id for the memory region +* @cache_size: (Output) size of extended linear cache. +* +* Return: 0 on success. Errno on failure. +* +*/ +int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, +resource_size_t *cache_size) +{ +unsigned int pxm =node_to_pxm (nid); +struct memory_target *target; +struct target_cache *tcache; +bool cache_found = false; +struct resource *res; + + target =find_mem_target (pxm); +if (!target) +return -ENOENT ; + +list_for_each_entry (tcache, &target->caches, node) { +if (tcache->cache_attrs.mode ==NODE_CACHE_MODE_EXTENDED_LINEAR ) { + res = &target->memregions; +if (!resource_contains (res, backing_res)) +continue ; + + cache_found = true; +break ; + } + } + +if (!cache_found) { + *cache_size =0 ; +return 0 ; + } + + *cache_size = tcache->cache_attrs.size; + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (hmat_get_extended_linear_cache_size,CXL ); +static struct memory_target *acpi_find_genport_target (u32 uid) {struct memory_target *target;
drivers/cxl/core/Makefile +1 -0
@@ -14,5 +14,6 @@ cxl_core-y += pci.o cxl_core-y += hdm.o cxl_core-y += pmu.o cxl_core-y += cdat.o +cxl_core-y += acpi.o cxl_core-$(CONFIG_TRACING) += trace.o cxl_core-$(CONFIG_CXL_REGION) += region.o
drivers/cxl/core/acpi.c new file +11 -0
@@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ +#include <linux/acpi.h> +#include "cxl.h" +#include "core.h" + +int cxl_acpi_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size) +{ +return hmat_get_extended_linear_cache_size (backing_res, nid, size); +}
drivers/cxl/core/core.h +3 -0
@@ -110,4 +110,7 @@ bool cxl_need_node_perf_attrs_update(int nid);int cxl_port_get_switch_dport_bandwidth (struct cxl_port *port,struct access_coordinate *c); +int cxl_acpi_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size); +#endif /* __CXL_CORE_H__ */
drivers/cxl/core/region.c +66 -4
106 lines not on this page · raw message
drivers/cxl/cxl.h +2 -0
@@ -483,6 +483,7 @@ enum cxl_config_state {* @res: allocated iomem capacity for this region * @targets: active ordered targets in current decoder configuration * @nr_targets: number of targets +* @cache_size: extended linear cache size, if exists * * State transitions are protected by the cxl_region_rwsem */
@@ -494,6 +495,7 @@ struct cxl_region_params {struct resource *res;struct cxl_endpoint_decoder *targets[CXL_DECODER_MAX_INTERLEAVE ];int nr_targets; +resource_size_t cache_size; };/*
include/linux/acpi.h +19 -0
@@ -436,12 +436,20 @@ int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp);#ifdef CONFIG_ACPI_HMAT int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord); +int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, +resource_size_t *size);#else static inline int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord) {return -EOPNOTSUPP ; } + +static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size) +{ +return -EOPNOTSUPP ; +}#endif #ifdef CONFIG_ACPI_NUMA
@@ -1090,6 +1098,17 @@ static inline acpi_handle acpi_get_processor_handle(int cpu)#endif /* !CONFIG_ACPI */ +#ifdef CONFIG_ACPI_HMAT +int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, +resource_size_t *size); +#else +static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size) +{ +return -EOPNOTSUPP ; +} +#endif +extern void arch_post_acpi_subsys_init (void );#ifdef CONFIG_ACPI_HOTPLUG_IOAPIC
tools/testing/cxl/Kbuild +1 -0
@@ -61,6 +61,7 @@ cxl_core-y += $(CXL_CORE_SRC)/pci.o cxl_core-y += $(CXL_CORE_SRC)/hdm.o cxl_core-y += $(CXL_CORE_SRC)/pmu.o cxl_core-y += $(CXL_CORE_SRC)/cdat.o +cxl_core-y += $(CXL_CORE_SRC)/acpi.o cxl_core-$(CONFIG_TRACING) += $(CXL_CORE_SRC)/trace.o cxl_core-$(CONFIG_CXL_REGION) += $(CXL_CORE_SRC)/region.o cxl_core-y += config_check.o
Signature · 1 line
2.47.0
Re: [RFC PATCH v2 2/5] acpi/hmat / cxl: Add extended linear cache support for CXL
Quoted 13 lines · On Tue, 12 Nov 2024 15:12:34 -0700 Dave Jiang <[email protected]> wrote:
The current cxl region size only indicates the size of the CXL memory region without accounting for the extended linear cache size. Retrieve the cache size from HMAT and append that to the cxl region size for the cxl region range that matches the SRAT range that has extended linear cache enabled.
The SRAT defines the whole memory range that includes the extended linear cache and the CXL memory region. The new HMAT ECN/ECR to the Memory Side Cache Information Structure defines the size of the extended linear cache size and matches to the SRAT Memory Affinity Structure by the memory proxmity domain. Add a helper to match the cxl range to the SRAT memory range in order to retrieve the cache size.
Quoted 5 lines
There are several places that checks the cxl region range against the decoder range. Use new helper to check between the two ranges and address the new cache size.
Signed-off-by Dave Jiang <[email protected]>
Hi Dave,
A few minor comments inline.
Thanks,
Jonathan
Quoted 34 lines
--- drivers/acpi/numa/hmat.c | 44 ++++++++++++++++++++++++ drivers/cxl/core/Makefile | 1 + drivers/cxl/core/acpi.c | 11 ++++++ drivers/cxl/core/core.h | 3 ++ drivers/cxl/core/region.c | 70 ++++++++++++++++++++++++++++++++++++--- drivers/cxl/cxl.h | 2 ++ include/linux/acpi.h | 19 +++++++++++ tools/testing/cxl/Kbuild | 1 + 8 files changed, 147 insertions(+), 4 deletions(-) create mode 100644 drivers/cxl/core/acpi.cdrivers/acpi/numa/hmat.c +14
-0@@ -108,6 +108,50 @@ static struct memory_target *find_mem_target(unsigned int mem_pxm)return NULL ; } +/** +* hmat_get_extended_linear_cache_size - Retrieve the extended linear cache size +* @backing_res: resource from the backing media +* @nid: node id for the memory region +* @cache_size: (Output) size of extended linear cache. +* +* Return: 0 on success. Errno on failure. +* +*/ +int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, +resource_size_t *cache_size) +{ +unsigned int pxm =node_to_pxm (nid); +struct memory_target *target;
drivers/acpi/numa/hmat.c static struct memory_target *find_mem_target(unsigned int mem_pxm) · line 134
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+struct target_cache *tcache; +bool cache_found = false; +struct resource *res; + + target =find_mem_target (pxm); +if (!target) +return -ENOENT ; + +list_for_each_entry (tcache, &target->caches, node) { +if (tcache->cache_attrs.mode ==NODE_CACHE_MODE_EXTENDED_LINEAR ) {
I'd flip this for slightly better readability.
if (tcache->cache_attrs.mode != NODE_CACHE_MODE_EXTENDED_LINEAR) continue; res = ...
Quoted 5 lines
drivers/acpi/numa/hmat.c +5
-0+ res = &target->memregions; +if (!resource_contains (res, backing_res)) +continue ; + + cache_found = true;
drivers/acpi/numa/hmat.c static struct memory_target *find_mem_target(unsigned int mem_pxm) · line 149
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+break ; + } + } + +if (!cache_found) { + *cache_size =0 ; +return 0 ; + } + + *cache_size = tcache->cache_attrs.size;
Why not set this and return in the loop?
That way no need to have a local variable.
Quoted 11 lines
drivers/acpi/numa/hmat.c +4
-0+ +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (hmat_get_extended_linear_cache_size,CXL );drivers/cxl/core/acpi.c new file +0
-0
drivers/cxl/core/acpi.c line 5
Quoted 5 lines
drivers/cxl/core/acpi.c new file +5
-0@@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ +#include <linux/acpi.h> +#include "cxl.h" +#include "core.h"
Why do you need the cxl headers? Maybe a forwards def of struct resource, but I'm not seeing anything else being needed.
Quoted 31 lines
drivers/cxl/core/acpi.c new file +25
-0+ +int cxl_acpi_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size) +{ +return hmat_get_extended_linear_cache_size (backing_res, nid, size); +}@@ -3215,6 +3229,42 @@ static int match_region_by_range(struct device *dev, void *data)return rc; } +static int cxl_extended_linear_cache_resize (struct cxl_region *cxlr, +struct resource *res) +{ +struct cxl_region_params *p = &cxlr->params; +int nid =phys_to_target_node (res->start); +resource_size_t size, cache_size; +int rc; + + size =resource_size (res); +if (!size) +return -EINVAL ; + + rc =cxl_acpi_get_extended_linear_cache_size (res, nid, &cache_size); +if (rc) +return rc; + +if (!cache_size) +return 0 ; +
drivers/cxl/core/acpi.c static int match_region_by_range(struct device *dev, void *data) · line 3260
Quoted 10 lines
drivers/cxl/core/acpi.c new file +10
-0+if (size != cache_size) { +dev_warn (&cxlr->dev,"Extended Linear Cache is not 1:1, unsupported!" ); +return -EOPNOTSUPP ; + } + +/* +* Move the start of the range to where the cache range starts. The +* implementation assumes that the cache range is in front of the +* CXL range. This is not dictated by the HMAT spec but is how the +* currently known implementation configured.
is configured
Quoted 6 lines
drivers/cxl/core/acpi.c new file +6
-0+*/ + res->start -= cache_size; + p->cache_size = cache_size; + +return 0 ; +}
Dave Jiang
maintainerRe: [RFC PATCH v2 2/5] acpi/hmat / cxl: Add extended linear cache support for CXL
Quoted 67 lines · Jonathan Cameron
Quoted 13 lines · On Tue, 12 Nov 2024 15:12:34 -0700 Dave Jiang <[email protected]> wrote:
The current cxl region size only indicates the size of the CXL memory region without accounting for the extended linear cache size. Retrieve the cache size from HMAT and append that to the cxl region size for the cxl region range that matches the SRAT range that has extended linear cache enabled.
The SRAT defines the whole memory range that includes the extended linear cache and the CXL memory region. The new HMAT ECN/ECR to the Memory Side Cache Information Structure defines the size of the extended linear cache size and matches to the SRAT Memory Affinity Structure by the memory proxmity domain. Add a helper to match the cxl range to the SRAT memory range in order to retrieve the cache size.
Quoted 5 lines
There are several places that checks the cxl region range against the decoder range. Use new helper to check between the two ranges and address the new cache size.
Signed-off-by Dave Jiang <[email protected]>Hi Dave,
A few minor comments inline.
Thanks,
Jonathan
Quoted 38 lines
--- drivers/acpi/numa/hmat.c | 44 ++++++++++++++++++++++++ drivers/cxl/core/Makefile | 1 + drivers/cxl/core/acpi.c | 11 ++++++ drivers/cxl/core/core.h | 3 ++ drivers/cxl/core/region.c | 70 ++++++++++++++++++++++++++++++++++++--- drivers/cxl/cxl.h | 2 ++ include/linux/acpi.h | 19 +++++++++++ tools/testing/cxl/Kbuild | 1 + 8 files changed, 147 insertions(+), 4 deletions(-) create mode 100644 drivers/cxl/core/acpi.cdrivers/acpi/numa/hmat.c +18
-0@@ -108,6 +108,50 @@ static struct memory_target *find_mem_target(unsigned int mem_pxm)return NULL ; } +/** +* hmat_get_extended_linear_cache_size - Retrieve the extended linear cache size +* @backing_res: resource from the backing media +* @nid: node id for the memory region +* @cache_size: (Output) size of extended linear cache. +* +* Return: 0 on success. Errno on failure. +* +*/ +int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, +resource_size_t *cache_size) +{ +unsigned int pxm =node_to_pxm (nid); +struct memory_target *target; +struct target_cache *tcache; +bool cache_found = false; +struct resource *res; +
Quoted 8 lines
drivers/acpi/numa/hmat.c static struct memory_target *find_mem_target(unsigned int mem_pxm) · line 134
Quoted 6 lines
drivers/acpi/numa/hmat.c +6
-0+ target =find_mem_target (pxm); +if (!target) +return -ENOENT ; + +list_for_each_entry (tcache, &target->caches, node) { +if (tcache->cache_attrs.mode ==NODE_CACHE_MODE_EXTENDED_LINEAR ) {I'd flip this for slightly better readability.
ok
Quoted 16 lines
if (tcache->cache_attrs.mode != NODE_CACHE_MODE_EXTENDED_LINEAR) continue; res = ...Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+ res = &target->memregions; +if (!resource_contains (res, backing_res)) +continue ; + + cache_found = true; +break ; + } + } + +if (!cache_found) {
Quoted 8 lines
drivers/acpi/numa/hmat.c static struct memory_target *find_mem_target(unsigned int mem_pxm) · line 149
Quoted 5 lines
drivers/acpi/numa/hmat.c +5
-0+ *cache_size =0 ; +return 0 ; + } + + *cache_size = tcache->cache_attrs.size;Why not set this and return in the loop?
That way no need to have a local variable.
ok
Quoted 6 lines
Quoted 5 lines
drivers/acpi/numa/hmat.c +4
-0+ +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (hmat_get_extended_linear_cache_size,CXL );
Quoted 14 lines
drivers/cxl/core/acpi.c line 5
Quoted 11 lines
drivers/cxl/core/acpi.c new file +5
-0@@ -0,0 +1,11 @@ +// SPDX-License-Identifier: GPL-2.0-only +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ +#include <linux/acpi.h> +#include "cxl.h" +#include "core.h" Why do you need the cxl headers? Maybe a forwards def of struct resource, but I'm not seeing anything else being needed.
The prototype is declared in core.h, and it seems core.h needs cxl.h. I wonder if core.h should just include cxl.h.
Quoted 37 lines
Quoted 37 lines
drivers/cxl/core/acpi.c new file +29
-0+ +int cxl_acpi_get_extended_linear_cache_size (struct resource *backing_res, +int nid,resource_size_t *size) +{ +return hmat_get_extended_linear_cache_size (backing_res, nid, size); +}@@ -3215,6 +3229,42 @@ static int match_region_by_range(struct device *dev, void *data)return rc; } +static int cxl_extended_linear_cache_resize (struct cxl_region *cxlr, +struct resource *res) +{ +struct cxl_region_params *p = &cxlr->params; +int nid =phys_to_target_node (res->start); +resource_size_t size, cache_size; +int rc; + + size =resource_size (res); +if (!size) +return -EINVAL ; + + rc =cxl_acpi_get_extended_linear_cache_size (res, nid, &cache_size); +if (rc) +return rc; + +if (!cache_size) +return 0 ; + +if (size != cache_size) { +dev_warn (&cxlr->dev,"Extended Linear Cache is not 1:1, unsupported!" ); +return -EOPNOTSUPP ; + }
Quoted 8 lines
drivers/cxl/core/acpi.c static int match_region_by_range(struct device *dev, void *data) · line 3260
Quoted 6 lines
drivers/cxl/core/acpi.c new file +6
-0+ +/* +* Move the start of the range to where the cache range starts. The +* implementation assumes that the cache range is in front of the +* CXL range. This is not dictated by the HMAT spec but is how the +* currently known implementation configured. is configured
will fix
Quoted 9 lines
Quoted 7 lines
drivers/cxl/core/acpi.c new file +6
-0+*/ + res->start -= cache_size; + p->cache_size = cache_size; + +return 0 ; +}
Dave Jiang
maintainerRFC PATCH v2 3/5 acpi/hmat: Add helper functions to provide extended linear cache translation
In reply to Dave JiangAdd helper functions to help do address translation for either the address of the extended linear cache or its alias address. The translation function attempt to detect an I/O hole in the proximity domain and adjusts the address if the hole impacts the aliasing of the address. The range of the I/O hole is retrieved by walking through the associated memory target resources.
---
v2:
- Drop extra variable and use 'res' from the loop. (Jonathan)
- Break up multiple if statements into single blocks and add comments. (Jonathan)
--- drivers/acpi/numa/hmat.c | 148 +++++++++++++++++++++++++++++++++++++++ include/linux/acpi.h | 14 ++++ 2 files changed, 162 insertions(+)
drivers/acpi/numa/hmat.c +148 -0
@@ -152,6 +152,154 @@ int hmat_get_extended_linear_cache_size(struct resource *backing_res, int nid, }EXPORT_SYMBOL_NS_GPL (hmat_get_extended_linear_cache_size,CXL ); +static int alias_address_find_iohole (struct memory_target *target, +u64 address,u64 alias,struct range *hole) +{ +struct resource *res, *prev; + + *hole = (struct range ) { + .start =0 , + .end =-1 , + }; + +/* First find the resource that the address is in */ + prev = target->memregions.child; +for (res = target->memregions.child; res; res = res->sibling) { +if (alias >= res->start && alias <= res->end) +break ; + prev = res; + } +if (!res) +return -EINVAL ; + +/* No memory hole */ +if (res == prev) +return 0 ; + +/* If address is within the current resource, no need to deal with memory hole */ +if (address >= res->start) +return 0 ; + + *hole = (struct range ) { + .start = prev->end +1 , + .end = res->start -1 , + }; + +return 0 ; +} + +int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid) +{ +unsigned int pxm =node_to_pxm (nid); +struct memory_target *target; +struct range iohole; +int rc; + + target =find_mem_target (pxm); +if (!target) +return -EINVAL ; + + rc =alias_address_find_iohole (target, address, *alias, &iohole); +if (rc) +return rc; + +if (!range_len (&iohole)) +return 0 ; + +/* +* If the cache start (address) is behind the MMIO I/O hole then there +* is no change to the passed in CXL address (alias). +*/ +if (address >= iohole.start) +return 0 ; + +/* +* If the aliased CXL address is before the MMIO I/O hole start then +* CXL address (alias) is also not impacted. +*/ +if (*alias <= iohole.start) +return 0 ; + + *alias +=range_len (&iohole); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (hmat_extended_linear_cache_alias_xlat,CXL ); + +static int target_address_find_iohole (struct memory_target *target, +u64 address,u64 alias, +struct range *hole) +{ +struct resource *res, *next; + + *hole = (struct range ) { + .start =0 , + .end =-1 , + }; + +/* First find the resource that the address is in */ +for (res = target->memregions.child; res; res = res->sibling) { +if (address >= res->start && address <= res->end) +break ; + } +if (!res) +return -EINVAL ; + + next = res->sibling; +/* No memory hole after the region */ +if (!next) +return 0 ; + +/* If alias is within the current resource, no need to deal with memory hole */ +if (alias <= res->end) +return 0 ; + + *hole = (struct range ) { + .start = res->end +1 , + .end = next->start -1 , + }; + +return 0 ; +} + +int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid) +{ +unsigned int pxm =node_to_pxm (nid); +struct memory_target *target; +struct range iohole; +int rc; + + target =find_mem_target (pxm); +if (!target) +return -EINVAL ; + + rc =target_address_find_iohole (target, *address, alias, &iohole); +if (rc) +return rc; + +if (!range_len (&iohole)) +return 0 ; + +/* +* If the CXL address is before the MMIO hole then there is no change +* to the passed in cache address. +*/ +if (alias <= iohole.end) +return 0 ; + +/* +* If the calculated cache address is after the MMIO hole then there +* is no change to the passed in cache address. +*/ +if (*address >= iohole.end) +return 0 ; + + *address -=range_len (&iohole); + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (hmat_extended_linear_cache_address_xlat,CXL ); +static struct memory_target *acpi_find_genport_target (u32 uid) {struct memory_target *target;
include/linux/acpi.h +14 -0
@@ -438,6 +438,8 @@ int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp);int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord);int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size); +int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid); +int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid);#else static inline int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord)
@@ -450,6 +452,18 @@ static inline int hmat_get_extended_linear_cache_size(struct resource *backing_r {return -EOPNOTSUPP ; } + +static inline int hmat_extended_linear_cache_alias_xlat (u64 address, +u64 *alias,int nid) +{ +return -EOPNOTSUPP ; +} + +static inline int hmat_extended_linear_cache_address_xlat (u64 *address, +u64 alias,int nid) +{ +return -EOPNOTSUPP ; +}#endif #ifdef CONFIG_ACPI_NUMA
Signature · 1 line
2.47.0
Re: [RFC PATCH v2 3/5] acpi/hmat: Add helper functions to provide extended linear cache translation
Quoted 9 lines · On Tue, 12 Nov 2024 15:12:35 -0700 Dave Jiang <[email protected]> wrote:
Add helper functions to help do address translation for either the address of the extended linear cache or its alias address. The translation function attempt to detect an I/O hole in the proximity domain and adjusts the address if the hole impacts the aliasing of the address. The range of the I/O hole is retrieved by walking through the associated memory target resources.
Signed-off-by Dave Jiang <[email protected]>---
Trivial comment inline. I'm far from expert on requirements here but it seems to match your description.
Quoted 31 lines
v2:
- Drop extra variable and use 'res' from the loop. (Jonathan)
- Break up multiple if statements into single blocks and add comments. (Jonathan)--- drivers/acpi/numa/hmat.c | 148 +++++++++++++++++++++++++++++++++++++++ include/linux/acpi.h | 14 ++++ 2 files changed, 162 insertions(+)drivers/acpi/numa/hmat.c +15
-0@@ -152,6 +152,154 @@ int hmat_get_extended_linear_cache_size(struct resource *backing_res, int nid, }EXPORT_SYMBOL_NS_GPL (hmat_get_extended_linear_cache_size,CXL ); +static int alias_address_find_iohole (struct memory_target *target, +u64 address,u64 alias,struct range *hole) +{ +struct resource *res, *prev; + + *hole = (struct range ) { + .start =0 , + .end =-1 , + }; + +/* First find the resource that the address is in */ + prev = target->memregions.child; +for (res = target->memregions.child; res; res = res->sibling) { +if (alias >= res->start && alias <= res->end) +break ;
drivers/acpi/numa/hmat.c int hmat_get_extended_linear_cache_size(struct resource *backing_res, int nid, · line 179
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+ prev = res; + } +if (!res) +return -EINVAL ; + +/* No memory hole */ +if (res == prev) +return 0 ; + +/* If address is within the current resource, no need to deal with memory hole */
Rather long line that could be easily broken.
Quoted 10 lines
drivers/acpi/numa/hmat.c +10
-0+if (address >= res->start) +return 0 ; + + *hole = (struct range ) { + .start = prev->end +1 , + .end = res->start -1 , + }; + +return 0 ; +}
Dave Jiang
maintainerRFC PATCH v2 4/5 cxl: Add extended linear cache address alias emission for cxl events
In reply to Dave JiangAdd the aliased address of extended linear cache when emitting event trace for DRAM and general media of CXL events.
---
v2:
- Fix spelling errors. (Jonathan)
--- drivers/cxl/core/acpi.c | 10 ++++++++++ drivers/cxl/core/core.h | 7 +++++++ drivers/cxl/core/mbox.c | 42 ++++++++++++++++++++++++++++++++++++--- drivers/cxl/core/region.c | 12 +++++++++++ drivers/cxl/core/trace.h | 24 ++++++++++++++-------- include/linux/acpi.h | 36 +++++++++++++-------------------- 6 files changed, 98 insertions(+), 33 deletions(-)
drivers/cxl/core/acpi.c +10 -0
@@ -9,3 +9,13 @@ int cxl_acpi_get_extended_linear_cache_size(struct resource *backing_res, {return hmat_get_extended_linear_cache_size (backing_res, nid, size); } + +int cxl_acpi_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid) +{ +return hmat_extended_linear_cache_address_xlat (address, alias, nid); +} + +int cxl_acpi_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid) +{ +return hmat_extended_linear_cache_alias_xlat (address, alias, nid); +}
drivers/cxl/core/core.h +7 -0
@@ -30,8 +30,13 @@ int cxl_get_poison_by_endpoint(struct cxl_port *port);struct cxl_region *cxl_dpa_to_region (const struct cxl_memdev *cxlmd,u64 dpa);u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa); +int cxl_region_nid (struct cxl_region *cxlr);#else +static inline int cxl_region_nid (struct cxl_region *cxlr) +{ +return NUMA_NO_NODE ; +}static inline u64 cxl_dpa_to_hpa (struct cxl_region *cxlr,const struct cxl_memdev *cxlmd,u64 dpa) {
@@ -112,5 +117,7 @@ int cxl_port_get_switch_dport_bandwidth(struct cxl_port *port,int cxl_acpi_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size); +int cxl_acpi_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid); +int cxl_acpi_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid);#endif /* __CXL_CORE_H__ */
drivers/cxl/core/mbox.c +39 -3
63 lines not on this page · raw message
drivers/cxl/core/region.c +12 -0
@@ -2405,6 +2405,18 @@ static bool cxl_region_update_coordinates(struct cxl_region *cxlr, int nid)return true; } +int cxl_region_nid (struct cxl_region *cxlr) +{ +struct cxl_region_params *p = &cxlr->params; +struct resource *res; + +guard (rwsem_read)(&cxl_region_rwsem); + res = p->res; +if (!res) +return NUMA_NO_NODE ; +return phys_to_target_node (res->start); +} +static int cxl_region_perf_attrs_callback (struct notifier_block *nb,unsigned long action,void *arg) {
drivers/cxl/core/trace.h +16 -8
@@ -316,9 +316,10 @@ TRACE_EVENT(cxl_generic_event, TRACE_EVENT(cxl_general_media, TP_PROTO(const struct cxl_memdev *cxlmd, enum cxl_event_log_type log, - struct cxl_region *cxlr, u64 hpa, struct cxl_event_gen_media *rec), + struct cxl_region *cxlr, u64 hpa, u64 hpa_alias, + struct cxl_event_gen_media *rec), - TP_ARGS(cxlmd, log, cxlr, hpa, rec), + TP_ARGS(cxlmd, log, cxlr, hpa, hpa_alias, rec), TP_STRUCT__entry( CXL_EVT_TP_entry
@@ -332,6 +333,7 @@ TRACE_EVENT(cxl_general_media,__array (u8, comp_id,CXL_EVENT_GEN_MED_COMP_ID_SIZE ) /* Following are out of order to pack trace record */ __field(u64, hpa) + __field(u64, hpa_alias) __field_struct(uuid_t, region_uuid) __field(u16, validity_flags)__field (u8, rank)
@@ -358,6 +360,7 @@ TRACE_EVENT(cxl_general_media, CXL_EVENT_GEN_MED_COMP_ID_SIZE); __entry->validity_flags =get_unaligned_le16 (&rec->media_hdr.validity_flags); __entry->hpa = hpa; + __entry->hpa_alias = hpa_alias;if (cxlr) {__assign_str (region_name);uuid_copy (&__entry->region_uuid, &cxlr->params.uuid);
@@ -370,7 +373,7 @@ TRACE_EVENT(cxl_general_media, CXL_EVT_TP_printk("dpa=%llx dpa_flags='%s' " \ "descriptor='%s' type='%s' transaction_type='%s' channel=%u rank=%u " \ "device=%x comp_id=%s validity_flags='%s' " \ - "hpa=%llx region=%s region_uuid=%pUb", + "hpa=%llx hpa_alias=%llx region=%s region_uuid=%pUb", __entry->dpa, show_dpa_flags(__entry->dpa_flags), show_event_desc_flags(__entry->descriptor), show_mem_event_type(__entry->type),
@@ -378,7 +381,8 @@ TRACE_EVENT(cxl_general_media, __entry->channel, __entry->rank, __entry->device,__print_hex (__entry->comp_id,CXL_EVENT_GEN_MED_COMP_ID_SIZE ),show_valid_flags (__entry->validity_flags), - __entry->hpa,__get_str (region_name), &__entry->region_uuid + __entry->hpa, __entry->hpa_alias,__get_str (region_name), + &__entry->region_uuid ) );
@@ -413,9 +417,10 @@ TRACE_EVENT(cxl_general_media, TRACE_EVENT(cxl_dram, TP_PROTO(const struct cxl_memdev *cxlmd, enum cxl_event_log_type log, - struct cxl_region *cxlr, u64 hpa, struct cxl_event_dram *rec), + struct cxl_region *cxlr, u64 hpa, u64 hpa_alias, + struct cxl_event_dram *rec), - TP_ARGS(cxlmd, log, cxlr, hpa, rec), + TP_ARGS(cxlmd, log, cxlr, hpa, hpa_alias, rec), TP_STRUCT__entry( CXL_EVT_TP_entry
@@ -431,6 +436,7 @@ TRACE_EVENT(cxl_dram, __field(u32, row) __array(u8, cor_mask, CXL_EVENT_DER_CORRECTION_MASK_SIZE) __field(u64, hpa) + __field(u64, hpa_alias) __field_struct(uuid_t, region_uuid) __field(u8, rank) /* Out of order to pack trace record */__field (u8, bank_group)/* Out of order to pack trace record */
@@ -461,6 +467,7 @@ TRACE_EVENT(cxl_dram,memcpy (__entry->cor_mask, &rec->correction_mask,CXL_EVENT_DER_CORRECTION_MASK_SIZE ); __entry->hpa = hpa; + __entry->hpa_alias = hpa_alias;if (cxlr) {__assign_str (region_name);uuid_copy (&__entry->region_uuid, &cxlr->params.uuid);
@@ -474,7 +481,7 @@ TRACE_EVENT(cxl_dram,"transaction_type='%s' channel=%u rank=%u nibble_mask=%x " \"bank_group=%u bank=%u row=%u column=%u cor_mask=%s " \"validity_flags='%s' " \ -"hpa=%llx region=%s region_uuid=%pUb" , +"hpa=%llx hpa_alias=%llx region=%s region_uuid=%pUb" , __entry->dpa,show_dpa_flags (__entry->dpa_flags),show_event_desc_flags (__entry->descriptor), show_mem_event_type(__entry->type),
@@ -484,7 +491,8 @@ TRACE_EVENT(cxl_dram, __entry->row, __entry->column,__print_hex (__entry->cor_mask,CXL_EVENT_DER_CORRECTION_MASK_SIZE ),show_dram_valid_flags (__entry->validity_flags), - __entry->hpa,__get_str (region_name), &__entry->region_uuid + __entry->hpa_alias, __entry->hpa,__get_str (region_name), + &__entry->region_uuid ) );
include/linux/acpi.h +14 -22
@@ -436,34 +436,12 @@ int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp);#ifdef CONFIG_ACPI_HMAT int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord); -int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, -resource_size_t *size); -int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid); -int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid);#else static inline int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord) {return -EOPNOTSUPP ; } - -static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res, -int nid,resource_size_t *size) -{ -return -EOPNOTSUPP ; -} - -static inline int hmat_extended_linear_cache_alias_xlat (u64 address, -u64 *alias,int nid) -{ -return -EOPNOTSUPP ; -} - -static inline int hmat_extended_linear_cache_address_xlat (u64 *address, -u64 alias,int nid) -{ -return -EOPNOTSUPP ; -}#endif #ifdef CONFIG_ACPI_NUMA
@@ -1115,12 +1093,26 @@ static inline acpi_handle acpi_get_processor_handle(int cpu)#ifdef CONFIG_ACPI_HMAT int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size); +int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid); +int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid);#else static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size) {return -EOPNOTSUPP ; } + +static inline int hmat_extended_linear_cache_alias_xlat (u64 address, +u64 *alias,int nid) +{ +return -EOPNOTSUPP ; +} + +static inline int hmat_extended_linear_cache_address_xlat (u64 *address, +u64 alias,int nid) +{ +return -EOPNOTSUPP ; +}#endif extern void arch_post_acpi_subsys_init (void );
Signature · 1 line
2.47.0
Re: [RFC PATCH v2 4/5] cxl: Add extended linear cache address alias emission for cxl events
Quoted 4 lines · On Tue, 12 Nov 2024 15:12:36 -0700 Dave Jiang <[email protected]> wrote:
Add the aliased address of extended linear cache when emitting event trace for DRAM and general media of CXL events.
Signed-off-by Dave Jiang <[email protected]>
There is some code movement in here I wasn't expecting to see.
Otherwise looks fine to me.
Jonathan
Quoted 40 lines
include/linux/acpi.h +0
-22@@ -436,34 +436,12 @@ int thermal_acpi_critical_trip_temp(struct acpi_device *adev, int *ret_temp);#ifdef CONFIG_ACPI_HMAT int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord); -int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid, -resource_size_t *size); -int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid); -int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid);#else static inline int acpi_get_genport_coordinates (u32 uid,struct access_coordinate *coord) {return -EOPNOTSUPP ; } - -static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res, -int nid,resource_size_t *size) -{ -return -EOPNOTSUPP ; -} - -static inline int hmat_extended_linear_cache_alias_xlat (u64 address, -u64 *alias,int nid) -{ -return -EOPNOTSUPP ; -} - -static inline int hmat_extended_linear_cache_address_xlat (u64 *address, -u64 alias,int nid) -{ -return -EOPNOTSUPP ; -}#endif #ifdef CONFIG_ACPI_NUMA
include/linux/acpi.h static inline acpi_handle acpi_get_processor_handle(int cpu) · line 1097
Quoted 5 lines
include/linux/acpi.h +2
-0@@ -1115,12 +1093,26 @@ static inline acpi_handle acpi_get_processor_handle(int cpu)#ifdef CONFIG_ACPI_HMAT int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size); +int hmat_extended_linear_cache_alias_xlat (u64 address,u64 *alias,int nid); +int hmat_extended_linear_cache_address_xlat (u64 *address,u64 alias,int nid);
If this makes sense can we put them here in the first place?
Quoted 21 lines
include/linux/acpi.h +12
-0#else static inline int hmat_get_extended_linear_cache_size (struct resource *backing_res,int nid,resource_size_t *size) {return -EOPNOTSUPP ; } + +static inline int hmat_extended_linear_cache_alias_xlat (u64 address, +u64 *alias,int nid) +{ +return -EOPNOTSUPP ; +} + +static inline int hmat_extended_linear_cache_address_xlat (u64 *address, +u64 alias,int nid) +{ +return -EOPNOTSUPP ; +}#endif extern void arch_post_acpi_subsys_init (void );
Dave Jiang
maintainerRFC PATCH v2 5/5 cxl: Add mce notifier to emit aliased address for extended linear cache
In reply to Dave JiangBelow is a setup with extended linear cache configuration with an example layout of memory region shown below presented as a single memory region consists of 256G memory where there's 128G of DRAM and 128G of CXL memory. The kernel sees a region of total 256G of system memory.
128G DRAM 128G CXL memory
|-----------------------------------|-------------------------------------|
Data resides in either DRAM or far memory (FM) with no replication. Hot data is swapped into DRAM by the hardware behind the scenes. When error is detected in one location, it is possible that error also resides in the aliased location. Therefore when a memory location that is flagged by MCE is part of the special region, the aliased memory location needs to be offlined as well.
Add an mce notify callback to identify if the MCE address location is part of an extended linear cache region and handle accordingly.
Added symbol export to set_mce_nospec() in x86 code in order to call set_mce_nospec() from the CXL MCE notify callback.
---
v2:
- Move mce code to core/mce.c and add arch wrappers for CONFIG_X86_64. (Jonathan)
--- arch/x86/include/asm/mce.h | 1 + arch/x86/mm/pat/set_memory.c | 1 + drivers/cxl/core/Makefile | 1 + drivers/cxl/core/mbox.c | 3 +++ drivers/cxl/core/mce.c | 52 ++++++++++++++++++++++++++++++++++++ drivers/cxl/core/mce.h | 14 ++++++++++ drivers/cxl/core/region.c | 25 +++++++++++++++++ drivers/cxl/cxl.h | 6 +++++ drivers/cxl/cxlmem.h | 2 ++ 9 files changed, 105 insertions(+) create mode 100644 drivers/cxl/core/mce.c create mode 100644 drivers/cxl/core/mce.h
arch/x86/include/asm/mce.h +1 -0
@@ -182,6 +182,7 @@ enum mce_notifier_prios {MCE_PRIO_NFIT ,MCE_PRIO_EXTLOG ,MCE_PRIO_UC , +MCE_PRIO_CXL ,MCE_PRIO_EARLY ,MCE_PRIO_CEC ,MCE_PRIO_HIGHEST =MCE_PRIO_CEC
arch/x86/mm/pat/set_memory.c +1 -0
@@ -2083,6 +2083,7 @@ int set_mce_nospec(unsigned long pfn)pr_warn ("Could not invalidate pfn=0x%lx from 1:1 map\n" , pfn);return rc; } +EXPORT_SYMBOL_GPL (set_mce_nospec);/* Restore full speculative operation to the pfn. */ int clear_mce_nospec (unsigned long pfn)
drivers/cxl/core/Makefile +1 -0
@@ -17,3 +17,4 @@ cxl_core-y += cdat.o cxl_core-y += acpi.o cxl_core-$(CONFIG_TRACING) += trace.o cxl_core-$(CONFIG_CXL_REGION) += region.o +cxl_core-$(CONFIG_X86_MCE) += mce.o
drivers/cxl/core/mbox.c +3 -0
@@ -11,6 +11,7 @@#include "core.h" #include "trace.h" +#include "mce.h" static bool cxl_raw_allow_all;
@@ -1489,6 +1490,8 @@ struct cxl_memdev_state *cxl_memdev_state_create(struct device *dev) mds->ram_perf.qos_class =CXL_QOS_CLASS_INVALID ; mds->pmem_perf.qos_class =CXL_QOS_CLASS_INVALID ; +cxl_register_mce_notifier (&mds->mce_notifier); +return mds; }EXPORT_SYMBOL_NS_GPL (cxl_memdev_state_create,CXL );
drivers/cxl/core/mce.c new file +52 -0
52 lines not on this page · raw message
drivers/cxl/core/mce.h new file +14 -0
@@ -0,0 +1,14 @@ +/* SPDX-License-Identifier: GPL-2.0-only */ +/* Copyright(c) 2024 Intel Corporation. All rights reserved. */ +#ifndef _CXL_CORE_MCE_H_ +#define _CXL_CORE_MCE_H_ + +#include <linux/notifier.h> + +#ifdef CONFIG_X86_MCE +void cxl_register_mce_notifier (struct notifier_block *mce_notifer); +#else +static inline void cxl_register_mce_notifier (struct notifier_block *mce_notifier) {} +#endif + +#endif
drivers/cxl/core/region.c +25 -0
@@ -3440,6 +3440,31 @@ int cxl_add_to_region(struct cxl_port *root, struct cxl_endpoint_decoder *cxled) }EXPORT_SYMBOL_NS_GPL (cxl_add_to_region,CXL ); +u64 cxl_port_get_spa_cache_alias (struct cxl_port *endpoint,u64 spa) +{ +struct cxl_region_ref *iter; +unsigned long index; + +guard (rwsem_write)(&cxl_region_rwsem); + +xa_for_each (&endpoint->regions, index, iter) { +struct cxl_region_params *p = &iter->region->params; + +if (p->res->start <= spa && spa <= p->res->end) { +if (!p->cache_size) +return 0 ; + +if (spa > p->res->start + p->cache_size) +return spa - p->cache_size; + +return spa + p->cache_size; + } + } + +return 0 ; +} +EXPORT_SYMBOL_NS_GPL (cxl_port_get_spa_cache_alias,CXL ); +static int is_system_ram (struct resource *res,void *arg) {struct cxl_region *cxlr = arg;
drivers/cxl/cxl.h +6 -0
@@ -866,6 +866,7 @@ struct cxl_pmem_region *to_cxl_pmem_region(struct device *dev);int cxl_add_to_region (struct cxl_port *root,struct cxl_endpoint_decoder *cxled);struct cxl_dax_region *to_cxl_dax_region (struct device *dev); +u64 cxl_port_get_spa_cache_alias (struct cxl_port *endpoint,u64 spa);#else static inline bool is_cxl_pmem_region (struct device *dev) {
@@ -884,6 +885,11 @@ static inline struct cxl_dax_region *to_cxl_dax_region(struct device *dev) {return NULL ; } +static inline u64 cxl_port_get_spa_cache_alias (struct cxl_port *endpoint, +u64 spa) +{ +return 0 ; +}#endif void cxl_endpoint_parse_cdat (struct cxl_port *port);
drivers/cxl/cxlmem.h +2 -0
@@ -477,6 +477,7 @@ static inline struct cxl_dev_state *mbox_to_cxlds(struct cxl_mailbox *cxl_mbox)* @poison: poison driver state info * @security: security driver state info * @fw: firmware upload / activation state +* @mce_notifier: MCE notifier * * See CXL 3.0 8.2.9.8.2 Capacity Configuration and Label Storage for * details on capacity parameters.
@@ -503,6 +504,7 @@ struct cxl_memdev_state {struct cxl_poison_state poison;struct cxl_security_state security;struct cxl_fw_state fw; +struct notifier_block mce_notifier; }; static inline struct cxl_memdev_state *
Signature · 1 line
2.47.0
Borislav Petkov
maintainerRe: [RFC PATCH v2 5/5] cxl: Add mce notifier to emit aliased address for extended linear cache
arch/x86/include/asm/mce.h enum mce_notifier_prios { · line 188
Quoted 12 lines · Dave Jiang
arch/x86/include/asm/mce.h +1
-0@@ -182,6 +182,7 @@ enum mce_notifier_prios {MCE_PRIO_NFIT ,MCE_PRIO_EXTLOG ,MCE_PRIO_UC , +MCE_PRIO_CXL ,MCE_PRIO_EARLY ,MCE_PRIO_CEC ,MCE_PRIO_HIGHEST =MCE_PRIO_CEC
Why this priority exactly?
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteDave Jiang
maintainerRe: [RFC PATCH v2 5/5] cxl: Add mce notifier to emit aliased address for extended linear cache
Quoted 15 lines · Borislav Petkov
arch/x86/include/asm/mce.h enum mce_notifier_prios { · line 188
Quoted 12 lines · Dave Jiang
arch/x86/include/asm/mce.h +1
-0@@ -182,6 +182,7 @@ enum mce_notifier_prios {MCE_PRIO_NFIT ,MCE_PRIO_EXTLOG ,MCE_PRIO_UC , +MCE_PRIO_CXL ,MCE_PRIO_EARLY ,MCE_PRIO_CEC ,MCE_PRIO_HIGHEST =MCE_PRIO_CEC Why this priority exactly?
Hi Boris,
I'm actually looking for recommendation on what the proper one is. The handler is expected to offline the aliased address of the reported MCE if there is one.
Quoted 1 line
Borislav Petkov
maintainerRe: [RFC PATCH v2 5/5] cxl: Add mce notifier to emit aliased address for extended linear cache
Quoted 3 lines · Dave Jiang
I'm actually looking for recommendation on what the proper one is. The handler is expected to offline the aliased address of the reported MCE if there is one.
Well, MCE_PRIO_EARLY will emit a trace record so that if you have error events consumers like rasdaemon, it'll get that error record for reporting etc.
MCE_PRIO_UC calls memory_failure() on the error and thus offlines the page. Functionality which you're partly replicating in your notifier.
And since you wanna do the same thing, why are you even adding a new priority instead of using MCE_PRIO_UC? amdgpu_bad_page_notifier() uses that same prio because it does a similar thing.
Signature · 4 lines
Regards/Gruss,
Boris.
https://people.kernel.org/tglx/notes-about-netiquetteDave Jiang
maintainerRe: [RFC PATCH v2 5/5] cxl: Add mce notifier to emit aliased address for extended linear cache
Quoted 8 lines · Borislav Petkov
Quoted 3 lines · Dave Jiang
I'm actually looking for recommendation on what the proper one is. The handler is expected to offline the aliased address of the reported MCE if there is one.
Well,
MCE_PRIO_EARLYwill emit a trace record so that if you have error events consumers like rasdaemon, it'll get that error record for reporting etc.
Quoted 6 lines
MCE_PRIO_UCcallsmemory_failure()on the error and thus offlines the page. Functionality which you're partly replicating in your notifier.And since you wanna do the same thing, why are you even adding a new priority instead of using
MCE_PRIO_UC?amdgpu_bad_page_notifier()uses that same prio because it does a similar thing.
Ok thanks for the explanation. I will use MCE_PRIO_UC.