clk:sophgo:clk-cv18xx-pll: Remove uninitialized u32 parameter and variable
Subsystems (2)
PATCH 1/1 clk:sophgo:clk-cv18xx-pll: Remove uninitialized u32 parameter and variable
Updating the detected value to 0 in the ipll_find_rate and removing it from the method parameters as it does not depend on external input. Updating the calls to ipll_find_rate as well and removing the u32 val variable from ipll_determine_rate.
Fixes 80fd61ec4612 ("clk: sophgo: Add clock support for CV1800 SoC")
Signed-off-by Ragavendra Nagraj <[email protected]>
--- drivers/clk/sophgo/clk-cv18xx-pll.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/clk/sophgo/clk-cv18xx-pll.c +4 -6
@@ -44,15 +44,15 @@ static unsigned long ipll_recalc_rate(struct clk_hw *hw, PLL_GET_POST_DIV_SEL(value)); }static int ipll_find_rate (const struct cv1800_clk_pll_limit *limit, -unsigned long prate,unsigned long *rate, -u32 *value) +unsigned long prate,unsigned long *rate) {unsigned long best_rate =0 ;unsigned long trate = *rate;unsigned long pre_div_sel =0 , div_sel =0 , post_div_sel =0 ;unsigned long pre, div, post; -u32 detected = *value; +u32 detected =0 ;unsigned long tmp;for_each_pll_limit_range (pre, &limit->pre_div) {
@@ -87,11 +87,10 @@ static int ipll_find_rate(const struct cv1800_clk_pll_limit *limit,static int ipll_determine_rate (struct clk_hw *hw,struct clk_rate_request *req) { -u32 val;struct cv1800_clk_pll *pll =hw_to_cv1800_clk_pll (hw);return ipll_find_rate (pll->pll_limit, req->best_parent_rate, - &req->rate, &val); + &req->rate); } static void pll_get_mode_ctrl(unsigned long div_sel,
@@ -134,7 +133,7 @@ static int ipll_set_rate(struct clk_hw *hw, unsigned long rate,unsigned long flags;struct cv1800_clk_pll *pll =hw_to_cv1800_clk_pll (hw); -ipll_find_rate (pll->pll_limit, parent_rate, &rate, &detected); +ipll_find_rate (pll->pll_limit, parent_rate, &rate);pll_get_mode_ctrl (PLL_GET_DIV_SEL (detected), ipll_check_mode_ctrl_restrict, pll->pll_limit, &detected);
Signature · 1 line
2.46.1