nvmet: report ns's vwc not present
Subsystems (2)
PATCH v5 1/1 nvmet: report ns's vwc not present
Currently, we report that controller has vwc even though the ns may not have vwc. Report ns's vwc not present when not buffered_io or backdev doesn't have vwc.
---
Based on Keith's v4 patch,
Changes from v4 to v5:
- When the backend is file, report support vwc even though buffered_io is disable, and add an annotation to expain it.
drivers/nvme/target/admin-cmd.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/nvme/target/admin-cmd.c +7 -0
@@ -934,6 +934,13 @@ static void nvmet_execute_id_cs_indep(struct nvmet_req *req) id->nsattr |=NVME_NS_ATTR_RO ;if (req->ns->bdev && !bdev_nonrot (req->ns->bdev)) id->nsfeat |=NVME_NS_ROTATIONAL ; +/* +* We need flush command to flush the file's metadata, +* so report supporting vwc if backend is file, even +* though buffered_io is disable. +*/ +if (req->ns->bdev && !bdev_write_cache (req->ns->bdev)) + id->nsfeat |=NVME_NS_VWC_NOT_PRESENT ; status =nvmet_copy_to_sgl (req,0 , id,sizeof (*id));kfree (id);
Signature · 1 line
2.43.0
Looks good:
Quoted 7 lines · Guixin Liu
Currently, we report that controller has vwc even though the ns may not have vwc. Report ns's vwc not present when not
buffered_ioor backdev doesn't have vwc.Signed-off-by Guixin Liu<[email protected]>Signed-off-by Keith Busch<[email protected]>---
Looks good.
-ck
Quoted 3 lines · Guixin Liu
Currently, we report that controller has vwc even though the ns may not have vwc. Report ns's vwc not present when not
buffered_ioor backdev doesn't have vwc.
Thanks, applied to nvme-6.13.