Skip to contentSkip to conversation

arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

PATCH In review Rob Herring (Arm) 5 participants 8 messages Nov 15, 2024 – Dec 5, 2024

Subsystems (2)
lore
Share & tools
lore

Rob Herring (Arm)

author maintainer
#0 lore raw

PATCH 1/1 arm64: dts: sprd: Remove unused and undocumented "constant_charge_voltage_max_microvolt" property

Remove "constant_charge_voltage_max_microvolt" property which is both unused in the kernel and undocumented. Most likely they are leftovers from downstream.

---
 arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 1 -
 1 file changed, 1 deletion(-)
arch/arm64/boot/dts/sprd/sp9860g-1h10.dts +0 -1
index 095b24a31313..e60838695d0e 100644
@@ -71,7 +71,6 @@ bat: battery {
 		compatible = "simple-battery";
 		charge-full-design-microamp-hours = <1900000>;
 		charge-term-current-microamp = <120000>;
-		constant_charge_voltage_max_microvolt = <4350000>;
 		internal-resistance-micro-ohms = <250000>;
 		ocv-capacity-celsius = <20>;
 		ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>,
Signature · 1 line
2.45.2
Reviewed-by on v1 1/1
#1 lore raw
Quoted 3 lines · Rob Herring (Arm)

Remove "constant_charge_voltage_max_microvolt" property which is both unused in the kernel and undocumented. Most likely they are leftovers from downstream.

Yes. LGTM. Thanks.

Quoted 17 lines
---
  arch/arm64/boot/dts/sprd/sp9860g-1h10.dts | 1 -
  1 file changed, 1 deletion(-)
arch/arm64/boot/dts/sprd/sp9860g-1h10.dts +0 -1
index 095b24a31313..e60838695d0e 100644
@@ -71,7 +71,6 @@ bat: battery {
  		compatible = "simple-battery";
  		charge-full-design-microamp-hours = <1900000>;
  		charge-term-current-microamp = <120000>;
-		constant_charge_voltage_max_microvolt = <4350000>;
  		internal-resistance-micro-ohms = <250000>;
  		ocv-capacity-celsius = <20>;
  		ocv-capacity-table-0 = <4185000 100>, <4113000 95>, <4066000 90>,
#4 lore raw
Quoted 9 lines · Baolin Wang
Quoted 6 lines · Stanislav Jakubek

Hi Rob,

constant-charge-voltage-max-microvolt is a valid property, which I assume was the original intention here. I've already submitted a patch changing this to the documented property:

Quoted 5 lines
Quoted 3 lines

https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/

Baolin also reviewed that patch... make of that what you will.

Ah, yes. Sorry I forgot your patch. Thanks for reminding.

No one picked them up... I kept Stanislav's patches in my incoming/inbox folder for quite long time, because I pick up some random fixes here and there, but then forgot them and did not apply for v6.13-rc1. So they missed v6.13-rc1.

I am not the maintainer of that platform, so I don't care about it really, but I care about contributors work not being lost/ignored.

What is the plan with these and all other Spreadtrum patches? Are they going to be applied by you or other Spreadtrum maintainers? Do you need any help from us? Or maybe some clarifications of the process?

Best regards,
Krzysztof

reviewer
#5 lore raw

Hi Krzysztof,

Quoted 22 lines · Krzysztof Kozlowski
Quoted 9 lines · Baolin Wang
Quoted 6 lines · Stanislav Jakubek

Hi Rob,

constant-charge-voltage-max-microvolt is a valid property, which I assume was the original intention here. I've already submitted a patch changing this to the documented property:

Quoted 5 lines
Quoted 3 lines

https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/

Baolin also reviewed that patch... make of that what you will.

Ah, yes. Sorry I forgot your patch. Thanks for reminding.

No one picked them up... I kept Stanislav's patches in my incoming/inbox folder for quite long time, because I pick up some random fixes here and there, but then forgot them and did not apply for v6.13-rc1. So they missed v6.13-rc1.

Quoted 6 lines

I am not the maintainer of that platform, so I don't care about it really, but I care about contributors work not being lost/ignored.

What is the plan with these and all other Spreadtrum patches? Are they going to be applied by you or other Spreadtrum maintainers? Do you need any help from us? Or maybe some clarifications of the process?

Yes we need your help!

The Spreadtrum DTS patches had been being maintained through my tree. I'm not suitable to do this any more due to some changes (I've moved myself to the reviewer entry of sprd).

After discussion with other sprd maintainers, we still want the Spreadtrum patches to go through your tree if you agree.

Thanks for all the help,
Chunyan

Quoted 3 lines

Best regards,
Krzysztof

#6 lore raw
Quoted 32 lines · Chunyan Zhang

Hi Krzysztof,

Quoted 22 lines · Krzysztof Kozlowski
Quoted 9 lines · Baolin Wang
Quoted 6 lines · Stanislav Jakubek

Hi Rob,

constant-charge-voltage-max-microvolt is a valid property, which I assume was the original intention here. I've already submitted a patch changing this to the documented property:

Quoted 5 lines
Quoted 3 lines

https://lore.kernel.org/lkml/aa557091d9494fdaa3eda75803f9ea97014c8832.1730918663.git.stano.jakubek@gmail.com/

Baolin also reviewed that patch... make of that what you will.

Ah, yes. Sorry I forgot your patch. Thanks for reminding.

No one picked them up... I kept Stanislav's patches in my incoming/inbox folder for quite long time, because I pick up some random fixes here and there, but then forgot them and did not apply for v6.13-rc1. So they missed v6.13-rc1.

Quoted 6 lines

I am not the maintainer of that platform, so I don't care about it really, but I care about contributors work not being lost/ignored.

What is the plan with these and all other Spreadtrum patches? Are they going to be applied by you or other Spreadtrum maintainers? Do you need any help from us? Or maybe some clarifications of the process?

Quoted 8 lines

Yes we need your help!

The Spreadtrum DTS patches had been being maintained through my tree. I'm not suitable to do this any more due to some changes (I've moved myself to the reviewer entry of sprd).

After discussion with other sprd maintainers, we still want the Spreadtrum patches to go through your tree if you agree.

+Cc Arnd,

With few folks we talked briefly on IRC, but that probably missed some audience. I was indeed taking orphaned fixes, not only for Spreadtrum but also other trees, but that's different than maintaining. I don't feel comfortable taking any features or making any maintenance decisions about Spreadtrum, so I should not be listed in MAINTAINERS file. If I am not listed there, it is likely I will miss patches, so me picking up fixes here solves current issue, but does not really solve the problem long term.

If there is no one willing to handle patches for Spreadtrum, maybe the platform's status should be changed from Maintained to "Odd Fixes"?

Best regards,
Krzysztof