arm64: dts: qcom: Remove unused and undocumented properties
Rob Herring (Arm)
maintainerPATCH 1/1 arm64: dts: qcom: Remove unused and undocumented properties
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
--- arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi | 5 ----- arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts | 1 - 2 files changed, 6 deletions(-)
arch/arm64/boot/dts/qcom/msm8994-msft-lumia-octagon.dtsi +0 -5
@@ -387,11 +387,6 @@ sideinteraction: touch@2c { interrupts = <&tlmm 96 IRQ_TYPE_EDGE_FALLING>; - button_num = <8>; - touchpad_num = <0>; - wheel_num = <0>; - slider_num = <0>; - vcc-supply = <&vreg_l18a_2p85>; };
arch/arm64/boot/dts/qcom/sdm845-shift-axolotl.dts +0 -1
@@ -452,7 +452,6 @@ touchscreen@38 { irq-gpio = <&tlmm 125 GPIO_TRANSITORY>; touchscreen-size-x = <1080>; touchscreen-size-y = <2160>; - focaltech,max-touch-number = <5>; }; };
Signature · 1 line
2.45.2
Quoted 5 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Signed-off-by Rob Herring (Arm) <[email protected]>---
Funny, the sideinteraction compatible is undocumented and the touchscreen driver is not upstream
Konrad
Quoted 9 lines · Konrad Dybcio
Quoted 5 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Signed-off-by Rob Herring (Arm) <[email protected]>---
Funny, the sideinteraction compatible is undocumented and the touchscreen driver is not upstream
Does the compatible also need to be fixed to "focaltech,ft8719"? Refer to the info from [1].
Confirmed, the compatible "focaltech,fts8719" is not even in any merged bindings or drivers. Instead, "focaltech,ft8719" is in the current driver and bindings.
By the way, I am curious about how Rob finds the unused properties. Could you share some steps?
[1]https://lore.kernel.org/all/[email protected]/
Signature · 2 lines
Thx and BRs, Aiqun(Maria) Yu
Quoted 5 lines · Aiqun Yu (Maria)
Quoted 4 lines · Konrad Dybcio
Quoted 3 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Rob Herring (Arm) <[email protected]>---
Funny, the sideinteraction compatible is undocumented and the touchscreen driver is not upstream
Does the compatible also need to be fixed to "focaltech,ft8719"? Refer to the info from [1].
+Alexander, Caleb - would you like to look into this on axolotl?
Quoted 6 lines
Confirmed, the compatible "focaltech,fts8719" is not even in any merged bindings or drivers. Instead, "focaltech,ft8719" is in the current driver and bindings.
By the way, I am curious about how Rob finds the unused properties. Could you share some steps?
make ARCH=arm64 LLVM=1 -j24 CHECK_DTBS=1 dtbs
returns all kinds of errors, including "undocumented property"
Konrad
Quoted 2 lines
Rob Herring
maintainerQuoted 22 lines · Konrad Dybcio
Quoted 5 lines · Aiqun Yu (Maria)
Quoted 4 lines · Konrad Dybcio
Quoted 3 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Rob Herring (Arm) <[email protected]>---
Funny, the sideinteraction compatible is undocumented and the touchscreen driver is not upstream
Does the compatible also need to be fixed to "focaltech,ft8719"? Refer to the info from [1].
+Alexander, Caleb - would you like to look into this on axolotl?
Quoted 4 lines
Confirmed, the compatible "focaltech,fts8719" is not even in any merged bindings or drivers. Instead, "focaltech,ft8719" is in the current driver and bindings.
Quoted 6 lines
Quoted 2 lines
By the way, I am curious about how Rob finds the unused properties. Could you share some steps?
make ARCH=arm64 LLVM=1 -j24 CHECK_DTBS=1 dtbs
returns all kinds of errors, including "undocumented property"
This case however was a dtschema change I have not yet committed. Plenty of other things to fix still with the above command though. :(
Rob
Quoted 27 lines · Rob Herring
Quoted 25 lines · Konrad Dybcio
Quoted 5 lines · Aiqun Yu (Maria)
Quoted 4 lines · Konrad Dybcio
Quoted 3 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Quoted 8 lines
Quoted 5 lines
Quoted 2 lines
Signed-off-by Rob Herring (Arm) <[email protected]>---
Funny, the sideinteraction compatible is undocumented and the touchscreen driver is not upstream
Does the compatible also need to be fixed to "focaltech,ft8719"? Refer to the info from [1].
+Alexander, Caleb - would you like to look into this on axolotl?
Quoted 6 lines
Confirmed, the compatible "focaltech,fts8719" is not even in any merged bindings or drivers. Instead, "focaltech,ft8719" is in the current driver and bindings.
By the way, I am curious about how Rob finds the unused properties. Could you share some steps?
Quoted 6 lines
Quoted 3 lines
make ARCH=arm64 LLVM=1 -j24 CHECK_DTBS=1 dtbs
returns all kinds of errors, including "undocumented property"
This case however was a dtschema change I have not yet committed. Plenty of other things to fix still with the above command though. :(
Thanks, Rob and Konrad, for the clarification. That answers my question about the intention behind the current change.
Signature · 2 lines
Thx and BRs, Aiqun(Maria) Yu
Quoted 4 lines · Rob Herring (Arm)
Remove properties which are both unused in the kernel and undocumented. Most likely they are leftovers from downstream.
Applied, thanks!
[1/1] arm64: dts: qcom: Remove unused and undocumented properties
commit: 6888a9559053cd3ee6a116f34edba8d2793b5697
Best regards,
Signature · 1 line
Bjorn Andersson <[email protected]>