Skip to contentSkip to conversation

perf test: Add missing __exit calls in tool/hwmon tests

PATCH Applied Ian Rogers 2 participants 2 messages Nov 15, 2024 – Nov 16, 2024 perf events

lore
Share & tools
lore

Ian Rogers

author reviewer
#0 lore raw

PATCH 1/1 perf test: Add missing __exit calls in tool/hwmon tests

Address sanitizer flagged the missing parse_events_error__exit when testing on ARM.

---
 tools/perf/tests/hwmon_pmu.c | 1 +
 tools/perf/tests/tool_pmu.c  | 1 +
 2 files changed, 2 insertions(+)
tools/perf/tests/hwmon_pmu.c +1 -0
index 5c4114354c65..9f44093f18df 100644
@@ -194,6 +194,7 @@ static int do_test(size_t i, bool with_pmu, bool with_alias)
 	}
 
 out:
+	parse_events_error__exit(&err);
 	evlist__delete(evlist);
 	return ret;
 }
tools/perf/tests/tool_pmu.c +1 -0
index 46896b485abf..187942b749b7 100644
@@ -66,6 +66,7 @@ static int do_test(enum tool_pmu_event ev, bool with_pmu)
 	}
 
 out:
+	parse_events_error__exit(&err);
 	evlist__delete(evlist);
 	return ret;
 }
Signature · 1 line
2.47.0.338.g60cca15819-goog
maintainer Applied
#1 lore raw
Quoted 2 lines · Ian Rogers

Address sanitizer flagged the missing parse_events_error__exit when testing on ARM.

Thanks, applied to perf-tools-next,

- Arnaldo

Quoted 32 lines
---
 tools/perf/tests/hwmon_pmu.c | 1 +
 tools/perf/tests/tool_pmu.c  | 1 +
 2 files changed, 2 insertions(+)
tools/perf/tests/hwmon_pmu.c +1 -0
index 5c4114354c65..9f44093f18df 100644
@@ -194,6 +194,7 @@ static int do_test(size_t i, bool with_pmu, bool with_alias)
 	}
 
 out:
+	parse_events_error__exit(&err);
 	evlist__delete(evlist);
 	return ret;
 }
tools/perf/tests/tool_pmu.c +1 -0
index 46896b485abf..187942b749b7 100644
@@ -66,6 +66,7 @@ static int do_test(enum tool_pmu_event ev, bool with_pmu)
 	}
 
 out:
+	parse_events_error__exit(&err);
 	evlist__delete(evlist);
 	return ret;
 }
Signature · 1 line
2.47.0.338.g60cca15819-goog