Skip to contentSkip to conversation

ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`

PATCH In review Mario Limonciello 3 participants 3 messages Nov 18, 2024 – Nov 19, 2024

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 ASoC: amd: Fix build dependencies for `SND_SOC_AMD_PS`

From: Mario Limonciello <[email protected]>

The pci-ps module now must have SND_SOC_ACPI_AMD_MATCH selected to reference the snd_soc_acpi_amd_acp63_sdw_machines symbol.

Fixes 56d540befd59 ("ASoC: amd: ps: add soundwire machines for acp6.3 platform")
---
 sound/soc/amd/Kconfig | 1 +
 1 file changed, 1 insertion(+)
sound/soc/amd/Kconfig +1 -0
index 6dec44f516c13..c7590d4989bba 100644
@@ -163,6 +163,7 @@ config SND_SOC_AMD_SOUNDWIRE
 config SND_SOC_AMD_PS
         tristate "AMD Audio Coprocessor-v6.3 Pink Sardine support"
 	select SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
+	select SND_SOC_ACPI_AMD_MATCH
         depends on X86 && PCI && ACPI
         help
           This option enables Audio Coprocessor i.e ACP v6.3 support on
Signature · 1 line
2.43.0
#1 lore raw
Quoted 10 lines · Mario Limonciello

From: Mario Limonciello <[email protected]>

The pci-ps module now must have SND_SOC_ACPI_AMD_MATCH selected to reference the snd_soc_acpi_amd_acp63_sdw_machines symbol.

Fixes 56d540befd59 ("ASoC: amd: ps: add soundwire machines for acp6.3 platform")

LKP robot reported again, so one more tag to add.

Quoted 16 lines
---
  sound/soc/amd/Kconfig | 1 +
  1 file changed, 1 insertion(+)
sound/soc/amd/Kconfig +1 -0
index 6dec44f516c13..c7590d4989bba 100644
@@ -163,6 +163,7 @@ config SND_SOC_AMD_SOUNDWIRE
  config SND_SOC_AMD_PS
          tristate "AMD Audio Coprocessor-v6.3 Pink Sardine support"
  	select SND_SOC_AMD_SOUNDWIRE_LINK_BASELINE
+	select SND_SOC_ACPI_AMD_MATCH
          depends on X86 && PCI && ACPI
          help
            This option enables Audio Coprocessor i.e ACP v6.3 support on
maintainer
#2 lore raw
In reply to Mario Limonciello
Quoted 4 lines · Mario Limonciello

The pci-ps module now must have SND_SOC_ACPI_AMD_MATCH selected to reference the snd_soc_acpi_amd_acp63_sdw_machines symbol.

Applied to

https://git.kernel.org/pub/scm/linux/kernel/git/broonie/sound.git for-next

Thanks!

[1/1] ASoC: amd: Fix build dependencies for SND_SOC_AMD_PS

      commit: 0109ee00788e0ad7b888a799c26b5a93b343876b

All being well this means that it will be integrated into the linux-next tree (usually sometime in the next 24 hours) and sent to Linus during the next merge window (or sooner if it is a bug fix), however if problems are discovered then the patch may be dropped or reverted.

You may get further e-mails resulting from automated or manual testing and review of the tree, please engage with people reporting problems and send followup patches addressing any issues that are reported if needed.

If any updates are required or you are submitting further changes they should be sent as incremental updates against current git, existing patches will not be replaced.

Please add any relevant lists and maintainers to the CCs when replying to this mail.

Thanks,
Mark