media: rkisp1: Fix unused value issue

PATCH Superseded Dheeraj Reddy Jonnalagadda 1 participant 1 message Nov 18, 2024

Subsystems (3)

Media (V4L/DVB) Arm Rockchip Rockchip ISP V1 driver

lore

Share & tools

lore

Dheeraj Reddy Jonnalagadda

author

2024-11-18 08:27 UTC #0 lore raw

PATCH 1/1 media: rkisp1: Fix unused value issue

This commit fixes an unused value issue detected by Coverity (CID 1519008). If ret is set to an error value in the switch statement, it is not handled before being overwritten later.

Signed-off-by Dheeraj Reddy Jonnalagadda <[email protected]>

---
 drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c | 3 +++
 1 file changed, 3 insertions(+)

drivers/media/platform/rockchip/rkisp1/rkisp1-dev.c +3 -0

index dd114ab77800..9ad5026ab10a 100644
@@ -228,6 +228,9 @@ static int rkisp1_subdev_notifier_register(struct rkisp1_device *rkisp1)
 			break;
 		}
 
+		if (ret)
+			break;
+
 		/* Parse the endpoint and validate the bus type. */
 		ret = v4l2_fwnode_endpoint_parse(ep, &vep);
 		if (ret) {

Signature · 1 line

2.34.1