regmap: Drop unused devm_regmap_*_free() APIs
Subsystems (2)
PATCH 1/1 regmap: Drop unused devm_regmap_*_free() APIs
Besides the fact that currently defined devm_*_free() APIs are being unused, it's usually a sign of bad design to call such explicitly. Drop them and make people pay more attention on the misuse of devm_regmap_*() APIs,
Signed-off-by Andy Shevchenko <[email protected]>
--- drivers/base/regmap/regmap.c | 36 ------------------------------------ include/linux/regmap.h | 3 --- 2 files changed, 39 deletions(-)
drivers/base/regmap/regmap.c +0 -36
@@ -1320,42 +1320,6 @@ void regmap_field_bulk_free(struct regmap_field *field) }EXPORT_SYMBOL_GPL (regmap_field_bulk_free); -/** -* devm_regmap_field_bulk_free() - Free a bulk register field allocated using -* devm_regmap_field_bulk_alloc. -* -* @dev: Device that will be interacted with -* @field: regmap field which should be freed. -* -* Free register field allocated using devm_regmap_field_bulk_alloc(). Usually -* drivers need not call this function, as the memory allocated via devm -* will be freed as per device-driver life-cycle. -*/ -void devm_regmap_field_bulk_free (struct device *dev, -struct regmap_field *field) -{ -devm_kfree (dev, field); -} -EXPORT_SYMBOL_GPL (devm_regmap_field_bulk_free); - -/** -* devm_regmap_field_free() - Free a register field allocated using -* devm_regmap_field_alloc. -* -* @dev: Device that will be interacted with -* @field: regmap field which should be freed. -* -* Free register field allocated using devm_regmap_field_alloc(). Usually -* drivers need not call this function, as the memory allocated via devm -* will be freed as per device-driver life-cyle. -*/ -void devm_regmap_field_free (struct device *dev, -struct regmap_field *field) -{ -devm_kfree (dev, field); -} -EXPORT_SYMBOL_GPL (devm_regmap_field_free); -/** * regmap_field_alloc() - Allocate and initialise a register field. *
include/linux/regmap.h +0 -3
@@ -1383,7 +1383,6 @@ void regmap_field_free(struct regmap_field *field);struct regmap_field *devm_regmap_field_alloc (struct device *dev,struct regmap *regmap,struct reg_field reg_field); -void devm_regmap_field_free (struct device *dev,struct regmap_field *field); int regmap_field_bulk_alloc(struct regmap *regmap, struct regmap_field **rm_field,
@@ -1394,8 +1393,6 @@ int devm_regmap_field_bulk_alloc(struct device *dev, struct regmap *regmap,struct regmap_field **field, const struct reg_field *reg_field, int num_fields); -void devm_regmap_field_bulk_free (struct device *dev, -struct regmap_field *field);int regmap_field_read (struct regmap_field *field,unsigned int *val); int regmap_field_update_bits_base(struct regmap_field *field,
Signature · 1 line
2.43.0.rc1.1336.g36b5255a03ac
Quoted 4 lines · Andy Shevchenko
Besides the fact that currently defined devm_*_free() APIs are being unused, it's usually a sign of bad design to call such explicitly. Drop them and make people pay more attention on the misuse of devm_regmap_*() APIs,
Any comments on this one?
Signature · 2 lines
With Best Regards, Andy Shevchenko