rust: give Clippy the minimum supported Rust version
Miguel Ojeda
maintainerRFC PATCH 1/1 rust: give Clippy the minimum supported Rust version
Clippy's lints may avoid emitting a suggestion to use a language or library feature that is not supported by the minimum supported version, if given by the msrv field in the configuration file.
For instance, Clippy should not suggest using let ... else in a lint if the MSRV did not implement that syntax.
If the MSRV is not provided, Clippy will assume all features are available.
Thus enable it with the minimum Rust version the kernel supports.
Note that there is currently a small disadvantage in doing so: since we still use unstable features that nevertheless work in the range of versions we support (e.g. #[expect(...)]), we lose suggestions for those. However, over time we will stop using unstable features (especially language and library ones) as it is our goal, thus, in the end, we will want to have the msrv set.
Rust is also considering adding a similar feature in rustc too, which we should probably enable if it becomes available [2].
--- .clippy.toml | 2 ++ 1 file changed, 2 insertions(+)
.clippy.toml +2 -0
@@ -1,5 +1,7 @@ # SPDX-License-Identifier: GPL-2.0 +msrv = "1.78.0" + check-private-items = true disallowed-macros = [
base-commit: b2603f8ac8217bc59f5c7f248ac248423b9b99cb
Signature · 1 line
2.47.0
Quoted 19 lines · Miguel Ojeda
Clippy's lints may avoid emitting a suggestion to use a language or library feature that is not supported by the minimum supported version, if given by the
msrvfield in the configuration file.For instance, Clippy should not suggest using
let ... elsein a lint if the MSRV did not implement that syntax.If the MSRV is not provided, Clippy will assume all features are available.
Thus enable it with the minimum Rust version the kernel supports.
Note that there is currently a small disadvantage in doing so: since we still use unstable features that nevertheless work in the range of versions we support (e.g.
#[expect(...)]), we lose suggestions for those. However, over time we will stop using unstable features (especially language and library ones) as it is our goal, thus, in the end, we will want to have themsrvset.
Quoted 6 lines
Rust is also considering adding a similar feature in
rustctoo, which we should probably enable if it becomes available [2].
Miguel Ojeda
AppliedQuoted 19 lines · Miguel Ojeda
Clippy's lints may avoid emitting a suggestion to use a language or library feature that is not supported by the minimum supported version, if given by the
msrvfield in the configuration file.For instance, Clippy should not suggest using
let ... elsein a lint if the MSRV did not implement that syntax.If the MSRV is not provided, Clippy will assume all features are available.
Thus enable it with the minimum Rust version the kernel supports.
Note that there is currently a small disadvantage in doing so: since we still use unstable features that nevertheless work in the range of versions we support (e.g.
#[expect(...)]), we lose suggestions for those. However, over time we will stop using unstable features (especially language and library ones) as it is our goal, thus, in the end, we will want to have themsrvset.
Quoted 6 lines
Rust is also considering adding a similar feature in
rustctoo, which we should probably enable if it becomes available [2].
Applied to rust-next -- thanks!
Cheers,
Miguel