usb: collapse USB_STORAGE Kconfig comment
Subsystems (2)
PATCH 1/1 usb: collapse USB_STORAGE Kconfig comment
The two Kconfig "comment" calls render in /proc/config.gz as split sections:
---
#
# NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may #
#
# also be needed; see USB_STORAGE Help for more info # ---
"make menuconfig" renders the comments as:
---
*** NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may *** *** also be needed; see USB_STORAGE Help for more info ***
---
Kconfig doesn't support splitting a comment cleanly over two lines, so just collapse it into a single oversize comment.
Given the content of the comment, it might make more sense to change it to a '#' Kconfig source file comment, or drop it altogether.
--- drivers/usb/storage/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/usb/storage/Kconfig +1 -2
@@ -3,8 +3,7 @@ # USB Storage driver configuration # -comment "NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may" -comment "also be needed; see USB_STORAGE Help for more info" +comment "NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may also be needed; see USB_STORAGE Help for more info" config USB_STORAGE tristate "USB Mass Storage support"
Signature · 1 line
2.43.0
Quoted 11 lines · David Disseldorp
The two
Kconfig"comment" calls render in/proc/config.gzas split sections:
---
#
# NOTE:USB_STORAGEdepends on SCSI butBLK_DEV_SDmay ##
# also be needed; see USB_STORAGE Help for more info # ---
You'll need to rewrite this message; the "---" lines will confuse people's patch-handling tools.
Quoted 7 lines
"make menuconfig" renders the comments as:
---
*** NOTE:USB_STORAGEdepends on SCSI butBLK_DEV_SDmay *** *** also be needed; seeUSB_STORAGEHelp for more info ***
---
Quoted 5 lines
Kconfigdoesn't support splitting a comment cleanly over two lines, so just collapse it into a single oversize comment.Given the content of the comment, it might make more sense to change it to a '#'
Kconfigsource file comment, or drop it altogether.
I think making it one long line is fine. When you resubmit, you can add:
Quoted 21 lines
Signed-off-by David Disseldorp <[email protected]>--- drivers/usb/storage/Kconfig | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)drivers/usb/storage/Kconfig +1
-2@@ -3,8 +3,7 @@ # USB Storage driver configuration # -comment "NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may" -comment "also be needed; see USB_STORAGE Help for more info" +comment "NOTE: USB_STORAGE depends on SCSI but BLK_DEV_SD may also be needed; see USB_STORAGE Help for more info" config USB_STORAGE tristate "USB Mass Storage support"Signature · 1 line
2.43.0
Alan Stern