sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used()
Valentin Schneider
reviewerPATCH 1/1 sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used()
Andy reported that clang gets upset with CONFIG_CFS_BANDWIDTH=n:
kernel/sched/fair.c:6580:20: error: unused function 'cfs_bandwidth_used' [-Werror,-Wunused-function]
6580 | static inline bool cfs_bandwidth_used(void)
| ^~~~~~~~~~~~~~~~~~
Indeed, cfs_bandwidth_used() is only used within functions defined under CONFIG_CFS_BANDWIDTH=y. Remove its CONFIG_CFS_BANDWIDTH=n declaration & definition.
--- kernel/sched/fair.c | 7 ------- 1 file changed, 7 deletions(-)
kernel/sched/fair.c +0 -7
@@ -5373,8 +5373,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)static void check_enqueue_throttle (struct cfs_rq *cfs_rq);static inline int cfs_rq_throttled (struct cfs_rq *cfs_rq); -static inline bool cfs_bandwidth_used (void ); -static void requeue_delayed_entity (struct sched_entity *se);
@@ -6747,11 +6745,6 @@ static void sched_fair_update_stop_tick(struct rq *rq, struct task_struct *p)#else /* CONFIG_CFS_BANDWIDTH */ -static inline bool cfs_bandwidth_used (void ) -{ -return false; -} -static void account_cfs_rq_runtime (struct cfs_rq *cfs_rq,u64 delta_exec) {}static bool check_cfs_rq_runtime (struct cfs_rq *cfs_rq) {return false; }static void check_enqueue_throttle (struct cfs_rq *cfs_rq) {}
Signature · 1 line
2.43.0
Quoted 10 lines · Valentin Schneider
Andy reported that clang gets upset with
CONFIG_CFS_BANDWIDTH=n:
kernel/sched/fair.c:6580:20: error: unused function 'cfs_bandwidth_used' [-Werror,-Wunused-function]
6580 | static inline boolcfs_bandwidth_used(void)| ^~~~~~~~~~~~~~~~~~Indeed,
cfs_bandwidth_used()is only used within functions defined underCONFIG_CFS_BANDWIDTH=y. Remove itsCONFIG_CFS_BANDWIDTH=ndeclaration & definition.
Thank you for fixing this issue!
Signature · 2 lines
With Best Regards, Andy Shevchenko
The following commit has been merged into the sched/core branch of tip:
The following commit has been merged into the sched/core branch of tip:
Commit-ID: a76328d44c7ab7d1001a97cb2e84506dde7822d4 Gitweb: https://git.kernel.org/tip/a76328d44c7ab7d1001a97cb2e84506dde7822d4 Author: Valentin Schneider <[email protected]> AuthorDate: Wed, 27 Nov 2024 17:55:01 +01:00 Committer: Peter Zijlstra <[email protected]> CommitterDate: Mon, 02 Dec 2024 12:01:31 +01:00
sched/fair: Remove CONFIG_CFS_BANDWIDTH=n definition of cfs_bandwidth_used()
Andy reported that clang gets upset with CONFIG_CFS_BANDWIDTH=n:
kernel/sched/fair.c:6580:20: error: unused function 'cfs_bandwidth_used' [-Werror,-Wunused-function]
6580 | static inline bool cfs_bandwidth_used(void)
| ^~~~~~~~~~~~~~~~~~
Indeed, cfs_bandwidth_used() is only used within functions defined under CONFIG_CFS_BANDWIDTH=y. Remove its CONFIG_CFS_BANDWIDTH=n declaration & definition.
--- kernel/sched/fair.c | 7 ------- 1 file changed, 7 deletions(-)
kernel/sched/fair.c +0 -7
@@ -5373,8 +5373,6 @@ place_entity(struct cfs_rq *cfs_rq, struct sched_entity *se, int flags)static void check_enqueue_throttle (struct cfs_rq *cfs_rq);static inline int cfs_rq_throttled (struct cfs_rq *cfs_rq); -static inline bool cfs_bandwidth_used (void ); -static void requeue_delayed_entity (struct sched_entity *se);
@@ -6748,11 +6746,6 @@ static void sched_fair_update_stop_tick(struct rq *rq, struct task_struct *p)#else /* CONFIG_CFS_BANDWIDTH */ -static inline bool cfs_bandwidth_used (void ) -{ -return false; -} -static void account_cfs_rq_runtime (struct cfs_rq *cfs_rq,u64 delta_exec) {}static bool check_cfs_rq_runtime (struct cfs_rq *cfs_rq) {return false; }static void check_enqueue_throttle (struct cfs_rq *cfs_rq) {}