nvmet: replace kmalloc + memset with kzalloc for data allocation
Subsystems (2)
PATCH 1/1 nvmet: replace kmalloc + memset with kzalloc for data allocation
cocci warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
The pattern of using 'kmalloc' followed by 'memset' is replaced with 'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset', but more efficient. 'kzalloc' automatically zeroes the allocated memory, making it a faster and more streamlined solution.
---
build test only.
drivers/nvme/target/pr.c | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-)
drivers/nvme/target/pr.c +1 -2
@@ -828,12 +828,11 @@ static void nvmet_execute_pr_report(struct nvmet_req *req) goto out; } - data =kmalloc (num_bytes,GFP_KERNEL ); + data =kzalloc (num_bytes,GFP_KERNEL );if (!data) { status =NVME_SC_INTERNAL ; goto out; } -memset (data,0 , num_bytes); data->gen =cpu_to_le32 (atomic_read (&pr->generation)); data->ptpls =0 ; ctrl_eds = data->regctl_eds;
Signature · 1 line
2.43.0
Looks good:
Quoted 11 lines · Yu-Chun Lin
cocci warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
The pattern of using 'kmalloc' followed by 'memset' is replaced with 'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset', but more efficient. 'kzalloc' automatically zeroes the allocated memory, making it a faster and more streamlined solution.
Reported-by kernel test robot<[email protected]>Reviewed-by Kuan-Wei Chiu<[email protected]>Signed-off-by Yu-Chun Lin<[email protected]>
Looks good.
-ck
Quoted 7 lines · Yu-Chun Lin
cocci warnings: (new ones prefixed by >>)
Quoted 1 line
Quoted 1 line
drivers/nvme/target/pr.c:831:8-15: WARNING: kzalloc should be used for data, instead of kmalloc/memset
The pattern of using 'kmalloc' followed by 'memset' is replaced with 'kzalloc', which is functionally equivalent to 'kmalloc' + 'memset', but more efficient. 'kzalloc' automatically zeroes the allocated memory, making it a faster and more streamlined solution.
Thanks, applied to nvme-6.13.