Skip to contentSkip to conversation

f2fs/005: update commit id in _fixed_by_kernel_commit line

PATCH In review Chao Yu 2 participants 5 messages Dec 2, 2024 – Dec 3, 2024

lore
Share & tools
lore

Chao Yu

author
#0 lore raw

PATCH 1/3 f2fs/005: update commit id in _fixed_by_kernel_commit line

The bug related to this regression testcase has been fixed by commit d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit line.

Cc Jaegeuk Kim <[email protected]>
---
 tests/f2fs/005 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/f2fs/005 +1 -1
index a817d51a..33d4fdb9 100755
@@ -11,7 +11,7 @@
 . ./common/preamble
 _begin_fstest auto quick
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit d5c367ef8287 \
 	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."
 
 _require_scratch
Signature · 1 line
2.40.1
author
#1 lore raw

PATCH 2/3 f2fs/006: update commit id in _fixed_by_kernel_commit line

The bug related to this regression testcase has been fixed by commit 1acd73edbbfe ("f2fs: fix to account dirty data in __get_secs_required()"), let's update commit id in _fixed_by_kernel_commit line.

Cc Jaegeuk Kim <[email protected]>
---
 tests/f2fs/006 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/f2fs/006 +1 -1
index a9c823c1..c1f8d4ff 100755
@@ -16,7 +16,7 @@
 . ./common/preamble
 _begin_fstest auto quick
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 1acd73edbbfe \
 	"f2fs: fix to account dirty data in __get_secs_required()"
 
 _require_scratch
Signature · 1 line
2.40.1
author
#2 lore raw

PATCH 3/3 f2fs/007: update commit id in _fixed_by_kernel_commit line

In reply to Chao Yu

The bug related to this regression testcase has been fixed by commit 26413ce18e85 ("f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks"), let's update commit id in _fixed_by_kernel_commit line.

Cc Jaegeuk Kim <[email protected]>
---
 tests/f2fs/007 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/f2fs/007 +1 -1
index 6451d4b4..37388433 100755
@@ -11,7 +11,7 @@
 . ./common/preamble
 _begin_fstest auto quick rw compress
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit 26413ce18e85 \
         "f2fs: compress: fix inconsistent update of i_blocks in release_compress_blocks and reserve_compress_blocks"
 
 _require_scratch
Signature · 1 line
2.40.1
Reviewed-by on v1 1/3
#3 lore raw
In reply to Chao Yu
Quoted 16 lines · Chao Yu

The bug related to this regression testcase has been fixed by commit d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit line.

Cc Jaegeuk Kim <[email protected]>
---
 tests/f2fs/005 | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
tests/f2fs/005 +0 -0
index a817d51a..33d4fdb9 100755

tests/f2fs/005 line 15

Quoted 6 lines
tests/f2fs/005 +1 -1
@@ -11,7 +11,7 @@
 . ./common/preamble
 _begin_fstest auto quick
 
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit d5c367ef8287 \
 	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."

I think we don't need to use 3 patches. As you just add missed commit id number, just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit". Or if you hope I can do that when I merge it, feel free to tell me :)

Others look good to me, with above change:

Quoted 5 lines
tests/f2fs/005 +0 -0
 _require_scratch
Signature · 1 line
2.40.1
author
#4 lore raw
Quoted 20 lines · Zorro Lang
Quoted 19 lines · Chao Yu

The bug related to this regression testcase has been fixed by commit d5c367ef8287 ("f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."), let's update commit id in _fixed_by_kernel_commit line.

Cc Jaegeuk Kim <[email protected]>
---
  tests/f2fs/005 | 2 +-
  1 file changed, 1 insertion(+), 1 deletion(-)
tests/f2fs/005 +0 -0
index a817d51a..33d4fdb9 100755
@@ -11,7 +11,7 @@
  . ./common/preamble
  _begin_fstest auto quick
 
Quoted 7 lines

tests/f2fs/005 line 15

Quoted 3 lines
tests/f2fs/005 +1 -1
-_fixed_by_kernel_commit xxxxxxxxxxxx \
+_fixed_by_kernel_commit d5c367ef8287 \
  	"f2fs: fix f2fs_bug_on when uninstalling filesystem call f2fs_evict_inode."

I think we don't need to use 3 patches. As you just add missed commit id number, just merge them into one and named "f2fs: add commit id to _fixed_by_kernel_commit". Or if you hope I can do that when I merge it, feel free to tell me :)

Zorro,

I've sent a new patch, can you please help to review it? thank you.

Thanks,

Quoted 11 lines

Others look good to me, with above change:

Quoted 5 lines
tests/f2fs/005 +0 -0
  _require_scratch
Signature · 1 line
2.40.1