Skip to contentSkip to conversation

parisc: Remove memcpy_toio and memset_io

PATCH Applied Julian Vetter 2 participants 2 messages Dec 4, 2024 – Dec 7, 2024 PA-RISC architecture

lore
Share & tools
lore
#0 lore raw

PATCH v2 1/1 parisc: Remove memcpy_toio and memset_io

Recently new functions for IO memcpy and IO memset were added in libs/iomem_copy.c. So, remove the arch specific implementations, to fall back to the generic ones which do exactly the same. Keep memcpy_fromio for now, because it's slight more optimized by doing 'u16' accesses if the buffer is aligned this way.

---
 arch/parisc/include/asm/io.h      |  4 ---
 arch/parisc/kernel/parisc_ksyms.c |  2 --
 arch/parisc/lib/io.c              | 47 -------------------------------
 3 files changed, 53 deletions(-)
arch/parisc/include/asm/io.h +0 -4
index a63190af2f05..3143cf29ce27 100644
@@ -135,12 +135,8 @@ static inline void gsc_writeq(unsigned long long val, unsigned long addr)
 
 #define pci_iounmap			pci_iounmap
 
-void memset_io(volatile void __iomem *addr, unsigned char val, int count);
 void memcpy_fromio(void *dst, const volatile void __iomem *src, int count);
-void memcpy_toio(volatile void __iomem *dst, const void *src, int count);
-#define memset_io memset_io
 #define memcpy_fromio memcpy_fromio
-#define memcpy_toio memcpy_toio
 
 /* Port-space IO */
 
arch/parisc/kernel/parisc_ksyms.c +0 -2
index c1587aa35beb..1c366b0d3134 100644
@@ -43,9 +43,7 @@ EXPORT_SYMBOL($global$);
 #endif
 
 #include <asm/io.h>
-EXPORT_SYMBOL(memcpy_toio);
 EXPORT_SYMBOL(memcpy_fromio);
-EXPORT_SYMBOL(memset_io);
 
 extern void $$divI(void);
 extern void $$divU(void);
arch/parisc/lib/io.c +0 -47

59 lines not on this page · raw message

Signature · 1 line
2.34.1
maintainer Applied
#1 lore raw
Quoted 6 lines · Julian Vetter

Recently new functions for IO memcpy and IO memset were added in libs/iomem_copy.c. So, remove the arch specific implementations, to fall back to the generic ones which do exactly the same. Keep memcpy_fromio for now, because it's slight more optimized by doing 'u16' accesses if the buffer is aligned this way.

Quoted 6 lines
---
  arch/parisc/include/asm/io.h      |  4 ---
  arch/parisc/kernel/parisc_ksyms.c |  2 --
  arch/parisc/lib/io.c              | 47 -------------------------------
  3 files changed, 53 deletions(-)

applied.

Thanks!
Helge