Skip to contentSkip to conversation

FIX: NO_CAST.INTEGER_OVERFLOW in ubirsvol.c

PATCH New Anton Moryakov 1 participant 1 message Dec 9, 2024 Memory technology devices (MTD)

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 FIX: NO_CAST.INTEGER_OVERFLOW in ubirsvol.c

Report of the static analyzer:
The value of an arithmetic expression 'vol_info.leb_size * args.lebs' is a subject to overflow because its operands are not cast to a larger data type before performing arithmetic

Corrections explained:
The fix ensures values ​​are checked before multiplication. Added casting vol_info.leb_size to long long

Triggers found by static analyzer Svace.

---
 ubi-utils/ubirsvol.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
ubi-utils/ubirsvol.c +1 -1
index 0854abc..73d2f68 100644
@@ -231,7 +231,7 @@ int main(int argc, char * const argv[])
 	}
 
 	if (args.lebs != -1)
-		args.bytes = vol_info.leb_size * args.lebs;
+		args.bytes = (long long)vol_info.leb_size * args.lebs;
 
 	err = ubi_rsvol(libubi, args.node, args.vol_id, args.bytes);
 	if (err) {
Signature · 6 lines
2.30.2


______________________________________________________
Linux MTD discussion mailing list
http://lists.infradead.org/mailman/listinfo/linux-mtd/