Skip to contentSkip to conversation

riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions

PATCH Applied E Shattow 3 participants 5 messages Dec 10, 2024 – Dec 16, 2024

Subsystems (3)
lore
Share & tools
lore

E Shattow

author
#0 lore raw

PATCH 1/1 riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions

Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")
---
 arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pinfunc.h +1 -1
index 256de17f5261..ae49c908e7fb 100644
@@ -89,7 +89,7 @@
 #define GPOUT_SYS_SDIO1_DATA1			59
 #define GPOUT_SYS_SDIO1_DATA2			60
 #define GPOUT_SYS_SDIO1_DATA3			61
-#define GPOUT_SYS_SDIO1_DATA4			63
+#define GPOUT_SYS_SDIO1_DATA4			62
 #define GPOUT_SYS_SDIO1_DATA5			63
 #define GPOUT_SYS_SDIO1_DATA6			64
 #define GPOUT_SYS_SDIO1_DATA7			65
Signature · 1 line
2.45.2
#1 lore raw
Quoted 6 lines · E Shattow

Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")

---

Why are you sending the same multiple times? Where is the changelog and proper patch versioning?

Best regards,
Krzysztof

author
#2 lore raw

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · E Shattow

Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")

---

Quoted 6 lines

Why are you sending the same multiple times? Where is the changelog and proper patch versioning?

Best regards,
Krzysztof

I did respond to Hal's comment that the patch is missing a commit title description and that I would re-send. How instead should the message be formatted so the patch commit title description is changed but the patch is not the same being sent multiple times? And now, again, based on your comment that this is not a typo I will again change the commit description but I don't know how to do that without sending again as a duplicate.

Thank you for the review and for your patience with me when I am learning how to participate.

-E

maintainer
#3 lore raw
Quoted 25 lines · E Shattow

Hi Krzysztof,

Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · E Shattow

Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")

---

Quoted 6 lines

Why are you sending the same multiple times? Where is the changelog and proper patch versioning?

Best regards,
Krzysztof

I did respond to Hal's comment that the patch is missing a commit title description and that I would re-send. How instead should the message be formatted so the patch commit title description is changed but the patch is not the same being sent multiple times? And now, again, based on your comment that this is not a typo I will again change the commit description but I don't know how to do that without sending again as a duplicate.

Quoted 2 lines

Thank you for the review and for your patience with me when I am learning how to participate.

FWIW, this should be v2. Don't resend for that.

maintainer Applied
#4 lore raw
In reply to E Shattow

From: Conor Dooley <[email protected]>

Quoted 3 lines · E Shattow

Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4

Applied to riscv-dt-for-next, thanks!

[1/1] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
(no commit info)

Thanks,
Conor.