riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Subsystems (3)
PATCH 1/1 riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
Fix a typo in StarFive JH7110 pin function definitions for GPOUT_SYS_SDIO1_DATA4
--- arch/riscv/boot/dts/starfive/jh7110-pinfunc.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/riscv/boot/dts/starfive/jh7110-pinfunc.h +1 -1
@@ -89,7 +89,7 @@#define GPOUT_SYS_SDIO1_DATA1 59#define GPOUT_SYS_SDIO1_DATA2 60#define GPOUT_SYS_SDIO1_DATA3 61 -#define GPOUT_SYS_SDIO1_DATA4 63 +#define GPOUT_SYS_SDIO1_DATA4 62#define GPOUT_SYS_SDIO1_DATA5 63#define GPOUT_SYS_SDIO1_DATA6 64#define GPOUT_SYS_SDIO1_DATA7 65
Signature · 1 line
2.45.2
Quoted 6 lines · E Shattow
Fix a typo in StarFive JH7110 pin function definitions for
GPOUT_SYS_SDIO1_DATA4Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")Signed-off-by E Shattow <[email protected]>Acked-by Hal Feng <[email protected]>---
Why are you sending the same multiple times? Where is the changelog and proper patch versioning?
Best regards,
Krzysztof
Hi Krzysztof,
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · E Shattow
Fix a typo in StarFive JH7110 pin function definitions for
GPOUT_SYS_SDIO1_DATA4Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")Signed-off-by E Shattow <[email protected]>Acked-by Hal Feng <[email protected]>---
Quoted 6 lines
Why are you sending the same multiple times? Where is the changelog and proper patch versioning?
Best regards,
Krzysztof
I did respond to Hal's comment that the patch is missing a commit title description and that I would re-send. How instead should the message be formatted so the patch commit title description is changed but the patch is not the same being sent multiple times? And now, again, based on your comment that this is not a typo I will again change the commit description but I don't know how to do that without sending again as a duplicate.
Thank you for the review and for your patience with me when I am learning how to participate.
-E
Conor Dooley
maintainerQuoted 25 lines · E Shattow
Hi Krzysztof,
Quoted 8 lines · Krzysztof Kozlowski
Quoted 6 lines · E Shattow
Fix a typo in StarFive JH7110 pin function definitions for
GPOUT_SYS_SDIO1_DATA4Fixes e22f09e598d12 ("riscv: dts: starfive: Add StarFive JH7110 pin function definitions")Signed-off-by E Shattow <[email protected]>Acked-by Hal Feng <[email protected]>---
Quoted 6 lines
Why are you sending the same multiple times? Where is the changelog and proper patch versioning?
Best regards,
KrzysztofI did respond to Hal's comment that the patch is missing a commit title description and that I would re-send. How instead should the message be formatted so the patch commit title description is changed but the patch is not the same being sent multiple times? And now, again, based on your comment that this is not a typo I will again change the commit description but I don't know how to do that without sending again as a duplicate.
Quoted 2 lines
Thank you for the review and for your patience with me when I am learning how to participate.
FWIW, this should be v2. Don't resend for that.
From: Conor Dooley <[email protected]>
Quoted 3 lines · E Shattow
Fix a typo in StarFive JH7110 pin function definitions for
GPOUT_SYS_SDIO1_DATA4
Applied to riscv-dt-for-next, thanks!
[1/1] riscv: dts: starfive: Fix a typo in StarFive JH7110 pin function definitions
(no commit info)
Thanks,
Conor.