Skip to contentSkip to conversation

efi/esrt: remove esre_attribute::store()

PATCH Applied Jiri Slaby (SUSE) 2 participants 2 messages Dec 11, 2024 – Dec 13, 2024 EFI

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 efi/esrt: remove esre_attribute::store()

esre_attribute::store() is not needed since commit af97a77bc01c (efi:
Move some sysfs files to be read-only by root). Drop it.

Found by https://github.com/jirislaby/clang-struct.

---
 drivers/firmware/efi/esrt.c | 2 --
 1 file changed, 2 deletions(-)
drivers/firmware/efi/esrt.c +0 -2
index 7a81c0ce4780..4bb7b0584bc9 100644
@@ -75,8 +75,6 @@ static LIST_HEAD(entry_list);
 struct esre_attribute {
 	struct attribute attr;
 	ssize_t (*show)(struct esre_entry *entry, char *buf);
-	ssize_t (*store)(struct esre_entry *entry,
-			 const char *buf, size_t count);
 };
 
 static struct esre_entry *to_entry(struct kobject *kobj)
Signature · 1 line
2.47.1
maintainer Applied
#1 lore raw
Quoted 9 lines · Jiri Slaby (SUSE)

esre_attribute::store() is not needed since commit af97a77bc01c (efi:
Move some sysfs files to be read-only by root). Drop it.

Found by https://github.com/jirislaby/clang-struct.

Queued up, thanks.

Quoted 20 lines
---
 drivers/firmware/efi/esrt.c | 2 --
 1 file changed, 2 deletions(-)
drivers/firmware/efi/esrt.c +0 -3
index 7a81c0ce4780..4bb7b0584bc9 100644
@@ -75,8 +75,6 @@ static LIST_HEAD(entry_list);
 struct esre_attribute {
        struct attribute attr;
        ssize_t (*show)(struct esre_entry *entry, char *buf);
-       ssize_t (*store)(struct esre_entry *entry,
-                        const char *buf, size_t count);
 };
 
 static struct esre_entry *to_entry(struct kobject *kobj)
--

2.47.1