Skip to contentSkip to conversation

libxkbcommon: remove locale dependecy

PATCH In review Hiago De Franco 2 participants 3 messages Dec 12, 2024 – Jan 13, 2025

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 libxkbcommon: remove locale dependecy

From: Hiago De Franco <[email protected]>

The error described does not occur in all cases where libxkbcommon is used. As example, a Qt application that depends on libxkbcommon might not require any locales to be installed.

Remove it from RDEPENDS, as libxkbcommon does not seen to have any hard dependency on libx11-compose-data or libx11-locale. This change can help save space in the rootfs.

---
 meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb | 4 ----
 1 file changed, 4 deletions(-)
meta/recipes-graphics/xorg-lib/libxkbcommon_1.7.0.bb +0 -4
index 40cf616f0bd2..c832dceb09c3 100644
@@ -31,10 +31,6 @@ python populate_packages:prepend () {
     do_split_packages(d, d.expand('${libdir}'), r'^(lib.*)\.so\.*', '%s', '%s library', extra_depends='', allow_links=True)
 }
 
-# Fix a following runtime error:
-# xkbcommon: ERROR: couldn't find a Compose file for locale "C"
-RDEPENDS:${PN} = "${@bb.utils.contains('DISTRO_FEATURES', 'x11', 'libx11-locale', 'libx11-compose-data', d)}"
-
 BBCLASSEXTEND += "native"
 
 CVE_PRODUCT += "xkbcommon:libxkbcommon"
Signature · 1 line
2.39.5
#1 lore raw
Quoted 6 lines · Hiago De Franco via lists.openembedded.org

From: Hiago De Franco <[email protected]>

The error described does not occur in all cases where libxkbcommon is used. As example, a Qt application that depends on libxkbcommon might not require any locales to be installed.

This breaks the use of the Compose key, as this needs the data in the locale files. I suggest making this a recommends instead, which you can then not install.

Ross

#2 lore raw
Quoted 9 lines · Ross Burton
Quoted 6 lines · Hiago De Franco via lists.openembedded.org

From: Hiago De Franco <[email protected]>

The error described does not occur in all cases where libxkbcommon is used. As example, a Qt application that depends on libxkbcommon might not require any locales to be installed.

This breaks the use of the Compose key, as this needs the data in the locale files. I suggest making this a recommends instead, which you can then not install.

Sure, I will prepare a v2.

Quoted 2 lines

Ross

Cheers,

Hiago.